create-spectacle Spectacle version fix. (#1192)

* Use workspace dependency

* Add changeset

* Update pnpm-lock.yaml

* Update packages/create-spectacle/src/cli.ts

Co-authored-by: Ryan Roemer <[email protected]>

* Fix spectacle import

* Ensure that src is root for TS build. Fix create-spectacle version for CLI output.

* Keep adding tsconfig files until the build passes.

* Change name of checking tsconfig.

* Fix main path

* Handle workspace in CI tests

Co-authored-by: Ryan Roemer <[email protected]>

Author: gksander

.changeset/tough-tigers-drive.md

@@ -0,0 +1,5 @@
+---
+'create-spectacle': patch
+---
+
+Fix spectacle version import

packages/create-spectacle/package.json

@@ -22,7 +22,7 @@
   },
   "peerDependencies": {},
   "devDependencies": {
-    "spectacle": "*",
+    "spectacle": "workspace:*",
     "@types/node": "^18.0.3"
   },
   "resolutions": {},
@@ -53,11 +53,12 @@
   },
   "wireit": {
     "build": {
-      "command": "tsc --p tsconfig.json",
+      "command": "tsc --p tsconfig.build.json",
       "files": [
         "src/**",
         "!src/**/*.test.*",
-        "tsconfig.json"
+        "tsconfig.json",
+        "tsconfig.build.json"
       ],
       "output": [
         "bin/**/*.js"
@@ -67,12 +68,12 @@
       ]
     },
     "types:check": {
-      "command": "nps types:check -- -- --p tsconfig.all.json",
+      "command": "nps types:check -- -- --p tsconfig.typecheck.json",
       "files": [
         "src/**/*.{ts,tsx}",
         "test/**/*.{ts,tsx}",
         "tsconfig.json",
-        "tsconfig.all.json"
+        "tsconfig.typecheck.json"
       ],
       "dependencies": [],
       "output": [],

packages/create-spectacle/src/cli.ts

@@ -9,7 +9,8 @@ import {
   writeWebpackProjectFiles,
   writeOnePageHTMLFile
 } from './templates/file-writers';
-import { version as SPECTACLE_VERSION } from 'spectacle/package.json';
+// @ts-ignore
+import { version, devDependencies } from '../package.json';
 
 type CLIOptions = {
   type: 'tsx' | 'jsx' | 'mdx' | 'onepage';
@@ -31,7 +32,7 @@ const main = async () => {
   program
     .name('create-spectacle')
     .description('CLI to bootstrap Spectacle decks')
-    .version('2.0.0')
+    .version(version)
     .showHelpAfterError()
     .configureOutput({
       outputError: (message, write) =>
@@ -71,7 +72,7 @@ const main = async () => {
     lang,
     port,
     enableTypeScriptSupport: type === 'tsx',
-    spectacleVersion: SPECTACLE_VERSION
+    spectacleVersion: devDependencies.spectacle
   };
 
   switch (type) {

packages/create-spectacle/src/templates/package.ts

@@ -14,7 +14,11 @@ export const packageTemplate = (options: PackageTemplateOptions) =>
     "build": "webpack --config ./webpack.config.js --mode production"
   },
   "dependencies": {
-    "spectacle": "^${options.spectacleVersion}",
+    "spectacle": "${
+      options.spectacleVersion === 'workspace:*'
+        ? '*'
+        : `^${options.spectacleVersion}`
+    }",
     "react": "^18.1.0",
     "react-dom": "^18.1.0"
   },

packages/create-spectacle/tsconfig.build.json

@@ -0,0 +1,8 @@
+{
+  "extends": "./tsconfig.json",
+  "include": ["src/**/*"],
+  "compilerOptions": {
+    "outDir": "./bin",
+    "rootDir": "./src"
+  }
+}

packages/create-spectacle/tsconfig.json

@@ -3,7 +3,6 @@
   "compilerOptions": {
     "moduleResolution": "node",
     "module": "commonjs",
-    "outDir": "./bin",
     // https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-14
     "target": "ES2020",
     "esModuleInterop": true,