Skip to content

Commit 294a95f

Browse files
Conrad2134kenwheeler
authored andcommitted
Fix React warnings for uppercase HTML heading elements (#373)
* Minor README spacing fix * Prevent console spam on uppercase heading element
1 parent de511af commit 294a95f

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ export default class extends Component {
272272

273273
Here is where you can use the library's tags to compose your presentation. While you can use any JSX syntax here, building your presentation with the supplied tags allows for theming to work properly.
274274

275-
The bare minimum you need to start is a`Deck` element and a `Slide` element. Each `Slide` element represents a slide inside of your slideshow.
275+
The bare minimum you need to start is a `Deck` element and a `Slide` element. Each `Slide` element represents a slide inside of your slideshow.
276276

277277
<a name="themes"></a>
278278
### Themes

src/components/__snapshots__/heading.test.js.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ exports[`<Heading /> should render correctly. 1`] = `
55
lineHeight={1}
66
size={2}
77
>
8-
<H2
8+
<h2
99
className={undefined}
1010
data-radium={true}
1111
style={
@@ -16,7 +16,7 @@ exports[`<Heading /> should render correctly. 1`] = `
1616
}
1717
>
1818
Hi There!
19-
</H2>
19+
</h2>
2020
</Heading>
2121
`;
2222

src/components/heading.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export default class Heading extends Component {
4141
}
4242
render() {
4343
const { size, lineHeight, fit, style, children } = this.props;
44-
const Tag = `H${size}`;
44+
const Tag = `h${size}`;
4545
const styles = {
4646
container: {
4747
display: 'block',

0 commit comments

Comments
 (0)