Skip to content

Commit bc75994

Browse files
authored
Infra: bandaid version release (#1157)
I filed #1156 to track the issue with `pnpm install --fix-lockfile` and the short answer is: (1) it appears to be some bug, and (2) I don't know how to fix it easily. Fortunately, `pnpm install` alone should generate `pnpm-lock.yaml` changes that we need to re-commit at the end of changeset version, so I've just switched to that. Separately, I've removed all `workspace:` prefixes for cross-project `spectacle` dependencies because (1) they are not needed and (2) the complicate examples / other projects release-wise and confusion-wise because they are PNPM dependent artifacts.
1 parent 8c2c6ad commit bc75994

File tree

8 files changed

+13
-9
lines changed

8 files changed

+13
-9
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ jobs:
4545
id: changesets
4646
uses: changesets/action@v1
4747
with:
48+
# Note: Our `package.json:scripts.version` currently doesn't have `--fix-lockfile` for
49+
# `pnpm install` because of a PNPM bug of some kind.
50+
# https://github.com/FormidableLabs/spectacle/issues/1156
4851
version: pnpm run version
4952
publish: pnpm changeset publish
5053
env:

.npmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
prefer-workspace-packages=true

examples/js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"dependencies": {
1010
"react": "^18.1.0",
1111
"react-dom": "^18.1.0",
12-
"spectacle": "workspace:spectacle@*"
12+
"spectacle": "*"
1313
},
1414
"devDependencies": {
1515
"@babel/core": "^7.17.2",

examples/md/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"build": "webpack --config ./webpack.config.js"
88
},
99
"dependencies": {
10-
"spectacle": "workspace:spectacle@*",
10+
"spectacle": "*",
1111
"react": "^18.1.0",
1212
"react-dom": "^18.1.0"
1313
},

examples/typescript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"build": "webpack --config ./webpack.config.js"
88
},
99
"dependencies": {
10-
"spectacle": "workspace:spectacle@*",
10+
"spectacle": "*",
1111
"react": "^18.1.0",
1212
"react-dom": "^18.1.0"
1313
},

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"build:one-page": "node ./scripts/one-page.js",
2626
"build:cli": "pnpm run --filter spectacle-cli build",
2727
"changeset": "changeset",
28-
"version": "pnpm changeset version && pnpm install --fix-lockfile"
28+
"version": "pnpm changeset version && pnpm install"
2929
},
3030
"devDependencies": {
3131
"@babel/core": "^7.17.2",

packages/cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
},
2828
"peerDependencies": {},
2929
"devDependencies": {
30-
"spectacle": "workspace:spectacle@*",
30+
"spectacle": "*",
3131
"@types/node": "^18.0.3",
3232
"nodemon": "^2.0.18",
3333
"rimraf": "^3.0.2",

pnpm-lock.yaml

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)