ci: organized deployment steps

Author: andreszorro

.github/workflows/e2e.yaml

@@ -9,7 +9,6 @@ on:
         type: boolean
         required: true
         default: true
-        
 jobs:
   e2e:
     name: e2e-${{matrix.name}}
@@ -63,6 +62,10 @@ jobs:
           distribution: 'temurin' # See 'Supported distributions' for available options
           java-version: '21'
       - run: bun install --ignore-scripts
+      - name: Download version to test
+        uses: actions/download-artifact@v4
+        with:
+          name: TESTED_VERSION
       - name: Download created artifacts
         uses: actions/download-artifact@v4
         with:
@@ -107,6 +110,9 @@ jobs:
           } catch {
             Write-Error "An error occurred: $_"
           }
+      - name: Extract version and add it to env variables
+        run: |
+          cat ./TESTED_VERSION.txt >> ${GITHUB_ENV}
       - name: E2E Test (Smoke)
         if: ${{ inputs.smoke && matrix.os != 'windows' }}
         run: |

.github/workflows/release.yaml

@@ -6,15 +6,15 @@ on:
       - 'v*'
 
 jobs:
-  e2e:
-    uses: ./.github/workflows/e2e.yaml
-    with:
-      smoke: false
   test-build:
-    needs: e2e
     uses: ./.github/workflows/test-build.yaml
     permissions:
       contents: write
+  e2e:
+    needs: test-build
+    uses: ./.github/workflows/e2e.yaml
+    with:
+      smoke: false
   release:
     needs: test-build
     runs-on: ubuntu-latest

.github/workflows/test-build.yaml

@@ -7,7 +7,6 @@ on:
     branches:
       - develop
       - main
-
 jobs:
   test:
     name: Unit Tests
@@ -70,8 +69,20 @@ jobs:
           skip_checkout: false
           disable_globbing: true
           create_branch: false
+  output-version:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Output version
+        run: |
+          echo "TESTED_VERSION=$(jq -r '.version' package.json)" > TESTED_VERSION.txt"
+          cat TESTED_VERSION.txt
+      - uses: actions/upload-artifact@v4
+        with:
+          name: TESTED_VERSION
+          path: ./TESTED_VERSION.txt
+          if-no-files-found: error
   build:
-    needs: bump-version
+    needs: output-version
     if: always()
     name: build-${{matrix.name}}
     runs-on: ${{matrix.runs-on}}

.husky/pre-commit

@@ -7,4 +7,6 @@ if [ "$(git config --get custom.hooks.pre-commit)" == "false" ]; then
 fi
 
 bun build:dev
+TESTED_VERSION=$(jq -r '.version' package.json)
+export TESTED_VERSION
 bun lint-staged --relative

e2e/scfz.test.ts

@@ -48,7 +48,8 @@ describe("e2e", () => {
         const proc = spawn(["dist/scfz", "--version"]);
         const text = await new Response(proc.stdout).text();
 
-        expect(text.trim()).toEqual(pkg.version);
+        expect(process.env.TESTED_VERSION).toBeDefined();
+        expect(text.trim()).toEqual(process.env.TESTED_VERSION as string);
     });
 
     test("@smoke: should create a new workspace", async () => {

package.json

@@ -11,7 +11,7 @@
         "build:watch": "bun build:dev --watch",
         "test:dev": "bun test --watch",
         "test": "bun test",
-        "test:ci": "bun test --coverage",
+        "test:ci": "bun test --coverage --test-name-pattern lib",
         "test:e2e:smoke": "bun --config=./e2e/e2e.toml test -t '@smoke' --bail --timeout 30000",
         "test:e2e": "bun --config=./e2e/e2e.toml test --bail --timeout 30000",
         "prepare": "husky"