refactor(eslint): fix unicorn/prefer-string-slice (refs SFKUI-6500)

Author: ext

eslint.config.mjs

@@ -140,7 +140,6 @@ export default [
         name: "technical-debt",
         rules: {
             "unicorn/filename-case": "off",
-            "unicorn/prefer-string-slice": "off",
         },
     },
 ];

packages/logic/src/converters/ClearingnumberConverter/clearingnumberConverter.ts

@@ -26,7 +26,7 @@ export function parseClearingNumber(
 
     // add hyphen between number 4 & 5
     return value.length === 5
-        ? `${value.substring(0, 4)}-${value.substring(4, 5)}`
+        ? `${value.slice(0, 4)}-${value.slice(4, 5)}`
         : value;
 }
 
@@ -37,5 +37,5 @@ export function formatClearingNumberForBackend(
     value: ClearingnumberString,
 ): string | undefined {
     // remove the 5th number
-    return value.substring(0, 4);
+    return value.slice(0, 4);
 }

packages/logic/src/converters/PersonnummerConverter/personnummerConverter.ts

@@ -120,13 +120,13 @@ export function formatPersonnummer(
     }
 
     const currentYear = FDate.now().year;
-    const year = Number(value.substring(0, 4));
+    const year = Number(value.slice(0, 4));
 
     if (currentYear - year >= 100) {
-        return value.substring(2).replace("-", "+");
+        return value.slice(2).replace("-", "+");
     }
 
-    return value.substring(2);
+    return value.slice(2);
 }
 
 /**

packages/logic/src/converters/PersonnummerConverter/resolve-century.ts

@@ -10,9 +10,9 @@ function getNowDetails(now: FDate): NowDetails {
     const nowIso = now.toString();
 
     return {
-        nowCentury: nowIso.substring(0, 2),
-        nowYear: nowIso.substring(2, 4),
-        nowMonthDay: nowIso.substring(5, 7) + nowIso.substring(8, 10),
+        nowCentury: nowIso.slice(0, 2),
+        nowYear: nowIso.slice(2, 4),
+        nowMonthDay: nowIso.slice(5, 7) + nowIso.slice(8, 10),
     };
 }
 

packages/logic/src/converters/PlusgiroConverter/plusgiroConverter.ts

@@ -39,29 +39,26 @@ export function parsePlusgiro(value: string): PlusgiroString | undefined {
 
     if (hyphenShouldBeAdded(value)) {
         /* eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- length is 2+ so -1 will return a character */
-        value = `${value.substring(0, value.length - 1)}-${value.at(-1)!}`;
+        value = `${value.slice(0, -1)}-${value.at(-1)!}`;
     }
 
     const startOffset = 4;
-    let formattedString = value.substring(
-        value.length - startOffset,
-        value.length,
-    );
+    let formattedString = value.slice(-startOffset);
 
     const step = 2;
     for (
         let i = value.length - startOffset;
         i >= (value.length === 9 ? 3 : 1);
         i -= step
     ) {
-        formattedString = `${value.substring(
+        formattedString = `${value.slice(
             Math.max(i - step, 0),
             i,
         )} ${formattedString}`;
     }
 
     if (value.length === 9) {
-        formattedString = value.substring(0, 1) + formattedString;
+        formattedString = value.slice(0, 1) + formattedString;
     }
 
     return formattedString;