refactor(eslint): fix unicorn/prefer-string-replace-all (refs SFKUI-6500)

ext · ext · commit bd2cb344aed5 · 2026-03-09T08:45:26.000+01:00
diff --git a/cypress/assertions/trimmedText.ts b/cypress/assertions/trimmedText.ts
@@ -6,8 +6,8 @@ chai.Assertion.addMethod("trimmedText", function (expectedString) {
 
     const actual = $element
         .text()
-        .replace(/\r/g, " ")
-        .replace(/\s+/g, " ")
+        .replaceAll("\r", " ")
+        .replaceAll(/\s+/g, " ")
         .trim();
     this.assert(
         actual === expectedString,
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -150,7 +150,6 @@ export default [
             "unicorn/prefer-number-properties": "off",
             "unicorn/prefer-query-selector": "off",
             "unicorn/prefer-set-has": "off",
-            "unicorn/prefer-string-replace-all": "off",
             "unicorn/prefer-string-slice": "off",
             "unicorn/prefer-top-level-await": "off",
         },
diff --git a/packages/icon-lib-builder/scripts/build.js b/packages/icon-lib-builder/scripts/build.js
@@ -97,9 +97,9 @@ async function generateSpritesheetJs(library, data) {
     );
     spritesheet = spritesheet
         /* eslint-disable-next-line sonarjs/slow-regex -- technical debt */
-        .replace(/.*eslint-disable.*/g, "")
-        .replace(/PACKAGE/g, JSON.stringify(packageName))
-        .replace(/LIBRARY/g, JSON.stringify(library))
+        .replaceAll(/.*eslint-disable.*/g, "")
+        .replaceAll("PACKAGE", JSON.stringify(packageName))
+        .replaceAll("LIBRARY", JSON.stringify(library))
         .replace(
             /IMPORT_SPRITESHEET\(\);.*/,
             `const spritesheet = '${data.content}';`,
@@ -109,7 +109,7 @@ async function generateSpritesheetJs(library, data) {
         "utf8",
     );
     /* eslint-disable-next-line sonarjs/slow-regex -- technical debt */
-    inject = inject.replace(/.*eslint-disable.*/g, "");
+    inject = inject.replaceAll(/.*eslint-disable.*/g, "");
     const content = [spritesheet, inject].join("\n");
     const indexJs = path.join(dest, library, "index.js");
     const indexDts = path.join(dest, library, "index.d.ts");
@@ -135,9 +135,9 @@ async function generateSpritesheetJsNoInject(library, data) {
     );
     spritesheet = spritesheet
         /* eslint-disable-next-line sonarjs/slow-regex -- technical debt */
-        .replace(/.*eslint-disable.*/g, "")
-        .replace(/PACKAGE/g, JSON.stringify(packageName))
-        .replace(/LIBRARY/g, JSON.stringify(library))
+        .replaceAll(/.*eslint-disable.*/g, "")
+        .replaceAll("PACKAGE", JSON.stringify(packageName))
+        .replaceAll("LIBRARY", JSON.stringify(library))
         .replace(
             /IMPORT_SPRITESHEET\(\);.*/,
             `const spritesheet = '${data.content}';`,
@@ -159,7 +159,7 @@ async function getSpriteSheetdata(directory, files) {
             ".svg",
         )}`;
         const name = path.basename(file, ".svg");
-        const prettyName = capitalize(name.replace(/-/g, " "));
+        const prettyName = capitalize(name.replaceAll("-", " "));
         const svgFile = await fs.readFile(path.join(directory, file), "utf8");
         const optimizedSvg = optimize(svgFile, {
             plugins: [
@@ -179,9 +179,9 @@ async function getSpriteSheetdata(directory, files) {
         });
 
         const symbol = optimizedSvg.data
-            .replace(/<svg/g, `<symbol id="${id}"`)
-            .replace(/<\/svg>/g, "</symbol>")
-            .replace(/ xmlns="[^"]*"/g, "");
+            .replaceAll("<svg", `<symbol id="${id}"`)
+            .replaceAll("</svg>", "</symbol>")
+            .replaceAll(/ xmlns="[^"]*"/g, "");
 
         content += symbol;
         icons.push({
diff --git a/packages/icon-lib-builder/scripts/common.js b/packages/icon-lib-builder/scripts/common.js
@@ -6,7 +6,7 @@ export function capitalize(s) {
 }
 
 export function camelCase(string) {
-    return string.replace(/-([a-z])/gi, function (all, letter) {
+    return string.replaceAll(/-([a-z])/gi, function (all, letter) {
         return letter.toUpperCase();
     });
 }
diff --git a/packages/logic/src/converters/BankAccountNumberConverter/bankAccountNumberConverter.ts b/packages/logic/src/converters/BankAccountNumberConverter/bankAccountNumberConverter.ts
@@ -21,7 +21,7 @@ export function parseBankAccountNumber(
     }
 
     // remove hyphen, blank space, period, comma
-    const trimmedValue = value.replace(BANK_ACCOUNT_NUMBER_TRIM_REGEXP, "");
+    const trimmedValue = value.replaceAll(BANK_ACCOUNT_NUMBER_TRIM_REGEXP, "");
 
     return BANK_ACCOUNT_NUMBER_REGEXP.test(trimmedValue)
         ? trimmedValue
diff --git a/packages/logic/src/converters/PlusgiroConverter/plusgiroConverter.ts b/packages/logic/src/converters/PlusgiroConverter/plusgiroConverter.ts
@@ -27,12 +27,12 @@ export function parsePlusgiro(value: string): PlusgiroString | undefined {
      * If the number of digits is odd then the first pair in the string can be a single digit.
      * If the number of characters is 9, there will be a space after the first 3 characters.
      */
-    value = value.replace(/ /g, "");
-    value = value.replace(/\D/g, "");
+    value = value.replaceAll(" ", "");
+    value = value.replaceAll(/\D/g, "");
 
     if (
         !PLUSGIRO_REGEXP.test(value) ||
-        !testLuhnChecksum(value.replace(/\D/g, ""))
+        !testLuhnChecksum(value.replaceAll(/\D/g, ""))
     ) {
         return undefined;
     }
diff --git a/packages/logic/src/services/TranslationService/DefaultTranslationProvider.ts b/packages/logic/src/services/TranslationService/DefaultTranslationProvider.ts
@@ -41,7 +41,7 @@ export class DefaultTranslationProvider implements TranslationProviderInterface
         defaultValue: string,
         args: Record<string, unknown>,
     ): string {
-        return defaultValue.replace(
+        return defaultValue.replaceAll(
             /* eslint-disable-next-line sonarjs/slow-regex -- technical debt */
             /{{\s*(\S+)\s*}}/g,
             (match, key: string) => {
diff --git a/packages/logic/src/text/strip-whitespace.ts b/packages/logic/src/text/strip-whitespace.ts
@@ -6,5 +6,5 @@
  * @returns Text with whitespace stripped.
  */
 export function stripWhitespace(text: string): string {
-    return text.replace(/\s+/g, "");
+    return text.replaceAll(/\s+/g, "");
 }
diff --git a/packages/logic/src/utils/PersonnummerUtils.ts b/packages/logic/src/utils/PersonnummerUtils.ts
@@ -4,6 +4,6 @@ import { testLuhnChecksum } from "./test-luhn-checksum";
  * @public
  */
 export function validChecksum(value: string): boolean {
-    const yymmddxxxx = value.slice(2).replace(/-/g, "");
+    const yymmddxxxx = value.slice(2).replaceAll("-", "");
     return testLuhnChecksum(yymmddxxxx);
 }
diff --git a/packages/test-utils/src/matchers/to-have-focus.spec.ts b/packages/test-utils/src/matchers/to-have-focus.spec.ts
@@ -17,7 +17,7 @@ expect.addSnapshotSerializer({
     },
     serialize(value: string) {
         /* eslint-disable-next-line no-control-regex -- expected to replace control regex */
-        return value.replace(/\u001B\[[\d;]*m/g, "");
+        return value.replaceAll(/\u001B\[[\d;]*m/g, "");
     },
 });
 
diff --git a/packages/theme-builder/src/build-css.ts b/packages/theme-builder/src/build-css.ts
@@ -109,7 +109,7 @@ export async function buildCss(
 
     /* eslint-disable-next-line @typescript-eslint/await-thenable -- memfs returns a promise instead */
     for await (const item of await fs.glob(pattern, { cwd })) {
-        const src = item.replace(/\\/g, "/");
+        const src = item.replaceAll("\\", "/");
         const { name } = path.parse(src);
         if (name.startsWith("_")) {
             continue;
diff --git a/packages/vue/src/components/FDataTable/FDataTable.vue b/packages/vue/src/components/FDataTable/FDataTable.vue
@@ -186,7 +186,7 @@ function callbackSortableColumns(columnNames: PropertyKey[]): void {
 }
 
 function escapeNewlines(value: string): string {
-    return value.replace(/\n/g, "<br/>");
+    return value.replaceAll("\n", "<br/>");
 }
 </script>
 
diff --git a/packages/vue/src/components/FIcon/examples/FIconAll.vue b/packages/vue/src/components/FIcon/examples/FIconAll.vue
@@ -18,7 +18,7 @@ async function importIcons(): Promise<IconPackage> {
 }
 
 function decamelize(value: string): string {
-    return value.replace(/([A-Z])/g, (_, ch: string) => `-${ch.toLowerCase()}`);
+    return value.replaceAll(/([A-Z])/g, (_, ch: string) => `-${ch.toLowerCase()}`);
 }
 
 const iconsPromise = importIcons();
diff --git a/packages/vue/src/components/FInteractiveTable/FInteractiveTable.vue b/packages/vue/src/components/FInteractiveTable/FInteractiveTable.vue
@@ -569,7 +569,7 @@ function getNextFocus(currentIndex: number): HTMLElement | undefined {
 }
 
 function escapeNewlines(value: string): string {
-    return value.replace(/\n/g, "<br/>");
+    return value.replaceAll("\n", "<br/>");
 }
 
 function updateActiveRowFromVModel(): void {
diff --git a/packages/vue/src/utils/render-slot-text.ts b/packages/vue/src/utils/render-slot-text.ts
@@ -35,7 +35,7 @@ const defaultOptions: RenderSlotOptions = {
  * space
  */
 function collapseWhitespace(text: string): string {
-    return text.replace(/\s+/gm, " ").replace(/(^ | $)/g, "");
+    return text.replaceAll(/\s+/gm, " ").replaceAll(/(^ | $)/g, "");
 }
 
 function intersection<T>(a: T[], b: T[]): T[] {
diff --git a/scripts/find-unused-examples.mjs b/scripts/find-unused-examples.mjs
@@ -32,7 +32,7 @@ function union(a, b) {
 async function findExamples() {
     const filePaths = await glob("{docs,packages}/**/examples/*.vue");
     const entries = filePaths.map((it) => {
-        const filePath = it.replace(/\\/g, "/");
+        const filePath = it.replaceAll("\\", "/");
         const name = path.basename(filePath);
         return { filePath, name };
     });
@@ -64,7 +64,7 @@ async function findDocsImported() {
             let previous;
             do {
                 previous = stripped;
-                stripped = stripped.replace(/<!--[\S\s]*?-->/g, "");
+                stripped = stripped.replaceAll(/<!--[\S\s]*?-->/g, "");
             } while (stripped !== previous);
             const filename = stripped.trim();
             found.add(filename);

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ export function capitalize(s) {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`export function camelCase(string) {`
`9`		`- return string.replace(/-([a-z])/gi, function (all, letter) {`
	`9`	`+ return string.replaceAll(/-([a-z])/gi, function (all, letter) {`
`10`	`10`	`return letter.toUpperCase();`
`11`	`11`	`});`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export function parseBankAccountNumber(`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`// remove hyphen, blank space, period, comma`
`24`		`- const trimmedValue = value.replace(BANK_ACCOUNT_NUMBER_TRIM_REGEXP, "");`
	`24`	`+ const trimmedValue = value.replaceAll(BANK_ACCOUNT_NUMBER_TRIM_REGEXP, "");`
`25`	`25`
`26`	`26`	`return BANK_ACCOUNT_NUMBER_REGEXP.test(trimmedValue)`
`27`	`27`	`? trimmedValue`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,5 @@`
`6`	`6`	`* @returns Text with whitespace stripped.`
`7`	`7`	`*/`
`8`	`8`	`export function stripWhitespace(text: string): string {`
`9`		`- return text.replace(/\s+/g, "");`
	`9`	`+ return text.replaceAll(/\s+/g, "");`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@ import { testLuhnChecksum } from "./test-luhn-checksum";`
`4`	`4`	`* @public`
`5`	`5`	`*/`
`6`	`6`	`export function validChecksum(value: string): boolean {`
`7`		`- const yymmddxxxx = value.slice(2).replace(/-/g, "");`
	`7`	`+ const yymmddxxxx = value.slice(2).replaceAll("-", "");`
`8`	`8`	`return testLuhnChecksum(yymmddxxxx);`
`9`	`9`	`}`