Fix storage.get(..., defaultValue)

Author: mayfield

src/storage/backing/fs.js

@@ -103,12 +103,12 @@ class FSBacking extends StorageInterface {
         }
     }
 
-    async get(ns, key, defaultValue) {
+    async get(ns, key) {
         try {
             return await freadfile(path.join(this.root, ns, key));
         } catch(e) {
             if (e.code === 'ENOENT') {
-                return defaultValue;
+                throw new ReferenceError(key);
             } else {
                 throw e;
             }

src/storage/backing/interface.js

@@ -9,7 +9,8 @@ class StorageInterface {
         throw new Error("Not Implemented");
     }
 
-    async get(ns, key, defaultValue) {
+    async get(ns, key) {
+        /* If key not found should throw ReferenceError */
         throw new Error("Not Implemented");
     }
 

src/storage/backing/redis.js

@@ -65,11 +65,11 @@ class RedisBacking extends StorageInterface {
         await this.client.set(this.label + '-' + ns, key, value);
     }
 
-    async get(ns, key, defaultValue) {
+    async get(ns, key) {
         if (await this.client.exists(this.label + '-' + ns, key)) {
             return await this.client.get(this.label + '-' + ns, key);
         } else {
-            return defaultValue;
+            throw new ReferenceError(key);
         }
     }
 

src/storage/index.js

@@ -52,8 +52,17 @@ function decode(obj) {
     }
 }
 
-exports.get = async (ns, key) => {
-    const data = await _backing.get(ns, key);
+exports.get = async (ns, key, defaultValue) => {
+    let data;
+    try {
+        data = await _backing.get(ns, key);
+    } catch(e) {
+        if (e instanceof ReferenceError) {
+            return defaultValue;
+        } else {
+            throw e;
+        }
+    }
     return data && decode(data);
 };
 exports.set = (ns, key, value) => _backing.set(ns, key, encode(value));