remove unnecessary suppressions / replace with ThrowIfNotOnUIThread

Author: tonyhallett

SharedProject/Options/AppOptions.cs

@@ -175,7 +175,6 @@ You can also ignore additional attributes by adding to this list (short name or
         [Description("Set to true to hide classes, namespaces and assemblies that are fully covered.")]
         public bool HideFullyCovered { get; set; }
 
-        [SuppressMessage("Usage", "VSTHRD010:Invoke single-threaded types on Main thread")]
         public override void SaveSettingsToStorage()
         {
             AppOptionsStorageProvider.SaveSettingsToStorage(this);

SharedProject/Options/AppOptionsProvider.cs

@@ -35,9 +35,9 @@ public IAppOptions Get()
             return options;
         }
 
-        [SuppressMessage("Usage", "VSTHRD010:Invoke single-threaded types on Main thread")]
         private WritableSettingsStore EnsureStore()
         {
+            ThreadHelper.ThrowIfNotOnUIThread();
             var settingsManager = new ShellSettingsManager(ServiceProvider.GlobalProvider);
             var settingsStore = settingsManager.GetWritableSettingsStore(SettingsScope.UserSettings);
 
@@ -53,7 +53,6 @@ private PropertyInfo[] ReflectProperties()
             return AppOptionsType.GetProperties(BindingFlags.DeclaredOnly | BindingFlags.Public | BindingFlags.Instance);
         }
 
-        [SuppressMessage("Usage", "VSTHRD010:Invoke single-threaded types on Main thread")]
         public void LoadSettingsFromStorage(AppOptions instance)
         {
             var settingsStore = EnsureStore();
@@ -85,7 +84,7 @@ public void LoadSettingsFromStorage(AppOptions instance)
                 }
             }
         }
-        [SuppressMessage("Usage", "VSTHRD010:Invoke single-threaded types on Main thread")]
+
         public void SaveSettingsToStorage(AppOptions appOptions)
         {
             var settingsStore = EnsureStore();