intercept user runsettings and disable ms code coverage when all projects associated with runsettings have been disabled

Author: tonyhallett

SharedProject/Core/MsTestPlatform/CodeCoverage/RunSettingsTemplateReplacementsFactory.cs

@@ -146,6 +146,7 @@ public IRunSettingsTemplateReplacements Create(
             var allProjectDetails = testContainers.Select(tc => userRunSettingsProjectDetailsLookup[tc.Source]).ToList();
             var resultsDirectory = allProjectDetails[0].CoverageOutputFolder;
             var allSettings = allProjectDetails.Select(pd => pd.Settings);
+            var allProjectsDisabled = allSettings.All(s => !s.Enabled);
             var mergedSettings = new MergedIncludesExcludesOptions(allSettings);
 
 
@@ -162,7 +163,7 @@ public IRunSettingsTemplateReplacements Create(
 
             var additionalModulePathsInclude = allProjectDetails.SelectMany(projectDetails => projectDetails.IncludedReferencedProjects.Select(rp => MsCodeCoverageRegex.RegexModuleName(rp)));
             var settings = new CombinedIncludesExcludesOptions(mergedSettings, additionalModulePathsInclude, additionalModulePathsExclude);
-            return new RunSettingsTemplateReplacements(settings, resultsDirectory, "true", testAdapter);
+            return new RunSettingsTemplateReplacements(settings, resultsDirectory, (!allProjectsDisabled).ToString(), testAdapter);
         }
 
         public IRunSettingsTemplateReplacements Create(ICoverageProject coverageProject, string testAdapter)

SharedProject/Core/MsTestPlatform/CodeCoverage/UserRunSettingsService.cs

@@ -152,6 +152,7 @@ private IXPathNavigable AddFCCRunSettingsActual(IXPathNavigable inputRunSettingD
                 userRunSettingsProjectDetailsLookup, 
                 fccMsTestAdapterPath
             );
+            
             EnsureTestAdaptersPathsAndReplace(navigator, replacements);
             EnsureCorrectMsDataCollectorAndReplace(clonedNavigator, replacements);
             return navigator;
@@ -212,14 +213,31 @@ private void EnsureCorrectMsDataCollectorAndReplace(XPathNavigator xpathNavigato
                 xpathNavigator.AppendChild(runSettingsTemplate.DataCollectionRunSettingsElement);
             }
 
-            if (addedMsDataCollector)
+            // todo - improve this 
+            var disableMsDataCollector = replacements.Enabled.ToLower() == "false";
+            if (addedMsDataCollector || disableMsDataCollector)
             {
                 xpathNavigator.MoveToRoot();
                 var dataCollectorsNavigator = xpathNavigator.SelectSingleNode("/RunSettings/DataCollectionRunSettings/DataCollectors");
                 var msDataCollectorNavigator = MoveToMsDataCollectorFromDataCollectors(dataCollectorsNavigator);
-                ReplaceExcludesIncludes(msDataCollectorNavigator, replacements);
+
+                if (disableMsDataCollector) 
+                {
+                    DisableMsDataCollector(msDataCollectorNavigator);
+                }
+                else
+                {
+                    ReplaceExcludesIncludes(msDataCollectorNavigator, replacements); // no need to replace if we are disabling
+                }
             }
+        }
 
+
+        private void DisableMsDataCollector(XPathNavigator msDataCollectorNavigator)
+        {
+            var element = XElement.Parse(msDataCollectorNavigator.OuterXml);
+            element.SetAttributeValue("enabled", "false");
+            msDataCollectorNavigator.OuterXml = element.ToString();
         }
 
         private XPathNavigator MoveToMsDataCollectorFromDataCollectors(XPathNavigator navigator)