transitive propagation of UI thread requirements

tonyhallett · tonyhallett · commit 9ef521ded875 · 2022-03-01T14:14:46.000Z
diff --git a/SharedProject/Options/AppOptionsProvider.cs b/SharedProject/Options/AppOptionsProvider.cs
@@ -31,6 +31,7 @@ public void RaiseOptionsChanged(IAppOptions appOptions)
         public IAppOptions Get()
         {
             var options = new AppOptions(true);
+            ThreadHelper.ThrowIfNotOnUIThread();
             LoadSettingsFromStorage(options);
             return options;
         }
@@ -55,6 +56,7 @@ private PropertyInfo[] ReflectProperties()
 
         public void LoadSettingsFromStorage(AppOptions instance)
         {
+            ThreadHelper.ThrowIfNotOnUIThread();
             var settingsStore = EnsureStore();
 
 
@@ -87,6 +89,7 @@ public void LoadSettingsFromStorage(AppOptions instance)
 
         public void SaveSettingsToStorage(AppOptions appOptions)
         {
+            ThreadHelper.ThrowIfNotOnUIThread();
             var settingsStore = EnsureStore();
 
             foreach (var property in ReflectProperties())

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public void RaiseOptionsChanged(IAppOptions appOptions)`
`31`	`31`	`public IAppOptions Get()`
`32`	`32`	`{`
`33`	`33`	`var options = new AppOptions(true);`
	`34`	`+ ThreadHelper.ThrowIfNotOnUIThread();`
`34`	`35`	`LoadSettingsFromStorage(options);`
`35`	`36`	`return options;`
`36`	`37`	`}`
`@@ -55,6 +56,7 @@ private PropertyInfo[] ReflectProperties()`
`55`	`56`
`56`	`57`	`public void LoadSettingsFromStorage(AppOptions instance)`
`57`	`58`	`{`
	`59`	`+ ThreadHelper.ThrowIfNotOnUIThread();`
`58`	`60`	`var settingsStore = EnsureStore();`
`59`	`61`
`60`	`62`
`@@ -87,6 +89,7 @@ public void LoadSettingsFromStorage(AppOptions instance)`
`87`	`89`
`88`	`90`	`public void SaveSettingsToStorage(AppOptions appOptions)`
`89`	`91`	`{`
	`92`	`+ ThreadHelper.ThrowIfNotOnUIThread();`
`90`	`93`	`var settingsStore = EnsureStore();`
`91`	`94`
`92`	`95`	`foreach (var property in ReflectProperties())`