Skip to content

Commit b8e606c

Browse files
committed
rename methods
1 parent a201004 commit b8e606c

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

FineCodeCoverageTests/OpenCoverExeArgumentsProvider_Tests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public void Should_Safely_Include_The_TestDLLFile_In_The_TargetArgs()
6565

6666
var arguments = openCoverExeArgumentsProvider.Provide(mockCoverageProject.Object, "");
6767

68-
AssertHasEscapedSetting(arguments, $"-targetargs:{CommandLineArguments.EscapeQuotes("testDllFile")}");
68+
AssertHasEscapedSetting(arguments, $"-targetargs:{CommandLineArguments.AddEscapeQuotes("testDllFile")}");
6969
}
7070

7171
[Test]
@@ -78,7 +78,7 @@ public void Should_Safely_Include_The_Project_RunSettingsFile_In_The_TargetArgs_
7878

7979
var arguments = openCoverExeArgumentsProvider.Provide(mockCoverageProject.Object, "");
8080

81-
AssertHasEscapedSetting(arguments, $"-targetargs:{CommandLineArguments.EscapeQuotes("testDllFile")} /Settings:{CommandLineArguments.EscapeQuotes("runSettingsFile")}");
81+
AssertHasEscapedSetting(arguments, $"-targetargs:{CommandLineArguments.AddEscapeQuotes("testDllFile")} /Settings:{CommandLineArguments.AddEscapeQuotes("runSettingsFile")}");
8282
}
8383

8484
[Test]
@@ -231,7 +231,7 @@ private void AssertHasSetting(List<string> openCoverSettings, string setting)
231231

232232
private void AssertHasEscapedSetting(List<string> openCoverSettings, string setting)
233233
{
234-
AssertHasSetting(openCoverSettings, CommandLineArguments.EscapeArgument(setting));
234+
AssertHasSetting(openCoverSettings, CommandLineArguments.AddQuotes(setting));
235235
}
236236
}
237237
}

SharedProject/Core/OpenCover/OpenCoverExeArgumentsProvider.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ namespace FineCodeCoverage.Engine.OpenCover
88
{
99
internal static class CommandLineArguments
1010
{
11-
public static string EscapeArgument(string value)
11+
public static string AddQuotes(string value)
1212
{
1313
return $@"""{value}""";
1414
}
1515

16-
public static string EscapeQuotes(string arg)
16+
public static string AddEscapeQuotes(string arg)
1717
{
1818
return $@"\""{arg}\""";
1919
}
@@ -138,18 +138,18 @@ string GetAlternateName(string exclude)
138138

139139
private string GetTargetArgs(ICoverageProject project)
140140
{
141-
var runSettings = !string.IsNullOrWhiteSpace(project.RunSettingsFile) ? $@" /Settings:{CommandLineArguments.EscapeQuotes(project.RunSettingsFile)}" : default;
142-
return $@"""-targetargs:{CommandLineArguments.EscapeQuotes(project.TestDllFile)}{runSettings}""";
141+
var runSettings = !string.IsNullOrWhiteSpace(project.RunSettingsFile) ? $@" /Settings:{CommandLineArguments.AddEscapeQuotes(project.RunSettingsFile)}" : default;
142+
return $@"""-targetargs:{CommandLineArguments.AddEscapeQuotes(project.TestDllFile)}{runSettings}""";
143143
}
144144

145145
public List<string> Provide(ICoverageProject project,string msTestPlatformExePath)
146146
{
147147
var opencoverSettings = new List<string>();
148148

149-
opencoverSettings.Add(CommandLineArguments.EscapeArgument($"-target:{msTestPlatformExePath}"));
149+
opencoverSettings.Add(CommandLineArguments.AddQuotes($"-target:{msTestPlatformExePath}"));
150150
opencoverSettings.Add(GetTargetArgs(project));
151151

152-
opencoverSettings.Add(CommandLineArguments.EscapeArgument($"-output:{project.CoverageOutputFile}"));
152+
opencoverSettings.Add(CommandLineArguments.AddQuotes($"-output:{project.CoverageOutputFile}"));
153153

154154
AddFilter(project, opencoverSettings);
155155
AddExcludeByFile(project, opencoverSettings);

0 commit comments

Comments
 (0)