add ok return for testing

Author: tonyhallett

SharedProject/Core/MsTestPlatform/CodeCoverage/IVsRunSettingsWriter.cs

@@ -1,12 +1,11 @@
-using Microsoft.VisualStudio.Shell.Interop;
-using System;
+using System;
 using System.Threading.Tasks;
 
 namespace FineCodeCoverage.Engine.MsTestPlatform.CodeCoverage
 {
     internal interface IVsRunSettingsWriter
     {
-        Task RemoveRunSettingsFilePathAsync(Guid projectGuid);
+        Task<bool> RemoveRunSettingsFilePathAsync(Guid projectGuid);
         Task<bool> WriteRunSettingsFilePathAsync(Guid projectGuid, string projectRunSettingsFilePath);
     }
 }

SharedProject/Core/MsTestPlatform/CodeCoverage/VsRunSettingsWriter.cs

@@ -41,18 +41,20 @@ public async Task<bool> WriteRunSettingsFilePathAsync(Guid projectGuid, string p
             return success;
         }
 
-        public async Task RemoveRunSettingsFilePathAsync(Guid projectGuid)
+        public async Task<bool> RemoveRunSettingsFilePathAsync(Guid projectGuid)
         {
+            var ok = false;
             await ThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync();
             var vsSolution = serviceProvider.GetService(typeof(SVsSolution)) as IVsSolution;
             Assumes.Present(vsSolution);
             if (vsSolution.GetProjectOfGuid(ref projectGuid, out var vsHierarchy) == VSConstants.S_OK)
             {
                 if (vsHierarchy is IVsBuildPropertyStorage vsBuildPropertyStorage)
                 {
-                    vsBuildPropertyStorage.RemoveProperty(projectRunSettingsFilePathElementName, null, 1);
+                    ok = vsBuildPropertyStorage.RemoveProperty(projectRunSettingsFilePathElementName, null, 1) == VSConstants.S_OK;
                 }
             }
+            return ok;
         }
 
     }