Fix bugs (bcgov#2547)

Author: Fosol

api/net/Areas/Subscriber/Controllers/ContentController.cs

@@ -202,7 +202,7 @@ public async Task<IActionResult> DownloadFileAsync(long id)
     [SwaggerOperation(Tags = new[] { "Content" })]
     public IActionResult AnonymousDownloadFile(string path)
     {
-        var ext = Path.GetExtension(path).Substring(1);
+        var ext = Path.GetExtension(path).TrimStart('.');
         if (!_storageOptions.AllowAnonymousDownloadFileTypes.Any(value => String.Equals(value, ext, StringComparison.OrdinalIgnoreCase))) throw new InvalidOperationException("Unable to download file.");
 
         path = String.IsNullOrWhiteSpace(path) ? "" : HttpUtility.UrlDecode(path).MakeRelativePath();

libs/net/template/ReportEngine.cs

@@ -1,6 +1,7 @@
 
 using System.Globalization;
 using System.IO.Compression;
+using System.Net;
 using System.Text;
 using System.Text.Json;
 using System.Text.Json.Nodes;
@@ -532,8 +533,10 @@ await report.Sections
 
                             await File.WriteAllBytesAsync(fullPath, imageBytes);
 
+                            var urlPathToImage = WebUtility.UrlEncode(pathToImage);
+
                             // Update the section to include the new image.
-                            sectionData.Settings.UrlCache = this.TemplateOptions.SubscriberAppUrl?.Append($"api/subscriber/contents/download?path={pathToImage}").AbsoluteUri;
+                            sectionData.Settings.UrlCache = this.TemplateOptions.SubscriberAppUrl?.Append($"api/subscriber/contents/download?path={urlPathToImage}").AbsoluteUri;
                         }
                     }
                     else

openshift/scripts/deploy.sh

@@ -48,7 +48,7 @@ podsExtractQuotes=$(getPods extract-quotes-service deployment $env)
 podsFolderCollection=$(getPods folder-collection-service deployment $env)
 podsContent=$(getPods content-service deployment $env)
 podsIndexing=$(getPods indexing-service deployment $env)
-if [ "$env" != "dev "]; then
+if [[ "$env" != "dev " ]]; then
   podsIndexingCloud=$(getPods indexing-service-cloud deployment $env)
 fi
 podsEventHandler=$(getPods event-handler-service deployment $env)
@@ -139,7 +139,7 @@ scale extract-quotes-service $podsExtractQuotes deployment $env
 scale folder-collection-service $podsFolderCollection deployment $env
 scale content-service $podsContent deployment $env
 scale indexing-service $podsIndexing deployment $env
-if [ "$env" != "dev" ]; then
+if [[ "$env" != "dev" ]]; then
   scale indexing-service-cloud $podsIndexingCloud deployment $env
 fi
 scale event-handler-service $podsEventHandler deployment $env