Skip to content

Calculator issue#160 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
naveensingh merged 7 commits into from
Nov 7, 2025
Merged

Calculator issue#160 #178

naveensingh merged 7 commits into from
Nov 7, 2025

Conversation

@aricodeine
Copy link
Contributor

@aricodeine aricodeine commented Nov 4, 2025 •
edited by fossifybot bot
Loading

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Fixed the erroneous behaviour that occurs when doing consecutive percent calculations

Tests performed

  • Emulator API 36.0

After Preview:
ignoreImageMinify

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@naveensingh naveensingh added testers needed We need testers for this issue or pull request and removed testers needed We need testers for this issue or pull request labels Nov 4, 2025
@aricodeine
Copy link
Contributor Author

aricodeine commented Nov 4, 2025 •
edited
Loading

Will push a few more changes, it seems the issue is not fixed completely

@aricodeine aricodeine closed this Nov 4, 2025
@aricodeine aricodeine reopened this Nov 5, 2025
@aricodeine
Copy link
Contributor Author

aricodeine commented Nov 5, 2025

Hi @naveensingh , now #160 should be fixed. Please review.

@naveensingh naveensingh added testers needed We need testers for this issue or pull request and removed testers needed We need testers for this issue or pull request labels Nov 5, 2025
naveensingh
naveensingh requested changes Nov 5, 2025
View reviewed changes
Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I skip step 2 from the bug report, I still get "0*" as the result. That should not happen.

@aricodeine
Copy link
Contributor Author

aricodeine commented Nov 6, 2025

When I skip step 2 from the bug report, I still get "0*" as the result. That should not happen.

@naveensingh I have updated code. It's fixed.

@naveensingh naveensingh added testers needed We need testers for this issue or pull request and removed testers needed We need testers for this issue or pull request labels Nov 6, 2025
naveensingh
naveensingh approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@naveensingh naveensingh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this briefly, and it seems to work. I hope you have tested this thoroughly :)

@naveensingh naveensingh merged commit 4cb9b8d into FossifyOrg:main Nov 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naveensingh naveensingh naveensingh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Strange behavior with consecutive percentage calculations.

2 participants

@aricodeine @naveensingh