App doesn't follow locale number formatting #64
Description
Checklist
- I can reproduce the bug with the latest version given here.
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- This issue contains only one bug.
- I have read and understood the contribution guidelines.
Affected app version
1.0.3
Affected Android/Custom ROM version
Android 14
Affected device model
OnePlus 9 Pro
How did you install the app?
GitHub releases
Steps to reproduce the bug
- Have phone locale set to any country that doesn't use a dot as a decimal separator and doesn't use a dot as a thousand grouping symbol, e.g. Poland.
- Write any long number or do a calculation that produces a number higher than 999.
Expected behavior
For Polish locale, after writing 123456789 I would expect to see 123 456 789.
(source: https://www.localeplanet.com/icu/pl/index.html)
Actual behavior
I either see 123.456.789 or 123,456,789 depending on the Use comma as a decimal mark option. For me, it's misleading, because I automatically assume that any symbol is a decimal separator.
Screenshots/Screen recordings
No response
Additional information
In my opinion, we should remove Use comma as a decimal mark option and just respect OS locale settings. Depending on a country, there are various ways to format numbers, and we can't assume that thousands are always grouped by commas, dots or spaces. Sometimes grouping isn't even done by thousands.
Reference: https://en.wikipedia.org/wiki/Decimal_separator#Digit_grouping