add autocomplete for location #820
Open
+40
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Friendly-Banana, could you resolve the conflicts here and in #817? |
Friendly-Banana
force-pushed
the
autocomplete-location
branch
from
11ff262 to
f3fe3f0
Compare
Author
|
looking into it |
Author
|
rebased and tested |
naveensingh
requested changes
Dec 31, 2025
| @Query("SELECT * FROM events WHERE type = $TYPE_TASK") | ||
| fun getAllTasks(): List<Event> | ||
|
|
||
| @Query("SELECT DISTINCT location FROM events") |
Member
There was a problem hiding this comment.
Maybe sort them first?
Suggested change
| @Query("SELECT DISTINCT location FROM events") | |
| @Query("SELECT DISTINCT location FROM events ORDER BY location COLLATE NOCASE") |
| android:textSize="@dimen/day_text_size" /> | ||
|
|
||
| <org.fossify.commons.views.MyEditText | ||
| <AutoCompleteTextView |
Member
There was a problem hiding this comment.
We should use the Fossify implementation so proper colors are used in all themes.
Suggested change
| <AutoCompleteTextView | |
| <org.fossify.commons.views.MyAutoCompleteTextView |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Tests performed
Before & after preview
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).I had to make
item_dropdown.xmlbecause in light mode the suggestions were gray on white and unreadable.