fix: address various uncaught exceptions (#248)

* fix: address NPE in setupAlarms

* fix: address IllegalStateException in TimerFragment

* style: add missing empty line

* fix: address IndexOutOfBoundsException in MyTextClock

* docs: update changelog

Author: naveensingh

CHANGELOG.md

@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- Fixed crash on startup ([#247])
+
 ## [1.3.0] - 2025-07-13
 ### Changed
 - Updated translations
@@ -78,6 +81,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 [#158]: https://github.com/FossifyOrg/Clock/issues/158
 [#206]: https://github.com/FossifyOrg/Clock/issues/206
 [#207]: https://github.com/FossifyOrg/Clock/issues/207
+[#247]: https://github.com/FossifyOrg/Clock/issues/247
 
 [Unreleased]: https://github.com/FossifyOrg/Clock/compare/1.3.0...HEAD
 [1.3.0]: https://github.com/FossifyOrg/Clock/compare/1.2.2...1.3.0

app/src/main/kotlin/org/fossify/clock/fragments/AlarmFragment.kt

@@ -140,10 +140,11 @@ class AlarmFragment : Fragment(), ToggleAlarmInterface {
     private fun setupAlarms() {
         getSortedAlarms { sortedAlarms ->
             alarms = sortedAlarms
+            val safeActivity = activity as? SimpleActivity ?: return@getSortedAlarms
             var currAdapter = binding.alarmsList.adapter as? AlarmsAdapter
             if (currAdapter == null) {
                 currAdapter = AlarmsAdapter(
-                    activity = activity as SimpleActivity,
+                    activity = safeActivity,
                     alarms = alarms,
                     toggleAlarmInterface = this,
                     recyclerView = binding.alarmsList
@@ -154,12 +155,9 @@ class AlarmFragment : Fragment(), ToggleAlarmInterface {
                 }
             } else {
                 currAdapter.apply {
-                    val context = context
                     updatePrimaryColor()
-                    if (context != null) {
-                        updateBackgroundColor(context.getProperBackgroundColor())
-                        updateTextColor(context.getProperTextColor())
-                    }
+                    updateBackgroundColor(safeActivity.getProperBackgroundColor())
+                    updateTextColor(safeActivity.getProperTextColor())
                     updateItems(alarms)
                 }
             }

app/src/main/kotlin/org/fossify/clock/fragments/TimerFragment.kt

@@ -112,7 +112,8 @@ class TimerFragment : Fragment() {
 
     private fun getSortedTimers(callback: (List<Timer>) -> Unit) {
         activity?.timerHelper?.getTimers { timers ->
-            val sortedTimers = when (requireContext().config.timerSort) {
+            val safeContext = context ?: return@getTimers
+            val sortedTimers = when (safeContext.config.timerSort) {
                 SORT_BY_TIMER_DURATION -> timers.sortedBy { it.seconds }
                 SORT_BY_DATE_CREATED -> timers.sortedBy { it.id }
                 SORT_BY_CUSTOM -> {

app/src/main/kotlin/org/fossify/clock/views/MyTextClock.kt

@@ -38,27 +38,36 @@ class MyTextClock @JvmOverloads constructor(
         }
 
         val full = text.toString()
-        var index = -1
+        var amPmPosition = -1
         var amPmString: String? = null
         for (s in amPmStrings) {
             if (s.isNotEmpty()) {
                 val i = full.indexOf(s, ignoreCase = true)
                 if (i != -1) {
-                    index = i
+                    amPmPosition = i
                     amPmString = s
                     break
                 }
             }
         }
 
-        if (index != -1 && amPmString != null) {
+        if (amPmPosition != -1 && amPmString != null) {
             val spannable = SpannableString(text)
-            spannable.setSpan(
-                RelativeSizeSpan(AM_PM_SCALE),
-                index - 1, // including the space before AM/PM
-                index + amPmString.length,
-                Spanned.SPAN_EXCLUSIVE_EXCLUSIVE
-            )
+            val startIndex = if (amPmPosition > 0 && full[amPmPosition - 1].isWhitespace()) {
+                amPmPosition - 1
+            } else {
+                amPmPosition
+            }
+            val endIndex = amPmPosition + amPmString.length
+            if (startIndex < endIndex) {
+                spannable.setSpan(
+                    RelativeSizeSpan(AM_PM_SCALE),
+                    startIndex,
+                    endIndex,
+                    Spanned.SPAN_EXCLUSIVE_EXCLUSIVE
+                )
+            }
+
             reenter = true
 
             try {
@@ -70,4 +79,4 @@ class MyTextClock @JvmOverloads constructor(
             super.setText(text, type)
         }
     }
-}
+}