Skip to content

Commit c5b18e3

Browse files
committed
refactor: update edge-to-edge implementation
1 parent a6d2447 commit c5b18e3

File tree

6 files changed

+35
-30
lines changed

6 files changed

+35
-30
lines changed

app/src/main/kotlin/org/fossify/clock/activities/AlarmActivity.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ class AlarmActivity : SimpleActivity() {
5656
setContentView(binding.root)
5757
showOverLockscreen()
5858
updateTextColors(binding.root)
59-
updateStatusbarColor(getProperBackgroundColor())
6059

6160
val id = intent.getIntExtra(ALARM_ID, -1)
6261
alarm = dbHelper.getAlarmWithId(id)

app/src/main/kotlin/org/fossify/clock/activities/MainActivity.kt

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,7 @@ class MainActivity : SimpleActivity() {
7171
setupOptionsMenu()
7272
refreshMenuItems()
7373

74-
updateEdgeToEdge(
75-
topAppBar = binding.mainToolbar,
76-
scrollingView = binding.viewPager,
77-
bottomBar = binding.mainTabsHolder
78-
)
74+
setupEdgeToEdge(padBottomImeAndSystem = listOf(binding.mainTabsHolder))
7975

8076
storeStateVariables()
8177
initFragments()
@@ -99,7 +95,7 @@ class MainActivity : SimpleActivity() {
9995

10096
override fun onResume() {
10197
super.onResume()
102-
setupTopAppBar(binding.mainToolbar, statusBarColor = getProperBackgroundColor())
98+
setupTopAppBar(binding.mainAppbar, topBarColor = getProperBackgroundColor())
10399
val configTextColor = getProperTextColor()
104100
if (storedTextColor != configTextColor) {
105101
getInactiveTabIndexes(binding.viewPager.currentItem).forEach {
@@ -332,7 +328,6 @@ class MainActivity : SimpleActivity() {
332328
binding.mainTabsHolder.getTabAt(binding.viewPager.currentItem)?.select()
333329
val bottomBarColor = getBottomNavigationBackgroundColor()
334330
binding.mainTabsHolder.setBackgroundColor(bottomBarColor)
335-
updateNavigationBarColor(bottomBarColor)
336331
}
337332

338333
private fun getInactiveTabIndexes(activeIndex: Int): List<Int> {

app/src/main/kotlin/org/fossify/clock/activities/SettingsActivity.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,13 @@ class SettingsActivity : SimpleActivity() {
7272
super.onCreate(savedInstanceState)
7373
setContentView(binding.root)
7474

75-
updateEdgeToEdge(
76-
topAppBar = binding.settingsToolbar,
77-
scrollingView = binding.settingsNestedScrollview,
78-
)
79-
setupMaterialScrollListener(binding.settingsNestedScrollview, binding.settingsToolbar)
75+
setupEdgeToEdge(padBottomSystem = listOf(binding.settingsNestedScrollview))
76+
setupMaterialScrollListener(binding.settingsNestedScrollview, binding.settingsAppbar)
8077
}
8178

8279
override fun onResume() {
8380
super.onResume()
84-
setupTopAppBar(binding.settingsToolbar, NavigationIcon.Arrow)
81+
setupTopAppBar(binding.settingsAppbar, NavigationIcon.Arrow)
8582

8683
setupCustomizeColors()
8784
setupUseEnglish()

app/src/main/res/layout/activity_main.xml

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,26 @@
55
android:layout_width="match_parent"
66
android:layout_height="match_parent">
77

8-
<com.google.android.material.appbar.MaterialToolbar
9-
android:id="@+id/main_toolbar"
8+
<org.fossify.commons.views.MyAppBarLayout
9+
android:id="@+id/main_appbar"
1010
android:layout_width="match_parent"
11-
android:layout_height="?attr/actionBarSize"
12-
android:background="@color/color_primary"
13-
app:menu="@menu/menu"
14-
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
11+
android:layout_height="wrap_content">
12+
13+
<com.google.android.material.appbar.MaterialToolbar
14+
android:id="@+id/main_toolbar"
15+
android:layout_width="match_parent"
16+
android:layout_height="?attr/actionBarSize"
17+
android:background="@color/color_primary"
18+
app:menu="@menu/menu"
19+
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
20+
21+
</org.fossify.commons.views.MyAppBarLayout>
1522

1623
<RelativeLayout
1724
android:id="@+id/main_holder"
1825
android:layout_width="match_parent"
1926
android:layout_height="match_parent"
20-
android:layout_marginTop="?attr/actionBarSize">
27+
app:layout_behavior="@string/appbar_scrolling_view_behavior">
2128

2229
<com.duolingo.open.rtlviewpager.RtlViewPager
2330
android:id="@+id/view_pager"

app/src/main/res/layout/activity_settings.xml

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,28 @@
66
android:layout_width="match_parent"
77
android:layout_height="match_parent">
88

9-
<com.google.android.material.appbar.MaterialToolbar
10-
android:id="@+id/settings_toolbar"
9+
<org.fossify.commons.views.MyAppBarLayout
10+
android:id="@+id/settings_appbar"
1111
android:layout_width="match_parent"
12-
android:layout_height="?attr/actionBarSize"
13-
android:background="@color/color_primary"
14-
app:title="@string/settings"
15-
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
12+
android:layout_height="wrap_content">
13+
14+
<com.google.android.material.appbar.MaterialToolbar
15+
android:id="@+id/settings_toolbar"
16+
android:layout_width="match_parent"
17+
android:layout_height="?attr/actionBarSize"
18+
android:background="@color/color_primary"
19+
app:title="@string/settings"
20+
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
21+
22+
</org.fossify.commons.views.MyAppBarLayout>
1623

1724
<androidx.core.widget.NestedScrollView
1825
android:id="@+id/settings_nested_scrollview"
1926
android:layout_width="match_parent"
2027
android:layout_height="wrap_content"
21-
android:layout_marginTop="?attr/actionBarSize"
2228
android:fillViewport="true"
23-
android:scrollbars="none">
29+
android:scrollbars="none"
30+
app:layout_behavior="@string/appbar_scrolling_view_behavior">
2431

2532
<LinearLayout
2633
android:id="@+id/settings_holder"

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ numberpicker = "2.4.13"
2222
#Room
2323
room = "2.8.2"
2424
#Fossify
25-
commons = "5.4.0"
25+
commons = "6.0.0"
2626
#Gradle
2727
gradlePlugins-agp = "8.11.1"
2828
#build

0 commit comments

Comments
 (0)