Skip to content

Better support for 24 and 12 hour time formats (#52)#62

Merged
naveensingh merged 5 commits intoFossifyOrg:masterfrom
Aga-C:better-support-24-12-hr-forrmats
Feb 8, 2025
Merged

Better support for 24 and 12 hour time formats (#52)#62
naveensingh merged 5 commits intoFossifyOrg:masterfrom
Aga-C:better-support-24-12-hr-forrmats

Conversation

@Aga-C
Copy link
Contributor

@Aga-C Aga-C commented Apr 6, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added zero padding for hour in 24-hour digital clock (both app and widget), because it's a standard formatting.
  • Added AM/PM indicator in 12-hour digital clock widget.
  • Added switch between 12 and 24-hour time formats.
    • Original issue was mentioning this kind of switch, and since it's already in Calendar, it could be also done here.
    • By default, it uses system time format.
    • It works for all clocks in the app and for digital clock widget.

Before/After Screenshots/Screen Record

qemu-system-x86_64_VDfOYWNe9E.mp4

Fixes the following issue(s)

Acknowledgement

@frobby
Copy link

frobby commented Sep 1, 2024

May I suggest adding a setting for a custom date/time format?
Using format codes such as these
Screenshot2
eg: I would like to change the date format to: "Mon 02 Sep" instead of "Mon, 2 Sept"

@Joshix-1
Copy link
Contributor

The switch between the formats should imho have 3 states: system default, 12h format and 24h format

@naveensingh
Copy link
Member

Thanks :)

@naveensingh naveensingh merged commit 208b2e3 into FossifyOrg:master Feb 8, 2025
2 of 4 checks passed
@Aga-C Aga-C deleted the better-support-24-12-hr-forrmats branch February 8, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When displaying 24 hour time, digits should be padded

4 participants