FEAT: added Sorting dialog to the timer tab#67
FEAT: added Sorting dialog to the timer tab#67naveensingh merged 10 commits intoFossifyOrg:masterfrom
Conversation
|
Compare your solution to what's already in Alarms, because it behaves a bit differently:
|
|
My PR did not add those, they were already there, I just added sorting. |
|
But there was no sorting before, so no one could see this behavior. I know you've just added sorting, but while adding a new feature, we should make sure that it behaves the same as in other places. |
Should I add animation to the alarms or remove it from the timers? |
|
Don't add animation and remove it from Timers. We don't have animations while sorting in other apps. |
|
@Aga-C I managed to remove the animation, but the auto scrolling I haven't figured out yet, I will try again later, but though I will say it here and maybe someone can share a tip or an idea. |
|
I move to MyRecyclerViewAdapter for the TimerAdapter to be consistent with the AlarmsAdapter, no visual changes, but now we have no animations and the list does not scroll to the bottom. |
7962523 to
8da7ee9
Compare
Reverting because animations will be added everywhere. I'll fix the scrolling issue and 'add' the animation in alarms. |
…consistency" This reverts commit c3dda5f. Originally done to address FossifyOrg#67 (comment), reverted for FossifyOrg#67 (comment)
It requires more polishing and animations need to be added in other lists before it can be enabled.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Acknowledgement