chore(l10n): remove duplicate contact click strings (#479)

* chore(l10n): remove duplicate contact click strings

These are now present in the commons lib.

* fix: use fully qualified resource name

Author: naveensingh

app/src/main/kotlin/org/fossify/contacts/activities/SettingsActivity.kt

@@ -217,9 +217,9 @@ class SettingsActivity : SimpleActivity() {
         binding.settingsOnContactClick.text = getOnContactClickText()
         binding.settingsOnContactClickHolder.setOnClickListener {
             val items = arrayListOf(
-                RadioItem(ON_CLICK_CALL_CONTACT, getString(R.string.call_contact)),
-                RadioItem(ON_CLICK_VIEW_CONTACT, getString(R.string.view_contact)),
-                RadioItem(ON_CLICK_EDIT_CONTACT, getString(R.string.edit_contact))
+                RadioItem(ON_CLICK_CALL_CONTACT, getString(org.fossify.commons.R.string.call_contact)),
+                RadioItem(ON_CLICK_VIEW_CONTACT, getString(org.fossify.commons.R.string.view_contact)),
+                RadioItem(ON_CLICK_EDIT_CONTACT, getString(org.fossify.commons.R.string.edit_contact))
             )
 
             RadioGroupDialog(this@SettingsActivity, items, config.onContactClick) {
@@ -231,9 +231,9 @@ class SettingsActivity : SimpleActivity() {
 
     private fun getOnContactClickText() = getString(
         when (config.onContactClick) {
-            ON_CLICK_CALL_CONTACT -> R.string.call_contact
-            ON_CLICK_VIEW_CONTACT -> R.string.view_contact
-            else -> R.string.edit_contact
+            ON_CLICK_CALL_CONTACT -> org.fossify.commons.R.string.call_contact
+            ON_CLICK_VIEW_CONTACT -> org.fossify.commons.R.string.view_contact
+            else -> org.fossify.commons.R.string.edit_contact
         }
     )
 

app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt

@@ -237,7 +237,7 @@ class ViewContactActivity : ContactActivity() {
         binding.contactSendEmail.setOnClickListener { trySendEmail() }
 
         binding.contactSendSms.setOnLongClickListener { toast(org.fossify.commons.R.string.send_sms); true; }
-        binding.contactStartCall.setOnLongClickListener { toast(R.string.call_contact); true; }
+        binding.contactStartCall.setOnLongClickListener { toast(org.fossify.commons.R.string.call_contact); true; }
         binding.contactSendEmail.setOnLongClickListener { toast(org.fossify.commons.R.string.send_email); true; }
 
         updateTextColors(binding.contactScrollview)

app/src/main/res/values-ar/strings.xml

@@ -17,7 +17,6 @@
     <string name="no_contacts_with_emails">لا توجد جهات اتصال بهذا البريد الإلكتروني</string>
     <string name="no_contacts_with_phone_numbers">لا توجد جهات اتصال بهذا الرقم</string>
     <string name="new_contact">جهة اتصال جديدة</string>
-    <string name="edit_contact">تعديل جهة اتصالل</string>
     <string name="select_contact">اختيار جهة اتصال</string>
     <string name="nickname">اللقب</string>
     <string name="no_groups">لا توجد مجموعات</string>
@@ -34,9 +33,6 @@
     <string name="show_phone_numbers">إظهار أرقام الهواتف</string>
     <string name="show_contact_thumbnails">عرض صور مصغرة لجهات الإتصال</string>
     <string name="show_dialpad_button">عرض زر لوحة الإتصال على الشاشةالرئيسية</string>
-    <string name="on_contact_click">عند النقر فوق جهة اتصال</string>
-    <string name="call_contact">اتصال بجهة</string>
-    <string name="view_contact">عرض تفاصيل جهة الاتصال</string>
     <string name="manage_shown_contact_fields">إدارة حقول جهات الاتصال المعروضة</string>
     <string name="contacts">جهات الاتصال</string>
     <string name="show_only_contacts_with_numbers">إظهار جهات الاتصال التي لديها أرقام هواتف فقط</string>

app/src/main/res/values-az/strings.xml

@@ -14,7 +14,6 @@
     <string name="send_email_to_group">Grupa e-poçt göndər</string>
     <string name="must_be_at_edit">Kontaktı dəyişmək üçün İdarə et ekranında olmalısınız</string>
     <string name="new_contact">Yeni kontakt</string>
-    <string name="edit_contact">Redaktə et</string>
     <string name="select_contact">Kontakt seç</string>
     <string name="no_groups">Qruplar yoxdur</string>
     <string name="create_new_group">Yeni qrup yarat</string>
@@ -28,9 +27,6 @@
     <string name="remove_photo">Şəkli sil</string>
     <string name="show_phone_numbers">Telefon nömrələrini əsas ekranda göstər</string>
     <string name="show_contact_thumbnails">Kontakt görüntülərini göstər</string>
-    <string name="on_contact_click">Kontakta toxunduqda</string>
-    <string name="call_contact">Kontakta zəng et</string>
-    <string name="view_contact">Kontakt detallarına bax</string>
     <string name="manage_shown_contact_fields">Göstərilən kontakt sahəsini idarə et</string>
     <string name="contacts">Kontaktlar</string>
     <string name="no_favorites">Görünür, hələlik heçbir sevimli kontakt əlavə etməmisiniz.</string>

app/src/main/res/values-be/strings.xml

@@ -17,7 +17,6 @@
     <string name="no_contacts_with_emails">Кантакты з адрасамі электроннай пошты не знойдзены</string>
     <string name="no_contacts_with_phone_numbers">Кантакты з нумарамі тэлефонаў не знойдзены</string>
     <string name="new_contact">Стварыць кантакт</string>
-    <string name="edit_contact">Рэдагаваць кантакт</string>
     <string name="select_contact">Выбраць кантакт</string>
     <string name="nickname">Мянушка</string>
     <string name="no_groups">Няма груп</string>
@@ -34,9 +33,6 @@
     <string name="show_phone_numbers">Паказваць нумары тэлефонаў</string>
     <string name="show_contact_thumbnails">Паказваць фота кантакту</string>
     <string name="show_dialpad_button">Паказваць панэль набору нумароў на галоўным экране</string>
-    <string name="on_contact_click">Пры націсканні на кантакт</string>
-    <string name="call_contact">Тэлефанаваць кантакту</string>
-    <string name="view_contact">Паказваць звесткі аб кантакце</string>
     <string name="manage_shown_contact_fields">Кіраванне палямі кантактаў, якія адлюстроўваюцца</string>
     <string name="contacts">Кантакты</string>
     <string name="show_only_contacts_with_numbers">Паказваць толькі кантакты з нумарамі тэлефонаў</string>

app/src/main/res/values-bg/strings.xml

@@ -17,7 +17,6 @@
     <string name="no_contacts_with_emails">Не са открити контакти с адрес на електронна поща</string>
     <string name="no_contacts_with_phone_numbers">Не са открити контакти с телефонен номер</string>
     <string name="new_contact">Нов контакт</string>
-    <string name="edit_contact">Променяне на контакт</string>
     <string name="select_contact">Избиране на контакт</string>
     <string name="nickname">Прякор</string>
     <string name="no_groups">Няма групи</string>
@@ -34,9 +33,6 @@
     <string name="show_phone_numbers">Показване на телефонните номера</string>
     <string name="show_contact_thumbnails">Показване на миниатюра на контакта</string>
     <string name="show_dialpad_button">Показване на бутон за набиране на главния екран</string>
-    <string name="on_contact_click">При докосване на контакти</string>
-    <string name="call_contact">Обаждане на контакта</string>
-    <string name="view_contact">Преглед на контакта</string>
     <string name="manage_shown_contact_fields">Управление на полетата</string>
     <string name="contacts">Контакти</string>
     <string name="show_only_contacts_with_numbers">Показване само на контактите с телефонен номер</string>

app/src/main/res/values-ca/strings.xml

@@ -17,7 +17,6 @@
     <string name="no_contacts_with_emails">No s\'ha trobat cap contacte amb correu electrònic</string>
     <string name="no_contacts_with_phone_numbers">No s\'ha trobat cap contacte amb número de telèfon</string>
     <string name="new_contact">Contacte nou</string>
-    <string name="edit_contact">Edita el contacte</string>
     <string name="select_contact">Selecciona el contacte</string>
     <string name="nickname">Sobrenom</string>
     <string name="no_groups">No hi ha cap grup</string>
@@ -34,9 +33,6 @@
     <string name="show_phone_numbers">Mostra els números de telèfon</string>
     <string name="show_contact_thumbnails">Mostra les miniatures dels contactes</string>
     <string name="show_dialpad_button">Mostra un botó de teclat de marcatge a la pantalla principal</string>
-    <string name="on_contact_click">En fer clic al contacte</string>
-    <string name="call_contact">Truca al contacte</string>
-    <string name="view_contact">Mostra les dades del contacte</string>
     <string name="manage_shown_contact_fields">Gestiona els camps mostrats de contacte</string>
     <string name="contacts">Contactes</string>
     <string name="show_only_contacts_with_numbers">Mostra només els contactes amb números de telèfon</string>

app/src/main/res/values-cs/strings.xml

@@ -17,7 +17,6 @@
     <string name="no_contacts_with_emails">Nenalezeny žádné kontakty s e-maily</string>
     <string name="no_contacts_with_phone_numbers">Nenalezeny žádné kontakty s telefonními čísly</string>
     <string name="new_contact">Nový kontakt</string>
-    <string name="edit_contact">Upravit kontakt</string>
     <string name="select_contact">Zvolte kontakt</string>
     <string name="nickname">Přezdívka</string>
     <string name="no_groups">Žádné skupiny</string>
@@ -34,9 +33,6 @@
     <string name="show_phone_numbers">Zobrazit telefonní čísla</string>
     <string name="show_contact_thumbnails">Zobrazit obrázky kontaktů</string>
     <string name="show_dialpad_button">Zobrazit tlačítko číselníku na hlavní obrazovce</string>
-    <string name="on_contact_click">Po klepnutí na kontakt</string>
-    <string name="call_contact">Zavolat kontakt</string>
-    <string name="view_contact">Zobrazit údaje kontaktu</string>
     <string name="manage_shown_contact_fields">Spravovat zobrazená pole kontaktů</string>
     <string name="contacts">Kontakty</string>
     <string name="show_only_contacts_with_numbers">Zobrazit jen kontakty s telefonními čísly</string>

app/src/main/res/values-cy/strings.xml

@@ -16,7 +16,6 @@
     <string name="no_contacts_with_emails">Ni chanfuwyd unrhyw gysylltiadau gydag ebost</string>
     <string name="no_contacts_with_phone_numbers">Ni chanfuwyd unrhyw gysylltiadau gyda rhifau ffôn</string>
     <string name="new_contact">Cyswllt newydd</string>
-    <string name="edit_contact">Golygu\'r cyswllt</string>
     <string name="select_contact">Dewis cyswllt</string>
     <string name="nickname">Llys enw</string>
     <string name="no_groups">Dim grwpiau</string>
@@ -32,9 +31,6 @@
     <string name="show_phone_numbers">Dangos rhifau ffôn ar y brif sgrin</string>
     <string name="show_contact_thumbnails">Dangos mân luniau cysylltiadau</string>
     <string name="show_dialpad_button">Dangos botwm pad deialu ar y brif sgrin</string>
-    <string name="on_contact_click">Wrth glicio ar gyswllt</string>
-    <string name="call_contact">Galw cyswllt</string>
-    <string name="view_contact">Gweld manylion cyswllt</string>
     <string name="manage_shown_contact_fields">Rheoli pa feysydd cyswllt i\'w dangos</string>
     <string name="contacts">Cysylltiadau</string>
     <string name="show_only_contacts_with_numbers">Dangos dim ond cysylltiadau gyda rhifau ffôn</string>

app/src/main/res/values-da/strings.xml

@@ -17,7 +17,6 @@
     <string name="no_contacts_with_emails">Ingen kontakter med e-mails fundet</string>
     <string name="no_contacts_with_phone_numbers">Ingen kontakter med telefonnumre fundet</string>
     <string name="new_contact">Ny kontakt</string>
-    <string name="edit_contact">Rediger kontakt</string>
     <string name="select_contact">Vælg kontakt</string>
     <string name="nickname">Kaldenavn</string>
     <string name="no_groups">Ingen grupper</string>
@@ -34,9 +33,6 @@
     <string name="show_phone_numbers">Vis telefonnumre</string>
     <string name="show_contact_thumbnails">Vis miniaturebilleder af kontakter</string>
     <string name="show_dialpad_button">Vis en tastaturknap på hovedskærmen</string>
-    <string name="on_contact_click">Ved klik på kontakt</string>
-    <string name="call_contact">Ring til kontakt</string>
-    <string name="view_contact">Vis kontaktdetaljer</string>
     <string name="manage_shown_contact_fields">Administrer viste kontaktfelter</string>
     <string name="contacts">Kontakter</string>
     <string name="show_only_contacts_with_numbers">Vis kun kontakter med telefonnumre</string>