Fix "Replace characters on save as function, FileNotFoundException" #250

Jan Guegel · Jan Guegel · commit 1a3ffcc08bc8 · 2025-09-25T21:43:44.000+02:00
diff --git a/app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt b/app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt
@@ -36,8 +36,9 @@ class SaveAsActivity : SimpleActivity() {
                             }
 
                             val source = intent.getParcelableExtra<Uri>(Intent.EXTRA_STREAM)!!
-                            val filename = getFilenameFromContentUri(source)
+                            val originalFilename = getFilenameFromContentUri(source)
                                 ?: source.toString().getFilenameFromPath()
+                            val filename = sanitizeFilename(originalFilename)
                             val mimeType = contentResolver.getType(source)
                                 ?: intent.type?.takeIf { it != "*/*" }
                                 ?: filename.getMimeType()
@@ -66,4 +67,9 @@ class SaveAsActivity : SimpleActivity() {
         super.onResume()
         setupToolbar(binding.activitySaveAsToolbar, NavigationIcon.Arrow)
     }
+
+    fun sanitizeFilename(filename: String): String {
+        return filename.replace("[/\\\\<>:\"|?*\u0000-\u001F]".toRegex(), "_")
+            .takeIf { it.isNotBlank() } ?: "unnamed_file"
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,9 @@ class SaveAsActivity : SimpleActivity() {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`val source = intent.getParcelableExtra<Uri>(Intent.EXTRA_STREAM)!!`
`39`		`- val filename = getFilenameFromContentUri(source)`
	`39`	`+ val originalFilename = getFilenameFromContentUri(source)`
`40`	`40`	`?: source.toString().getFilenameFromPath()`
	`41`	`+ val filename = sanitizeFilename(originalFilename)`
`41`	`42`	`val mimeType = contentResolver.getType(source)`
`42`	`43`	`?: intent.type?.takeIf { it != "/" }`
`43`	`44`	`?: filename.getMimeType()`
`@@ -66,4 +67,9 @@ class SaveAsActivity : SimpleActivity() {`
`66`	`67`	`super.onResume()`
`67`	`68`	`setupToolbar(binding.activitySaveAsToolbar, NavigationIcon.Arrow)`
`68`	`69`	`}`
	`70`	`+`
	`71`	`+ fun sanitizeFilename(filename: String): String {`
	`72`	`+ return filename.replace("[/\\\\<>:\"\|?*\u0000-\u001F]".toRegex(), "_")`
	`73`	`+ .takeIf { it.isNotBlank() } ?: "unnamed_file"`
	`74`	`+ }`
`69`	`75`	`}`