apply CodeReview input

getFilePath to updateFilePath
menuItem SaveAs never displayed with icon
backButtonPressed now uses Save without confirmation

Signed-off-by: Jan Guegel <[email protected]>

Author: Jan Guegel

CHANGELOG.md

@@ -11,8 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed missing permission prompt on initial "Save as" launch ([#85])
 - Fixed printing text files containing a "#" ([#104])
 
+### Added
+- Added a separate "Save as" option in the text editor ([#224])
+
 ### Changed
-- "Save as" moved to menu in Text Editor ([#224])
+- Save button now overwrites files directly in the text editor ([#224])
 
 ## [1.2.3] - 2025-09-15
 ### Fixed

app/src/main/kotlin/org/fossify/filemanager/activities/ReadTextActivity.kt

@@ -128,7 +128,7 @@ class ReadTextActivity : SimpleActivity() {
                 lastSavePromptTS = System.currentTimeMillis()
                 ConfirmationAdvancedDialog(this, "", R.string.save_before_closing, R.string.save, R.string.discard) {
                     if (it) {
-                        saveAsText(true)
+                        saveText(true)
                     } else {
                         super.onBackPressed()
                     }
@@ -166,14 +166,14 @@ class ReadTextActivity : SimpleActivity() {
         }, 250)
     }
 
-    private fun getFilePath(){
+    private fun updateFilePath() {
         if (filePath.isEmpty()) {
             filePath = getRealPathFromURI(intent.data!!) ?: ""
         }
     }
 
     private fun saveAsText(shouldExitAfterSaving: Boolean = false) {
-        getFilePath()
+        updateFilePath()
 
         if (filePath.isEmpty()) {
             SaveAsDialog(this, filePath, true) { _, filename ->
@@ -207,13 +207,12 @@ class ReadTextActivity : SimpleActivity() {
     }
 
     private fun saveText(shouldExitAfterSaving: Boolean = false) {
-        getFilePath()
+        updateFilePath()
 
         if (hasStoragePermission()) {
             val file = File(filePath)
             getFileOutputStream(file.toFileDirItem(this), true) {
-                val shouldOverwriteOriginalText = true
-                saveTextContent(it, shouldExitAfterSaving, shouldOverwriteOriginalText)
+                saveTextContent(it, shouldExitAfterSaving, true)
             }
         } else {
             toast(R.string.no_storage_permissions)

app/src/main/res/menu/menu_editor.xml

@@ -15,9 +15,9 @@
         app:showAsAction="always" />
     <item
         android:id="@+id/menu_save_as"
-        android:icon="@drawable/ic_save_vector"
+        android:showAsAction="never"
         android:title="@string/save_as"
-        app:showAsAction="ifRoom" />
+        app:showAsAction="never" />
     <item
         android:id="@+id/menu_print"
         android:icon="@drawable/ic_print_vector"