Apply suggestions from code review

thanks for the feedback!

Co-authored-by: Naveen Singh <[email protected]>

Author: jguegel

app/src/main/kotlin/org/fossify/filemanager/activities/SaveAsActivity.kt

@@ -15,8 +15,7 @@ import java.io.File
 class SaveAsActivity : SimpleActivity() {
     private val binding by viewBinding(ActivitySaveAsBinding::inflate)
 
-
-        override fun onCreate(savedInstanceState: Bundle?) {
+    override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(binding.root)
         tryInitFileManager()
@@ -32,6 +31,7 @@ class SaveAsActivity : SimpleActivity() {
             }
         }
     }
+
     private fun saveAsDialog() {
         if (intent.action == Intent.ACTION_SEND && intent.extras?.containsKey(Intent.EXTRA_STREAM) == true) {
             FilePickerDialog(this, pickFile = false, showHidden = config.shouldShowHidden(), showFAB = true, showFavoritesButton = true) {

app/src/main/kotlin/org/fossify/filemanager/activities/SimpleActivity.kt

@@ -45,17 +45,12 @@ open class SimpleActivity : BaseSimpleActivity() {
 
     override fun getRepositoryName() = "File-Manager"
 
-    @SuppressLint("NewApi")
-    override fun onActivityResult(requestCode: Int, resultCode: Int, dataIntent: Intent?) {
-        super.onActivityResult(requestCode, resultCode, dataIntent)
-
+   @SuppressLint("NewApi")
+    override fun onActivityResult(requestCode: Int, resultCode: Int, resultData: Intent?) {
+        super.onActivityResult(requestCode, resultCode, resultData)
+        isAskingPermissions = false
         if (requestCode == MANAGE_STORAGE_RC && isRPlus()) {
-            if (Environment.isExternalStorageManager()) {
-                recreate()
-            } else {
-                toast(R.string.no_storage_permissions)
-                finish()
-            }
+            actionOnPermission?.invoke(Environment.isExternalStorageManager())
         }
     }