Skip to content

Conversation

@naveensingh
Copy link
Member

Description of the changes in your PR

  • Updated AGP to 8.9.0
  • Updated commons (with new about screen)
  • Removed support for Android 7 and older versions
  • Added the new global/full-screen app lock
  • Disabled language splits
  • Moved options like about, settings back into the popup menu

Fixes the following issue(s)

Acknowledgement

@mimi89999
Copy link

Is it the correct way of updating the Gradle Wrapper? Shouldn't ./gradlew wrapper --gradle-version 8.11.1 be used and run twice as stated in https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper ?

@naveensingh
Copy link
Member Author

That is the recommended way but it's optional. I usually just run the AGP upgrade assistant which updates the required Gradle version as well.

@mimi89999
Copy link

The Gradle update method updates the Wrapper jar, but the Android Studio method does not. 🤔

@naveensingh
Copy link
Member Author

Yes, updating the version number is usually enough. The other changes are optimizations/optional.

@mimi89999
Copy link

The checksum of the Gradle Wrapper corresponded to a very ancient version:

$ sha256sum gradle/wrapper/gradle-wrapper.jar 
16caeaf66d57a0d1d2087fef6a97efa62de8da69afa5b908f40db35afc4342da  gradle/wrapper/gradle-wrapper.jar

In https://gradle.org/release-checksums/ it's under v2.10

@naveensingh
Copy link
Member Author

Yes, it's from when the project was created :)

@naveensingh naveensingh merged commit 1383a26 into master Mar 12, 2025
4 of 5 checks passed
@naveensingh naveensingh deleted the update_deps branch March 12, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't build Commons as subproject

4 participants