-
-
Notifications
You must be signed in to change notification settings - Fork 76
Preserve modified date when unzip files. #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I knew someone would take this on. I found a couple of issues:
Thanks. |
ec02dba to
0e267f1
Compare
Thanks for the great points, @naveensingh I think it makes sense to create a separate issue for the compression side, since it’s a bit outside the scope of the original bug. The other three decompression-related points can definitely be handled in this PR. Does that sound okay to you? |
|
Sure, let's go with that. |
0e267f1 to
a4f8460
Compare
- Additionally handle the case with 0 last modified time.
|
Fixed the following cases:
I also attempted to update the "last modified" time for directories, but it's more complex than for regular files:
So, I believe this PR addresses the primary issue. I’ll create two additional issues that are out of scope for this PR:
What do you think? @naveensingh |
naveensingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. But if directories are getting too complicated, we can skip them for now and just focus on files.
Merging since this works now 🎉
Thank you.
Type of change(s)
What changed and why
lastModifiedTimeof files when unzipping them.Fixes the following issue(s)
Checklist
CHANGELOG.md(if applicable).