Skip to content

Zip password issue #76, #194 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jguegel wants to merge 8 commits into from
Closed

Zip password issue #76, #194 #287

jguegel wants to merge 8 commits into from

Conversation

@jguegel
Copy link
Contributor

@jguegel jguegel commented Oct 8, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Fixed refresh onResume in ItemsFragment, manual refresh was needed after returning to fragment, should now be obsolet
  • Fixed duplicated Folder in zip when password protected, by normalizing ZIP entry paths and ensure empty directories are included in the file list

Tests performed

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@jguegel jguegel requested a review from naveensingh as a code owner October 8, 2025 13:04
naveensingh
naveensingh requested changes Oct 9, 2025
View reviewed changes
app/src/main/kotlin/org/fossify/filemanager/activities/DecompressActivity.kt

val lastModified = zipEntry.lastModifiedTime
val filename = zipEntry.fileName.removeSuffix("/")
if (allFiles.none { it.mPath == filename }) {
Copy link
Member

@naveensingh naveensingh Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, you are not fixing the root cause, i.e., the source of duplication. This filtering will also slow things down a bit on large archives.

Copy link
Member

@naveensingh naveensingh Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: #301

app/src/main/kotlin/org/fossify/filemanager/fragments/ItemsFragment.kt

itemsSwipeRefresh.isEnabled = lastSearchedText.isEmpty() && activity?.config?.enablePullToRefresh != false
}
refreshFragment()
Copy link
Member

@naveensingh naveensingh Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reloading on every resume will be inefficient. That's why I didn't suggest it in #273.

@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Oct 9, 2025
@fossifybot
Copy link
Contributor

fossifybot bot commented Oct 23, 2025

This pull request was automatically closed due to inactivity and/or lack of response from the author. If you have further updates or additional information, please comment or reopen the PR to continue.

@fossifybot fossifybot bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Oct 23, 2025
@fossifybot fossifybot bot closed this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naveensingh naveensingh naveensingh requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auto-update Files tab content after extracting files from ZIP archive Showing duplicate folders after compression with password

2 participants

@jguegel @naveensingh