Skip to content

Commit 7487734

Browse files
authored
fix: show stroke around on color picker button (#828)
Refs: #337
1 parent f67ba43 commit 7487734

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## [Unreleased]
8+
### Fixed
9+
- Fixed invisible color picker button in black themes ([#337])
810

911
## [1.10.0] - 2025-12-16
1012
### Added
@@ -231,6 +233,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
231233
[#241]: https://github.com/FossifyOrg/Gallery/issues/241
232234
[#275]: https://github.com/FossifyOrg/Gallery/issues/275
233235
[#325]: https://github.com/FossifyOrg/Gallery/issues/325
236+
[#337]: https://github.com/FossifyOrg/Gallery/issues/337
234237
[#362]: https://github.com/FossifyOrg/Gallery/issues/362
235238
[#365]: https://github.com/FossifyOrg/Gallery/issues/365
236239
[#375]: https://github.com/FossifyOrg/Gallery/issues/375

app/src/main/kotlin/org/fossify/gallery/activities/EditActivity.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import com.zomato.photofilters.FilterPack
2626
import com.zomato.photofilters.imageprocessors.Filter
2727
import org.fossify.commons.dialogs.ColorPickerDialog
2828
import org.fossify.commons.extensions.applyColorFilter
29+
import org.fossify.commons.extensions.setFillWithStroke
2930
import org.fossify.commons.extensions.beGone
3031
import org.fossify.commons.extensions.beGoneIf
3132
import org.fossify.commons.extensions.beVisible
@@ -813,7 +814,8 @@ class EditActivity : BaseCropActivity() {
813814

814815
private fun updateDrawColor(color: Int) {
815816
drawColor = color
816-
binding.bottomEditorDrawActions.bottomDrawColor.applyColorFilter(color)
817+
binding.bottomEditorDrawActions.bottomDrawColor
818+
.setFillWithStroke(color, getProperBackgroundColor())
817819
config.lastEditorDrawColor = color
818820
binding.editorDrawCanvas.updateColor(color)
819821
}

app/src/main/res/layout/bottom_editor_draw_actions.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:app="http://schemas.android.com/apk/res-auto"
4+
xmlns:tools="http://schemas.android.com/tools"
45
android:id="@+id/bottom_editor_draw_actions_wrapper"
56
android:layout_width="match_parent"
67
android:layout_height="@dimen/bottom_actions_height"
@@ -38,10 +39,10 @@
3839
android:clickable="false"
3940
android:contentDescription="@null"
4041
android:padding="@dimen/small_margin"
41-
android:src="@drawable/circle_background"
4242
app:layout_constraintBottom_toBottomOf="parent"
4343
app:layout_constraintRight_toLeftOf="@+id/bottom_draw_undo"
44-
app:layout_constraintTop_toTopOf="parent" />
44+
app:layout_constraintTop_toTopOf="parent"
45+
tools:src="@drawable/circle_background" />
4546

4647
<ImageView
4748
android:id="@+id/bottom_draw_undo"

0 commit comments

Comments
 (0)