Commit 99cea60
committed
Fix deletion of random SMS when trying to update threads
Commit 44c540b (Fixed updating last message after deleting (#167),
2021-09-04) introduced a hack to update the conversation snippet,
however there is a bug in that code: it tries to delete by thread ID,
but the condition is applied to the SMS table, not to the threads
table.[1] So instead of deleting the thread with that ID, it deletes
whichever SMS happens to have that ID.
The fix is to change the condition to an always-false condition, so
that no messages will be deleted. The threads will still get
updated.[2]
Fixes #148.
[1] https://android.googlesource.com/platform/packages/providers/TelephonyProvider/+/android14-release/src/com/android/providers/telephony/MmsSmsProvider.java#1405
[2] https://android.googlesource.com/platform/packages/providers/TelephonyProvider/+/android14-release/src/com/android/providers/telephony/MmsSmsProvider.java#14091 parent 1c7376c commit 99cea60
File tree
1 file changed
+5
-3
lines changed- app/src/main/kotlin/org/fossify/messages/extensions
1 file changed
+5
-3
lines changedLines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
990 | 990 | | |
991 | 991 | | |
992 | 992 | | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
993 | 996 | | |
994 | | - | |
995 | | - | |
| 997 | + | |
996 | 998 | | |
997 | | - | |
| 999 | + | |
998 | 1000 | | |
999 | 1001 | | |
1000 | 1002 | | |
| |||
0 commit comments