Skip to content

Conversation

@Choucroute-melba
Copy link
Contributor

@Choucroute-melba Choucroute-melba commented Jan 8, 2025

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added ShortcutHelper class
  • Publishong shortcuts for each used thread

This changes add conversation shortcuts to the launcher. They also aim to integrate the app in the Android conversation space.

Fixes the following issue(s)

Acknowledgement

@Aga-C
Copy link
Contributor

Aga-C commented Jan 9, 2025

Thanks for contributing! I've tested it and found some problems:

  • New conversation shortcut is treated like a conversation and disappears at some point. It should be pinned to the top.
  • Private contacts are displayed as numbers.
  • Deleted conversations are still visible as conversation shortcuts.
  • Opening deleted conversations from a shortcut throws An unknown error occured. As we can't remove shortcuts from launcher, we can just open the app on the conversations list (e.g. Google Messages do it this way).
  • If you have multiple SMS apps (most likely some users won't turn off their preinstalled one), it asks in which app the shortcut should be opened. As it's a shortcut from Fossify Messages, it should always open Fossify Messages.

@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Jan 9, 2025
@Choucroute-melba
Copy link
Contributor Author

Hi, everything you've mentionned should be ok now except for your second point @Aga-C , I don't know about private contacts so i've tried something but if it's not working please could you give me more details on how to handle this ?
Also about import wildcards it's done automatically by the ide, .editorconfig need to be changed to avoid this
Thanks for reviewing my work, have a nice day.

@Aga-C Aga-C removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Jan 10, 2025
@Aga-C
Copy link
Contributor

Aga-C commented Jan 10, 2025

I don't know about private contacts so i've tried something but if it's not working please could you give me more details on how to handle this ?

Private contacts are contacts stored in Fossify Contacts as not visible for other apps (but still can be accessed by other Fossify apps). It's still not working. Probably that's because for the title you rely only on conversation title. See how it's done inside the app to ensure that the correct title is always displayed:

private fun setupThreadTitle() {
val title = conversation?.title
binding.threadToolbar.title = if (!title.isNullOrEmpty()) {
title
} else {
participants.getThreadTitle()
}
}

Also, I've found some more bugs while testing:

  • When I add a shortcut to the home screen, the last character from the name (or phone number) is missing.
  • We can change conversation name in Conversation Details. It's not taken into account, the original name is always shown in the shortcuts menu.

@Choucroute-melba
Copy link
Contributor Author

Hi again, I was able to do necessary changes. Tell me if there is anything else I can do

@Aga-C
Copy link
Contributor

Aga-C commented Jan 11, 2025

Seems that everything works fine, thanks!

@naveensingh naveensingh self-assigned this Jun 3, 2025
@naveensingh
Copy link
Member

Merging this now, thanks!

@naveensingh naveensingh merged commit 857a1fd into FossifyOrg:master Jun 4, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat - Conversation Shortcuts in Launcher

3 participants