diff --git a/app/detekt-baseline.xml b/app/detekt-baseline.xml
index 2de7cfab..f63f9c0b 100644
--- a/app/detekt-baseline.xml
+++ b/app/detekt-baseline.xml
@@ -30,7 +30,6 @@
MagicNumber:MainActivity.kt$MainActivity$5
MagicNumber:MainActivity.kt$MainActivity$60
MagicNumber:MediaSessionCallback.kt$<no name provided>$4
- MagicNumber:MyWidgetProvider.kt$MyWidgetProvider$5000
MagicNumber:PlaybackSpeedFragment.kt$PlaybackSpeedFragment$0.05f
MagicNumber:PlaybackSpeedFragment.kt$PlaybackSpeedFragment$0.25f
MagicNumber:PlaybackSpeedFragment.kt$PlaybackSpeedFragment$100
@@ -39,7 +38,6 @@
MagicNumber:RecyclerView.kt$25
MagicNumber:RoomHelper.kt$RoomHelper$50
MagicNumber:SimpleMediaScanner.kt$SimpleMediaScanner$100L
- MagicNumber:SimpleMusicPlayer.kt$SimpleMusicPlayer$5000
MagicNumber:SleepTimerCustomDialog.kt$SleepTimerCustomDialog$60
MagicNumber:SongsDatabase.kt$SongsDatabase.Companion.<no name provided>$10
MagicNumber:SongsDatabase.kt$SongsDatabase.Companion.<no name provided>$11
@@ -54,8 +52,6 @@
MagicNumber:SongsDatabase.kt$SongsDatabase.Companion.<no name provided>$7
MagicNumber:SongsDatabase.kt$SongsDatabase.Companion.<no name provided>$8
MagicNumber:SongsDatabase.kt$SongsDatabase.Companion.<no name provided>$9
- MagicNumber:TrackActivity.kt$TrackActivity$100
- MagicNumber:TrackActivity.kt$TrackActivity$500L
MagicNumber:WidgetConfigureActivity.kt$WidgetConfigureActivity$100
MaxLineLength:AlbumHeader.kt$AlbumHeader : ListItem
MaxLineLength:AlbumsActivity.kt$AlbumsActivity$var tracksSectionLabel = resources.getQuantityString(R.plurals.tracks_plural, albumTracks.size, albumTracks.size)
@@ -112,7 +108,6 @@
MaxLineLength:MediaSessionCallback.kt$<no name provided>$override
MaxLineLength:MyViewPagerFragment.kt$MyViewPagerFragment$abstract
MaxLineLength:MyViewPagerFragment.kt$MyViewPagerFragment$fun
- MaxLineLength:MyWidgetProvider.kt$MyWidgetProvider$PREVIOUS -> if (player.contentPosition > 5000) player.seekTo(0) else player.seekToPreviousMediaItem()
MaxLineLength:MyWidgetProvider.kt$MyWidgetProvider$override fun onAppWidgetOptionsChanged(context: Context, appWidgetManager: AppWidgetManager, widgetId: Int, newOptions: Bundle)
MaxLineLength:MyWidgetProvider.kt$MyWidgetProvider$setImageViewBitmap(R.id.next_btn, context.resources.getColoredBitmap(org.fossify.commons.R.drawable.ic_next_vector, widgetTextColor))
MaxLineLength:MyWidgetProvider.kt$MyWidgetProvider$val drawableId = if (isPlaying) org.fossify.commons.R.drawable.ic_pause_vector else org.fossify.commons.R.drawable.ic_play_vector
@@ -121,7 +116,6 @@
MaxLineLength:PlaybackService.kt$PlaybackService.Companion$// Initializing a media controller might take a noticeable amount of time thus we expose current playback info here to keep things as quick as possible.
MaxLineLength:PlaybackSpeedFragment.kt$PlaybackSpeedFragment$val background = ResourcesCompat.getDrawable(resources, org.fossify.commons.R.drawable.bottom_sheet_bg, requireContext().theme)
MaxLineLength:Player.kt$*
- MaxLineLength:Player.kt$private
MaxLineLength:PlayerListener.kt$<no name provided>$override fun onPlayerError(error: PlaybackException)
MaxLineLength:Playlist.kt$Playlist.Companion$sorting and PLAYER_SORT_BY_TITLE != 0 -> AlphanumericComparator().compare(first.title.lowercase(), second.title.lowercase())
MaxLineLength:PlaylistsAdapter.kt$PlaylistsAdapter$override fun onChange(position: Int)
@@ -151,7 +145,6 @@
MaxLineLength:SimpleMediaScanner.kt$SimpleMediaScanner$id = id
MaxLineLength:SimpleMediaScanner.kt$SimpleMediaScanner$val artist = retriever.extractMetadata(METADATA_KEY_ARTIST) ?: retriever.extractMetadata(METADATA_KEY_ALBUMARTIST) ?: MediaStore.UNKNOWN_STRING
MaxLineLength:SimpleMediaScanner.kt$SimpleMediaScanner$val invalidTracks = context.audioHelper.getAllTracks().filter { it.mediaStoreId !in newTrackIds || it.path !in newTrackPaths }
- MaxLineLength:SimpleMusicActivity.kt$SimpleMusicActivity$PermissionRequiredDialog(this, org.fossify.commons.R.string.allow_notifications_music_player, { openNotificationSettings() })
MaxLineLength:SleepTimerCustomDialog.kt$SleepTimerCustomDialog$binding.minutesHint.hint = activity.getString(org.fossify.commons.R.string.minutes_raw).replaceFirstChar { it.uppercaseChar() }
MaxLineLength:SongsDatabase.kt$SongsDatabase$@Database(entities = [Track::class, Playlist::class, QueueItem::class, Artist::class, Album::class, Genre::class], version = 15)
MaxLineLength:SongsDatabase.kt$SongsDatabase.Companion.<no name provided>$"CREATE TABLE songs_new (media_store_id INTEGER NOT NULL, title TEXT NOT NULL, artist TEXT NOT NULL, path TEXT NOT NULL, duration INTEGER NOT NULL, "
@@ -176,8 +169,6 @@
MaxLineLength:TagHelper.kt$TagHelper.Companion$private val SUPPORTED_EXTENSIONS = SupportedFileFormat.values().map { it.filesuffix }.filter { it !in EXCLUDED_EXTENSIONS }
MaxLineLength:Track.kt$Track$SHOW_FILENAME_IF_UNAVAILABLE -> if (title == MediaStore.UNKNOWN_STRING) path.getFilenameFromPath() else title
MaxLineLength:Track.kt$Track.Companion$val discComparison = (first.discNumber ?: Int.MAX_VALUE).compareTo(second.discNumber ?: Int.MAX_VALUE)
- MaxLineLength:TrackActivity.kt$TrackActivity$arrayOf(activityTrackToggleShuffle, activityTrackPrevious, activityTrackNext, activityTrackPlaybackSetting)
- MaxLineLength:TrackActivity.kt$TrackActivity$val drawableId = if (isSlow) R.drawable.ic_playback_speed_slow_vector else R.drawable.ic_playback_speed_vector
MaxLineLength:TracksActivity.kt$TracksActivity$// this activity is used for displaying Playlist and Folder tracks, also Album tracks with a possible album header at the top
MaxLineLength:TracksActivity.kt$TracksActivity$PermissionRequiredDialog(this, org.fossify.commons.R.string.allow_notifications_music_player, { openNotificationSettings() })
MaxLineLength:TracksActivity.kt$TracksActivity$if
@@ -224,7 +215,6 @@
TooManyFunctions:SettingsActivity.kt$SettingsActivity : SimpleControllerActivity
TooManyFunctions:SimpleControllerActivity.kt$SimpleControllerActivity : SimpleActivityListener
TooManyFunctions:SimpleMediaScanner.kt$SimpleMediaScanner
- TooManyFunctions:SimpleMusicPlayer.kt$SimpleMusicPlayer : ForwardingPlayer
TooManyFunctions:SongsDao.kt$SongsDao
TooManyFunctions:TrackActivity.kt$TrackActivity : SimpleControllerActivityPlaybackSpeedListener
TooManyFunctions:TracksActivity.kt$TracksActivity : SimpleMusicActivity
@@ -243,7 +233,6 @@
VariableNaming:PlaybackSpeedFragment.kt$PlaybackSpeedFragment$private val MIN_PLAYBACK_SPEED = 0.25f
VariableNaming:PlaybackSpeedFragment.kt$PlaybackSpeedFragment$private val STEP = 0.05f
VariableNaming:RoomHelper.kt$RoomHelper$val ITEMS_PER_GROUP = 50
- VariableNaming:TrackActivity.kt$TrackActivity$private val SWIPE_DOWN_THRESHOLD = 100
VariableNaming:TracksActivity.kt$TracksActivity$private val PICK_EXPORT_FILE_INTENT = 2
VariableNaming:TracksHeaderAdapter.kt$TracksHeaderAdapter$private val ITEM_HEADER = 0
VariableNaming:TracksHeaderAdapter.kt$TracksHeaderAdapter$private val ITEM_TRACK = 1
@@ -270,7 +259,6 @@
WildcardImport:ManageVisibleTabsDialog.kt$import org.fossify.musicplayer.helpers.*
WildcardImport:MediaItem.kt$import org.fossify.musicplayer.models.*
WildcardImport:MediaItemProvider.kt$import org.fossify.musicplayer.extensions.*
- WildcardImport:MediaSessionCallback.kt$import androidx.media3.session.*
WildcardImport:NewPlaylistDialog.kt$import org.fossify.commons.extensions.*
WildcardImport:PlaybackSpeedFragment.kt$import org.fossify.commons.extensions.*
WildcardImport:Playlist.kt$import androidx.room.*
@@ -285,14 +273,10 @@
WildcardImport:SimpleMediaScanner.kt$import android.media.MediaMetadataRetriever.*
WildcardImport:SimpleMediaScanner.kt$import org.fossify.commons.extensions.*
WildcardImport:SimpleMediaScanner.kt$import org.fossify.musicplayer.models.*
- WildcardImport:SimpleMusicPlayer.kt$import kotlinx.coroutines.*
- WildcardImport:SimpleMusicPlayer.kt$import org.fossify.musicplayer.extensions.*
WildcardImport:SleepTimerCustomDialog.kt$import org.fossify.commons.extensions.*
WildcardImport:SongsDatabase.kt$import org.fossify.musicplayer.interfaces.*
WildcardImport:SongsDatabase.kt$import org.fossify.musicplayer.models.*
WildcardImport:Track.kt$import org.fossify.musicplayer.helpers.*
- WildcardImport:TrackActivity.kt$import org.fossify.commons.extensions.*
- WildcardImport:TrackActivity.kt$import org.fossify.musicplayer.extensions.*
WildcardImport:TracksActivity.kt$import org.fossify.commons.extensions.*
WildcardImport:TracksActivity.kt$import org.fossify.musicplayer.helpers.*
WildcardImport:TracksActivity.kt$import org.fossify.musicplayer.models.*
diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml
index 69a8ea5f..b62a5b0f 100644
--- a/app/lint-baseline.xml
+++ b/app/lint-baseline.xml
@@ -80,7 +80,7 @@
-
-
-
-
@@ -173,7 +162,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
@@ -184,7 +173,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
@@ -256,7 +245,7 @@
-
-
-
-
-
-
-
-
@@ -1748,7 +1715,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">