feat(character_count): added character count#185
feat(character_count): added character count#185TopFox wants to merge 0 commit intoFossifyOrg:mainfrom
Conversation
|
Remark: the current implementation doesn't count white spaces as characters and initial issue isn't clear on whether this should be the case or not. Can be easily fixed if needed To do this, replace line 285 ( |
naveensingh
left a comment
There was a problem hiding this comment.
The counter now overlaps with long notes, and that doesn't look good. How about making the whole overlay text view opaque and full-width? The view will be hidden unless word or character counting is enabled.
Changed word count's text to specify that the count is for Words (useful when both character and word counts are active)
The character/word overlay is a little wide, but it won't be a problem once the overlapping issue is fixed. Let's change the format to 42 words, 524 characters for a smoother flow.
the current implementation doesn't count white spaces as characters and initial issue isn't clear on whether this should be the case or not.
Let's count them all, thanks.
app/src/main/kotlin/org/fossify/notes/fragments/TextFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/notes/activities/SettingsActivity.kt
Outdated
Show resolved
Hide resolved
|
Wait I didn't want to close this PR and can't reopen it |
|
It's greyed out on my side too. Did you accidentally delete you branch? Maybe it's the force push. There are zero commits now. |


Type of change(s)
What changed and why
Before/After Screenshots/Screen Record
Character_count.mp4
Fixes the following issue(s)
Checklist
CHANGELOG.md(if applicable).