fix: improve speed dial UX (#546)

* Show the contact name in the confirmation dialog after speed dialing #543

* Improved speed dial management UX for contacts with multiple numbers

Refs: #543

Author: Aga-C

CHANGELOG.md

@@ -10,6 +10,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 - Tapping a contact now starts a call; tap the photo for details ([#80])
+- Improved speed dial management UX for contacts with multiple numbers 
+
+### Fixed
+- Fixed speed dial not showing contact name ([#543])
 
 ## [1.6.2] - 2025-08-23
 ### Changed
@@ -179,6 +183,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 [#378]: https://github.com/FossifyOrg/Phone/issues/378
 [#526]: https://github.com/FossifyOrg/Phone/issues/526
 [#535]: https://github.com/FossifyOrg/Phone/issues/535
+[#543]: https://github.com/FossifyOrg/Phone/issues/543
 
 [Unreleased]: https://github.com/FossifyOrg/Phone/compare/1.6.2...HEAD
 [1.6.2]: https://github.com/FossifyOrg/Phone/compare/1.6.1...1.6.2

app/src/main/kotlin/org/fossify/phone/activities/DialpadActivity.kt

@@ -376,9 +376,9 @@ class DialpadActivity : SimpleActivity() {
         }
     }
 
-    private fun initCall(number: String = binding.dialpadInput.value) {
+    private fun initCall(number: String = binding.dialpadInput.value, name: String? = null) {
         if (number.isNotEmpty()) {
-            startCallWithConfirmationCheck(number, number)
+            startCallWithConfirmationCheck(number, name ?: number)
             clearInputWithDelay()
         } else {
             RecentsHelper(this).getRecentCalls(queryLimit = 1) {
@@ -410,7 +410,7 @@ class DialpadActivity : SimpleActivity() {
         if (binding.dialpadInput.value.length == 1) {
             val speedDial = speedDialValues.firstOrNull { it.id == id }
             if (speedDial?.isValid() == true) {
-                initCall(speedDial.number)
+                initCall(speedDial.number, speedDial.getName(this))
                 return true
             }
         }

app/src/main/kotlin/org/fossify/phone/activities/ManageSpeedDialActivity.kt

@@ -4,6 +4,7 @@ import android.os.Bundle
 import com.google.gson.Gson
 import org.fossify.commons.dialogs.RadioGroupDialog
 import org.fossify.commons.extensions.getMyContactsCursor
+import org.fossify.commons.extensions.getPhoneNumberTypeText
 import org.fossify.commons.extensions.updateTextColors
 import org.fossify.commons.extensions.viewBinding
 import org.fossify.commons.helpers.ContactsHelper
@@ -71,7 +72,7 @@ class ManageSpeedDialActivity : SimpleActivity(), RemoveSpeedDialListener {
             SelectContactDialog(this, allContacts) { selectedContact ->
                 if (selectedContact.phoneNumbers.size > 1) {
                     val radioItems = selectedContact.phoneNumbers.mapIndexed { index, item ->
-                        RadioItem(index, item.normalizedNumber, item)
+                        RadioItem(index, "${item.value} (${getPhoneNumberTypeText(item.type, item.label)})", item)
                     }
                     val userPhoneNumbersList = selectedContact.phoneNumbers.map { it.value }
                     val checkedItemId = userPhoneNumbersList.indexOf(clickedContact.number)
@@ -80,6 +81,8 @@ class ManageSpeedDialActivity : SimpleActivity(), RemoveSpeedDialListener {
                         speedDialValues.first { it.id == clickedContact.id }.apply {
                             displayName = selectedContact.getNameToDisplay()
                             number = selectedNumber.normalizedNumber
+                            type = selectedNumber.type
+                            label = selectedNumber.label
                         }
                         updateAdapter()
                     }
@@ -102,6 +105,8 @@ class ManageSpeedDialActivity : SimpleActivity(), RemoveSpeedDialListener {
             speedDialValues.first { it.id == dialId }.apply {
                 displayName = ""
                 number = ""
+                type = null
+                label = null
             }
         }
         updateAdapter()

app/src/main/kotlin/org/fossify/phone/adapters/SpeedDialAdapter.kt

@@ -70,7 +70,7 @@ class SpeedDialAdapter(
     private fun setupView(binding: ItemSpeedDialBinding, speedDial: SpeedDial) {
         binding.apply {
             var displayName = "${speedDial.id}. "
-            displayName += if (speedDial.isValid()) speedDial.displayName else ""
+            displayName += if (speedDial.isValid()) speedDial.getName(activity) else ""
 
             speedDialLabel.apply {
                 text = displayName

app/src/main/kotlin/org/fossify/phone/models/SpeedDial.kt

@@ -1,5 +1,20 @@
 package org.fossify.phone.models
 
-data class SpeedDial(val id: Int, var number: String, var displayName: String) {
+import android.content.Context
+import org.fossify.commons.extensions.getPhoneNumberTypeText
+
+data class SpeedDial(
+    val id: Int,
+    var number: String,
+    var displayName: String,
+    var type: Int? = null,
+    var label: String? = null
+) {
     fun isValid() = number.trim().isNotEmpty()
+
+    fun getName(context: Context) = if (type != null && label != null) {
+        "$displayName - ${context.getPhoneNumberTypeText(type!!, label!!)}"
+    } else {
+        displayName
+    }
 }