Skip to content

Commit 37bc138

Browse files
naveensinghnaveensingh
committed
chore: update lint rules and baselines
1 parent 28bf436 commit 37bc138

File tree

6 files changed

+330
-42
lines changed

6 files changed

+330
-42
lines changed

‎.github/workflows/update-lint-baselines.yml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
name: Update lint baselines
2+
3+
on:
4+
workflow_dispatch:
5+
schedule:
6+
- cron: "0 0 1 * *"
7+
8+
jobs:
9+
update-lint-baselines:
10+
uses: FossifyOrg/.github/.github/workflows/update-lint-baselines.yml@main
11+
secrets: inherit

‎.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ keystore.jks
1010
keystore.properties
1111
fastlane/fastlane.json
1212
fastlane/report.xml
13+
.kotlin/

‎app/build.gradle.kts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,9 @@ android {
120120
lint {
121121
checkReleaseBuilds = false
122122
abortOnError = true
123-
warningsAsErrors = true
123+
warningsAsErrors = false
124124
baseline = file("lint-baseline.xml")
125+
lintConfig = rootProject.file("lint.xml")
125126
}
126127

127128
bundle {

‎app/detekt-baseline.xml‎

Lines changed: 28 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,39 @@
11
<?xml version="1.0" ?>
22
<SmellBaseline>
3-
<ManuallySuppressedIssues></ManuallySuppressedIssues>
3+
<ManuallySuppressedIssues/>
44
<CurrentIssues>
55
<ID>EmptyFunctionBlock:MyContentProviderHelper.kt$MyContentProviderHelper${}</ID>
6-
<ID>FunctionNaming:MainActivity.kt$MainActivity$@Composable private fun AppLaunched( donateAlertDialogState: AlertDialogState = getDonateAlertDialogState(), rateStarsAlertDialogState: AlertDialogState = getRateStarsAlertDialogState(), )</ID>
7-
<ID>FunctionNaming:MainActivity.kt$MainActivity$@Composable private fun CheckWhatsNew( releasesList: SnapshotStateList&lt;Release&gt;, checkWhatsNewAlertDialogState: AlertDialogState )</ID>
8-
<ID>FunctionNaming:MainScreen.kt$@Composable @MyDevices private fun MainScreenPreview()</ID>
9-
<ID>FunctionNaming:MainScreen.kt$@Composable internal fun MainScreen( showMoreApps: Boolean, openSettings: () -&gt; Unit, openAbout: () -&gt; Unit, moreAppsFromUs: () -&gt; Unit, linkColor: Color, )</ID>
6+
<ID>FunctionNaming:FossifyApp.kt$@Composable internal fun FossifyApp( app: FossifyApp, modifier: Modifier = Modifier, launchApp: (packageName: String) -&gt; Unit, uninstallApp: (packageName: String) -&gt; Unit )</ID>
7+
<ID>FunctionNaming:FossifyApp.kt$@Composable private fun AppIcon( icon: Drawable?, verified: Boolean )</ID>
8+
<ID>FunctionNaming:FossifyApp.kt$@Composable private fun AppInfo( versionName: String?, packageName: String, signerName: String?, installerName: String? )</ID>
9+
<ID>FunctionNaming:FossifyApp.kt$@Composable private fun AppName( name: String, verified: Boolean )</ID>
10+
<ID>FunctionNaming:FossifyApp.kt$@Composable private fun TrailingContent( verified: Boolean, packageName: String, launchApp: (packageName: String) -&gt; Unit, uninstallApp: (packageName: String) -&gt; Unit )</ID>
11+
<ID>FunctionNaming:FossifyApp.kt$@Preview @Composable private fun PreviewFossifyApp( @PreviewParameter(BooleanPreviewParameterProvider::class) verified: Boolean )</ID>
12+
<ID>FunctionNaming:MainActivity.kt$MainActivity$@Composable private fun AppLaunched( donateAlertDialogState: AlertDialogState = getDonateAlertDialogState(), )</ID>
13+
<ID>FunctionNaming:MainActivity.kt$MainActivity$@Composable private fun CheckWhatsNew( releasesList: SnapshotStateList&lt;Release&gt;, checkWhatsNewAlertDialogState: AlertDialogState, )</ID>
14+
<ID>FunctionNaming:MainScreen.kt$@Composable @MyDevices private fun MainScreenPreview( @PreviewParameter(BooleanPreviewParameterProvider::class) showGoogleRelations: Boolean, )</ID>
15+
<ID>FunctionNaming:MainScreen.kt$@Composable internal fun MainScreen( allApps: List&lt;FossifyApp&gt;, fakeApps: List&lt;FossifyApp&gt;, showGoogleRelations: Boolean, showThankYouNotice: Boolean, openSettings: () -&gt; Unit, openAbout: () -&gt; Unit, moreAppsFromUs: () -&gt; Unit, launchApp: (packageName: String) -&gt; Unit, uninstallApp: (packageName: String) -&gt; Unit, hideThankYouNotice: () -&gt; Unit, onDonateClicked: () -&gt; Unit, linkColor: Color, )</ID>
16+
<ID>FunctionNaming:MainScreen.kt$@Composable private fun MainNotice( text: String, buttonText: String, modifier: Modifier, linkColor: Color, onButtonClicked: () -&gt; Unit, )</ID>
1017
<ID>FunctionNaming:SettingsScreen.kt$@Composable @MyDevices private fun SettingsScreenPreview()</ID>
11-
<ID>FunctionNaming:SettingsScreen.kt$@Composable internal fun SettingsScreen( displayLanguage: String, isUseEnglishEnabled: Boolean, isUseEnglishChecked: Boolean, isHidingLauncherIcon: Boolean, isShowingCheckmarksOnSwitches: Boolean, onUseEnglishPress: (Boolean) -&gt; Unit, onSetupLanguagePress: () -&gt; Unit, hideLauncherIconClick: (Boolean) -&gt; Unit, showCheckmarksOnSwitches: (Boolean) -&gt; Unit, customizeColors: () -&gt; Unit, goBack: () -&gt; Unit, )</ID>
12-
<ID>LongParameterList:Context.kt$( appNameId: Int, licenseMask: Long, versionName: String, faqItems: ArrayList&lt;FAQItem&gt;, showFAQBeforeMail: Boolean, getAppIconIDs: ArrayList&lt;Int&gt; = getAppIconIDs(), getAppLauncherName: String = launcherName() )</ID>
13-
<ID>LongParameterList:SettingsScreen.kt$( displayLanguage: String, isUseEnglishEnabled: Boolean, isUseEnglishChecked: Boolean, isHidingLauncherIcon: Boolean, isShowingCheckmarksOnSwitches: Boolean, onUseEnglishPress: (Boolean) -&gt; Unit, onSetupLanguagePress: () -&gt; Unit, hideLauncherIconClick: (Boolean) -&gt; Unit, showCheckmarksOnSwitches: (Boolean) -&gt; Unit, customizeColors: () -&gt; Unit, goBack: () -&gt; Unit, )</ID>
14-
<ID>MaxLineLength:MainActivity.kt$MainActivity$private</ID>
15-
<ID>MaxLineLength:MainScreen.kt$ActionItem(R.string.settings, icon = Icons.Filled.Settings, doAction = openSettings, overflowMode = OverflowMode.NEVER_OVERFLOW)</ID>
16-
<ID>MaxLineLength:MainScreen.kt$ActionMenu(items = actionMenus, numIcons = 2, isMenuVisible = isMenuVisible, onMenuToggle = { isMenuVisible = it }, iconsColor = scrolledColor)</ID>
17-
<ID>MaxLineLength:MainScreen.kt$MainScreen(showMoreApps = true, openSettings = {}, openAbout = {}, moreAppsFromUs = {}, linkColor = SimpleTheme.colorScheme.onSurface)</ID>
18-
<ID>MaxLineLength:MainScreen.kt$SimpleScaffold</ID>
19-
<ID>MaxLineLength:MainScreen.kt$listOf(settings, about, ActionItem(R.string.more_apps_from_us, doAction = moreAppsFromUs, overflowMode = OverflowMode.ALWAYS_OVERFLOW))</ID>
20-
<ID>MaxLineLength:MainScreen.kt$val about = ActionItem(R.string.about, icon = Icons.Outlined.Info, doAction = openAbout, overflowMode = OverflowMode.NEVER_OVERFLOW)</ID>
18+
<ID>FunctionNaming:SettingsScreen.kt$@Composable internal fun SettingsScreen( displayLanguage: String, isUseEnglishEnabled: Boolean, isUseEnglishChecked: Boolean, isShowingCheckmarksOnSwitches: Boolean, onUseEnglishPress: (Boolean) -&gt; Unit, onSetupLanguagePress: () -&gt; Unit, showCheckmarksOnSwitches: (Boolean) -&gt; Unit, customizeColors: () -&gt; Unit, goBack: () -&gt; Unit, )</ID>
19+
<ID>LongMethod:MainScreen.kt$@Composable internal fun MainScreen( allApps: List&lt;FossifyApp&gt;, fakeApps: List&lt;FossifyApp&gt;, showGoogleRelations: Boolean, showThankYouNotice: Boolean, openSettings: () -&gt; Unit, openAbout: () -&gt; Unit, moreAppsFromUs: () -&gt; Unit, launchApp: (packageName: String) -&gt; Unit, uninstallApp: (packageName: String) -&gt; Unit, hideThankYouNotice: () -&gt; Unit, onDonateClicked: () -&gt; Unit, linkColor: Color, )</ID>
20+
<ID>LongParameterList:Context.kt$( appNameId: Int, licenseMask: Long, versionName: String, packageName: String, repositoryName: String, faqItems: ArrayList&lt;FAQItem&gt;, showFAQBeforeMail: Boolean, getAppIconIDs: ArrayList&lt;Int&gt; = getAppIconIDs(), getAppLauncherName: String = launcherName() )</ID>
21+
<ID>LongParameterList:MainScreen.kt$( allApps: List&lt;FossifyApp&gt;, fakeApps: List&lt;FossifyApp&gt;, showGoogleRelations: Boolean, showThankYouNotice: Boolean, openSettings: () -&gt; Unit, openAbout: () -&gt; Unit, moreAppsFromUs: () -&gt; Unit, launchApp: (packageName: String) -&gt; Unit, uninstallApp: (packageName: String) -&gt; Unit, hideThankYouNotice: () -&gt; Unit, onDonateClicked: () -&gt; Unit, linkColor: Color, )</ID>
22+
<ID>LongParameterList:SettingsScreen.kt$( displayLanguage: String, isUseEnglishEnabled: Boolean, isUseEnglishChecked: Boolean, isShowingCheckmarksOnSwitches: Boolean, onUseEnglishPress: (Boolean) -&gt; Unit, onSetupLanguagePress: () -&gt; Unit, showCheckmarksOnSwitches: (Boolean) -&gt; Unit, customizeColors: () -&gt; Unit, goBack: () -&gt; Unit, )</ID>
23+
<ID>MagicNumber:MainScreen.kt$10</ID>
24+
<ID>MaxLineLength:MainScreen.kt$customTopBar</ID>
2125
<ID>MaxLineLength:MyContentProvider.kt$MyContentProvider$override</ID>
22-
<ID>MaxLineLength:MyContentProviderHelper.kt$MyContentProviderHelper$class</ID>
23-
<ID>MaxLineLength:SettingsActivity.kt$SettingsActivity$val hideLauncherIconFlow by preferences.hideLauncherIconFlow.collectAsStateWithLifecycle(preferences.hideLauncherIcon)</ID>
24-
<ID>MaxLineLength:SettingsActivity.kt$SettingsActivity$val showCheckmarksOnSwitches by preferences.showCheckmarksOnSwitchesFlow.collectAsStateWithLifecycle(preferences.showCheckmarksOnSwitches)</ID>
25-
<ID>MaxLineLength:SettingsActivity.kt$SettingsActivity$val wasUseEnglishToggledFlow by preferences.wasUseEnglishToggledFlow.collectAsStateWithLifecycle(preferences.wasUseEnglishToggled)</ID>
26+
<ID>NewLineAtEndOfFile:Constants.kt$org.fossify.thankyou.helpers.Constants.kt</ID>
27+
<ID>NewLineAtEndOfFile:Flow.kt$org.fossify.thankyou.extensions.Flow.kt</ID>
28+
<ID>NewLineAtEndOfFile:FossifyApp.kt$org.fossify.thankyou.ui.components.FossifyApp.kt</ID>
29+
<ID>PrintStackTrace:Fossify.kt$e</ID>
30+
<ID>ReturnCount:Fossify.kt$fun PackageManager.getSignerName(packageName: String?): String?</ID>
2631
<ID>SwallowedException:Context.kt$e: Exception</ID>
2732
<ID>TooGenericExceptionCaught:Context.kt$e: Exception</ID>
28-
<ID>UnusedPrivateMember:MainScreen.kt$@Composable @MyDevices private fun MainScreenPreview()</ID>
33+
<ID>TooGenericExceptionCaught:Fossify.kt$e: Exception</ID>
34+
<ID>UnusedPrivateMember:FossifyApp.kt$@Preview @Composable private fun PreviewFossifyApp( @PreviewParameter(BooleanPreviewParameterProvider::class) verified: Boolean )</ID>
35+
<ID>UnusedPrivateMember:MainScreen.kt$@Composable @MyDevices private fun MainScreenPreview( @PreviewParameter(BooleanPreviewParameterProvider::class) showGoogleRelations: Boolean, )</ID>
2936
<ID>UnusedPrivateMember:SettingsScreen.kt$@Composable @MyDevices private fun SettingsScreenPreview()</ID>
30-
<ID>WildcardImport:Context.kt$import org.fossify.commons.helpers.*</ID>
31-
<ID>WildcardImport:MainActivity.kt$import androidx.compose.runtime.*</ID>
32-
<ID>WildcardImport:MainActivity.kt$import org.fossify.commons.compose.extensions.*</ID>
33-
<ID>WildcardImport:MainScreen.kt$import androidx.compose.runtime.*</ID>
34-
<ID>WildcardImport:SettingsScreen.kt$import org.fossify.commons.compose.settings.*</ID>
37+
<ID>VariableNaming:Fossify.kt$val `package` = it.packageName</ID>
3538
</CurrentIssues>
3639
</SmellBaseline>

0 commit comments

Comments
 (0)