Skip to content

Commit 1fa3bfe

Browse files
authored
fix: dont pack items together (#235)
1 parent d1a2495 commit 1fa3bfe

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

commons/src/main/res/layout/item_contact_with_number.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44
xmlns:tools="http://schemas.android.com/tools"
55
android:id="@+id/item_contact_frame"
66
android:layout_width="match_parent"
7-
android:layout_height="@dimen/two_line_list_item_min_height"
7+
android:layout_height="wrap_content"
88
android:layout_marginBottom="@dimen/tiny_margin"
99
android:background="@drawable/selector_clickable"
1010
android:clickable="true"
1111
android:focusable="true"
12+
android:minHeight="@dimen/two_line_list_item_min_height"
1213
android:paddingHorizontal="@dimen/list_item_padding_horizontal"
1314
android:paddingVertical="@dimen/list_item_padding_vertical">
1415

@@ -36,8 +37,6 @@
3637
app:layout_constraintEnd_toStartOf="@+id/drag_handle_icon"
3738
app:layout_constraintStart_toEndOf="@+id/item_contact_image"
3839
app:layout_constraintTop_toTopOf="parent"
39-
app:layout_constraintVertical_bias="0.5"
40-
app:layout_constraintVertical_chainStyle="packed"
4140
tools:text="John Doe" />
4241

4342
<TextView
@@ -52,7 +51,6 @@
5251
app:layout_constraintEnd_toStartOf="@+id/drag_handle_icon"
5352
app:layout_constraintStart_toEndOf="@+id/item_contact_image"
5453
app:layout_constraintTop_toBottomOf="@+id/item_contact_name"
55-
app:layout_constraintVertical_bias="0.5"
5654
tools:text="0123 456 789" />
5755

5856
<ImageView

commons/src/main/res/layout/item_contact_without_number.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44
xmlns:tools="http://schemas.android.com/tools"
55
android:id="@+id/item_contact_frame"
66
android:layout_width="match_parent"
7-
android:layout_height="@dimen/one_line_list_item_min_height"
7+
android:layout_height="wrap_content"
88
android:layout_marginBottom="@dimen/tiny_margin"
99
android:background="@drawable/selector_clickable"
1010
android:clickable="true"
1111
android:focusable="true"
12+
android:minHeight="@dimen/one_line_list_item_min_height"
1213
android:paddingHorizontal="@dimen/list_item_padding_horizontal"
1314
android:paddingVertical="@dimen/list_item_padding_vertical">
1415

0 commit comments

Comments
 (0)