fix!: convert compose properties to extension functions

Author: naveensingh

commons/src/main/kotlin/org/fossify/commons/compose/alert_dialog/AlertDialogsExtensions.kt

@@ -36,26 +36,26 @@ val dialogContainerColor
         }
     }
 
-val Modifier.dialogBackgroundShapeAndBorder: Modifier
-    @ReadOnlyComposable
-    @Composable get() = this
-        .fillMaxWidth()
-        .background(dialogContainerColor, dialogShape)
-        .dialogBorder
+@Composable
+@ReadOnlyComposable
+fun Modifier.dialogBackgroundShapeAndBorder(): Modifier = this
+    .fillMaxWidth()
+    .background(dialogContainerColor, dialogShape)
+    .dialogBorder()
 
 val dialogShape = Shapes.extraLarge
 
 val dialogElevation = 0.dp
 
 val dialogTextColor @Composable @ReadOnlyComposable get() = SimpleTheme.colorScheme.onSurface
 
-val Modifier.dialogBorder: Modifier
-    @ReadOnlyComposable
-    @Composable get() =
-        when (LocalTheme.current) {
-            is Theme.BlackAndWhite -> this.border(1.dp, light_grey_stroke, dialogShape)
-            else -> this
-        }
+@Composable
+@ReadOnlyComposable
+fun Modifier.dialogBorder(): Modifier =
+    when (LocalTheme.current) {
+        is Theme.BlackAndWhite -> this.border(1.dp, light_grey_stroke, dialogShape)
+        else -> this
+    }
 
 @Composable
 fun DialogSurface(
@@ -64,7 +64,7 @@ fun DialogSurface(
 ) {
     Surface(
         modifier = modifier
-            .dialogBorder,
+            .dialogBorder(),
         shape = dialogShape,
         color = dialogContainerColor,
         tonalElevation = dialogElevation,

commons/src/main/kotlin/org/fossify/commons/compose/bottom_sheet/BottomSheetDialogsExtensions.kt

@@ -22,13 +22,13 @@ val bottomSheetDialogShape = Shapes.extraLarge.copy(
     bottomStart = CornerSize(0f)
 )
 
-val Modifier.bottomSheetDialogBorder: Modifier
-    @ReadOnlyComposable
-    @Composable get() =
-        when (LocalTheme.current) {
-            is Theme.BlackAndWhite -> this.border(2.dp, light_grey_stroke, bottomSheetDialogShape)
-            else -> this
-        }
+@Composable
+@ReadOnlyComposable
+fun Modifier.bottomSheetDialogBorder(): Modifier =
+    when (LocalTheme.current) {
+        is Theme.BlackAndWhite -> this.border(2.dp, light_grey_stroke, bottomSheetDialogShape)
+        else -> this
+    }
 
 @Composable
 fun BottomSheetSpacerEdgeToEdge() {
@@ -43,7 +43,7 @@ fun BottomSheetColumnDialogSurface(
     Surface(
         modifier = modifier
             .fillMaxSize()
-            .bottomSheetDialogBorder,
+            .bottomSheetDialogBorder(),
         shape = bottomSheetDialogShape,
         color = dialogContainerColor,
         tonalElevation = dialogElevation,
@@ -62,7 +62,7 @@ fun BottomSheetBoxDialogSurface(
     Surface(
         modifier = modifier
             .fillMaxSize()
-            .bottomSheetDialogBorder,
+            .bottomSheetDialogBorder(),
         shape = bottomSheetDialogShape,
         color = dialogContainerColor,
         tonalElevation = dialogElevation,
@@ -81,7 +81,7 @@ fun BottomSheetDialogSurface(
     Surface(
         modifier = modifier
             .fillMaxSize()
-            .bottomSheetDialogBorder,
+            .bottomSheetDialogBorder(),
         shape = bottomSheetDialogShape,
         color = dialogContainerColor,
         tonalElevation = dialogElevation,

commons/src/main/kotlin/org/fossify/commons/compose/menus/ActionMenu.kt

@@ -144,7 +144,7 @@ fun ActionMenu(
         DropdownMenu(
             modifier = Modifier
                 .background(dialogContainerColor)
-                .dialogBorder,
+                .dialogBorder(),
             expanded = isMenuVisible,
             onDismissRequest = { onMenuToggle(false) },
         ) {

commons/src/main/kotlin/org/fossify/commons/dialogs/AddBlockedNumberDialog.kt

@@ -42,7 +42,7 @@ fun AddOrEditBlockedNumberAlertDialog(
     AlertDialog(
         containerColor = dialogContainerColor,
         modifier = modifier
-            .dialogBorder,
+            .dialogBorder(),
         onDismissRequest = alertDialogState::hide,
         confirmButton = {
             TextButton(onClick = {

commons/src/main/kotlin/org/fossify/commons/dialogs/AppSideloadedDialog.kt

@@ -70,7 +70,7 @@ fun AppSideLoadedAlertDialog(
     AlertDialog(
         containerColor = dialogContainerColor,
         modifier = modifier
-            .dialogBorder,
+            .dialogBorder(),
         onDismissRequest = alertDialogState::hide,
         confirmButton = {
             TextButton(onClick = {

commons/src/main/kotlin/org/fossify/commons/dialogs/CallConfirmationDialog.kt

@@ -68,7 +68,7 @@ fun CallConfirmationAlertDialog(
     androidx.compose.material3.AlertDialog(
         containerColor = dialogContainerColor,
         modifier = modifier
-            .dialogBorder,
+            .dialogBorder(),
         onDismissRequest = {
             alertDialogState.hide()
             callback()

commons/src/main/kotlin/org/fossify/commons/dialogs/ColorPickerDialog.kt

@@ -159,7 +159,7 @@ fun ColorPickerAlertDialog(
 
     AlertDialog(
         modifier = modifier
-            .dialogBorder,
+            .dialogBorder(),
         onDismissRequest = alertDialogState::hide,
         properties = DialogProperties(usePlatformDefaultWidth = false)
     ) {

commons/src/main/kotlin/org/fossify/commons/dialogs/ConfirmationAdvancedDialog.kt

@@ -73,7 +73,7 @@ fun ConfirmationAdvancedAlertDialog(
     androidx.compose.material3.AlertDialog(
         containerColor = dialogContainerColor,
         modifier = modifier
-            .dialogBorder,
+            .dialogBorder(),
         properties = DialogProperties(dismissOnClickOutside = cancelOnTouchOutside),
         onDismissRequest = {
             alertDialogState.hide()

commons/src/main/kotlin/org/fossify/commons/dialogs/ConfirmationDialog.kt

@@ -80,7 +80,7 @@ fun ConfirmationAlertDialog(
     androidx.compose.material3.AlertDialog(
         containerColor = dialogContainerColor,
         modifier = modifier
-            .dialogBorder,
+            .dialogBorder(),
         properties = DialogProperties(dismissOnClickOutside = cancelOnTouchOutside),
         onDismissRequest = {
             alertDialogState.hide()

commons/src/main/kotlin/org/fossify/commons/dialogs/CreateNewFolderDialog.kt

@@ -118,7 +118,7 @@ fun CreateNewFolderAlertDialog(
     var title by remember { mutableStateOf("") }
 
     AlertDialog(
-        modifier = modifier.dialogBorder,
+        modifier = modifier.dialogBorder(),
         shape = dialogShape,
         containerColor = dialogContainerColor,
         tonalElevation = dialogElevation,