Skip to content

Conversation

@miapuffia
Copy link
Contributor

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added an extension function to format seconds to abbreviated time string

Fixes the following issue(s)

Acknowledgement

@miapuffia
Copy link
Contributor Author

If the changes to strings looks good I can go through and add translations based on existing strings/other library's translations

@naveensingh naveensingh self-assigned this Mar 26, 2025
@miapuffia
Copy link
Contributor Author

I thought it looked a little off, it was the commas!

@naveensingh
Copy link
Member

If the changes to strings looks good I can go through and add translations based on existing strings/other library's translations

Looking at the commit history, it looks like the original strings were added for this exact purpose (call duration) but never used.

I'm thinking it would be easier to just add the format specifier to the original strings using "Replace all" feature in your IDE.

@miapuffia
Copy link
Contributor Author

I'm thinking it would be easier to just add the format specifier to the original strings using "Replace all" feature in your IDE.

As in, replace <string name="seconds_letter">s</string> with <string name="seconds_letter">%ds</string>?

@naveensingh
Copy link
Member

Yes but not exactly as that would replace the localized versions with English.

image

@miapuffia
Copy link
Contributor Author

Now what should be done with localizing day_letter?

@naveensingh
Copy link
Member

We'll leave that to the (good) people translating via Weblate: https://hosted.weblate.org/projects/fossify/commons/

@naveensingh
Copy link
Member

Not sure if there should be a space between number and text in some of those non-latin scripts but I guess we'll see.

Thank you!

@naveensingh naveensingh merged commit 5c9248f into FossifyOrg:master Mar 26, 2025
2 of 4 checks passed
@miapuffia miapuffia deleted the add-localized-duration-extension branch March 26, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display call durations in a human-readable way

2 participants