-
-
Notifications
You must be signed in to change notification settings - Fork 59
Added extension to format seconds to short time #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extension to format seconds to short time #85
Conversation
|
If the changes to strings looks good I can go through and add translations based on existing strings/other library's translations |
commons/src/main/kotlin/org/fossify/commons/extensions/Context.kt
Outdated
Show resolved
Hide resolved
commons/src/main/kotlin/org/fossify/commons/extensions/Context.kt
Outdated
Show resolved
Hide resolved
commons/src/main/kotlin/org/fossify/commons/extensions/Context.kt
Outdated
Show resolved
Hide resolved
commons/src/main/kotlin/org/fossify/commons/extensions/Context.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Naveen Singh <[email protected]>
Co-authored-by: Naveen Singh <[email protected]>
Co-authored-by: Naveen Singh <[email protected]>
Co-authored-by: Naveen Singh <[email protected]>
|
I thought it looked a little off, it was the commas! |
Looking at the commit history, it looks like the original strings were added for this exact purpose (call duration) but never used. I'm thinking it would be easier to just add the format specifier to the original strings using "Replace all" feature in your IDE. |
As in, replace |
|
Now what should be done with localizing day_letter? |
|
We'll leave that to the (good) people translating via Weblate: https://hosted.weblate.org/projects/fossify/commons/ |
|
Not sure if there should be a space between number and text in some of those non-latin scripts but I guess we'll see. Thank you! |

What is it?
Description of the changes in your PR
Fixes the following issue(s)
Acknowledgement