fix: Prevent exception when attempting to access a custom line item's purchasable

Author: johnnynotsolucky

composer.json

@@ -11,7 +11,7 @@
 	"require": {
 		"php": "^8.2",
 		"craftcms/cms": "^5.0.0",
-		"klaviyo/api": "^7.1"
+		"klaviyo/api": "^14.0.0"
 	},
 	"autoload": {
 		"psr-4": {

src/services/Track.php

@@ -4,9 +4,11 @@
 
 use Craft;
 use craft\commerce\elements\Order;
+use craft\commerce\enums\LineItemType;
 use craft\commerce\events\OrderStatusEvent;
 use craft\commerce\events\RefundTransactionEvent;
 use craft\commerce\events\TransactionEvent;
+use craft\commerce\models\LineItem;
 use craft\elements\Address;
 use craft\helpers\ArrayHelper;
 use DateTime;
@@ -285,54 +287,16 @@ protected function createProfile(array $profile, ?string $eventName = null, mixe
 
 	protected function getOrderDetails(Order $order, string $event = ''): array
 	{
-		/** @var Settings $settings */
-		$settings = Plugin::getInstance()->getSettings();
-
 		$lineItemsProperties = [];
 
 		foreach ($order->lineItems as $lineItem) {
-			$lineItemProperties = [];
-
-			// Add regular Product purchasable properties
-			$product = $lineItem->purchasable->product ?? [];
-			if ($product) {
-				$lineItemProperties = [
-					'value' => $lineItem->price * $lineItem->qty,
-					'ProductName' => $product->title,
-					'Slug' => $product->slug,
-					'ProductURL' => $product->getUrl(),
-					'ProductType' => $product->type->name,
-					'ItemPrice' => $lineItem->price,
-					'RowTotal' => $lineItem->subtotal,
-					'Quantity' => $lineItem->qty,
-					'SKU' => $lineItem->purchasable->sku,
-					'Options' => $lineItem->getOptions(),
-					'Adjustments' => collect($lineItem->getAdjustments())
-						->flatMap(static fn ($adjustment) => [
-							$adjustment->name => $adjustment->amountAsCurrency,
-						])
-						->toArray(),
-
-				];
-
-				$variant = $lineItem->purchasable;
-
-				$productImageField = $settings->productImageField;
-
-				if (isset($variant->{$productImageField}) && $variant->{$productImageField}->count()) {
-					if ($image = $variant->{$productImageField}->one()) {
-						$lineItemProperties['ImageURL'] = $image->getUrl($settings->productImageFieldTransformation, true);
-					}
-				} elseif (isset($product->{$productImageField}) && $product->{$productImageField}->count()) {
-					if ($image = $product->{$productImageField}->one()) {
-						$lineItemProperties['ImageURL'] = $image->getUrl($settings->productImageFieldTransformation, true);
-					}
-				}
+			if ($lineItem->type !== LineItemType::Custom) {
+				$lineItemProperties = $this->populateLineItemProperties($lineItem);
 			}
 
 			// Add any additional user-defined properties
 			$addLineItemCustomPropertiesEvent = new AddLineItemCustomPropertiesEvent([
-				'properties' => $lineItemProperties,
+				'properties' => $lineItemProperties ?? [],
 				'order' => $order,
 				'lineItem' => $lineItem,
 				'event' => $event,
@@ -361,6 +325,53 @@ protected function getOrderDetails(Order $order, string $event = ''): array
 		return $addOrderCustomPropertiesEvent->properties;
 	}
 
+	private function populateLineItemProperties(LineItem $lineItem): array
+	{
+		/** @var Settings $settings */
+		$settings = Plugin::getInstance()->getSettings();
+
+		$lineItemProperties = [];
+
+		// Add regular Product purchasable properties
+		$product = $lineItem->purchasable?->product ?? [];
+		if ($product !== []) {
+			$lineItemProperties = [
+				'value' => $lineItem->price * $lineItem->qty,
+				'ProductName' => $product->title,
+				'Slug' => $product->slug,
+				'ProductURL' => $product->getUrl(),
+				'ProductType' => $product->type->name,
+				'ItemPrice' => $lineItem->price,
+				'RowTotal' => $lineItem->subtotal,
+				'Quantity' => $lineItem->qty,
+				'SKU' => $lineItem->purchasable->sku,
+				'Options' => $lineItem->getOptions(),
+				'Adjustments' => collect($lineItem->getAdjustments())
+					->flatMap(static fn ($adjustment) => [
+						$adjustment->name => $adjustment->amountAsCurrency,
+					])
+					->toArray(),
+
+			];
+
+			$variant = $lineItem->purchasable;
+
+			$productImageField = $settings->productImageField;
+
+			if (isset($variant->{$productImageField}) && $variant->{$productImageField}->count()) {
+				if ($image = $variant->{$productImageField}->one()) {
+					$lineItemProperties['ImageURL'] = $image->getUrl($settings->productImageFieldTransformation, true);
+				}
+			} elseif (isset($product->{$productImageField}) && $product->{$productImageField}->count()) {
+				if ($image = $product->{$productImageField}->one()) {
+					$lineItemProperties['ImageURL'] = $image->getUrl($settings->productImageFieldTransformation, true);
+				}
+			}
+		}
+
+		return $lineItemProperties;
+	}
+
 	private function isInGroup(array $selectedGroups, array $userGroups): bool
 	{
 		$groupIds = ArrayHelper::getColumn($userGroups, 'id');