Address PR feedback: improve exception handling and use LINQ

- Add System.Linq import for LINQ extension methods
- Replace empty catch block with comment explaining expected cancellation
- Add exception filters to generic catch clauses to allow fatal exceptions
  (OutOfMemoryException, StackOverflowException) to propagate
- Replace generic catch blocks in DisposeAsync with specific exception types
  (SnsNotFoundException, QueueDoesNotExistException, AmazonServiceException)
- Refactor ValidateQueueName to use LINQ FirstOrDefault instead of foreach
- Refactor PolicyContainsStatement to use LINQ Any instead of foreach
- Replace inefficient ContainsKey + indexer with TryGetValue in tests

Author: niemyjski

src/Foundatio.AWS/Messaging/SQSMessageBus.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
+using System.Linq;
 using System.Text;
 using System.Text.Json.Nodes;
 using System.Threading;
@@ -398,7 +399,10 @@ protected override async Task RemoveTopicSubscriptionAsync()
                 {
                     await _subscriberTask.AnyContext();
                 }
-                catch (OperationCanceledException) { }
+                catch (OperationCanceledException)
+                {
+                    // Expected when the subscriber is canceled during shutdown
+                }
                 _subscriberTask = null;
             }
 
@@ -524,7 +528,6 @@ await _sqsClient.Value.DeleteMessageAsync(new DeleteMessageRequest
             catch (Exception ex)
             {
                 _logger.LogError(ex, "Error in subscriber loop: {Message}", ex.Message);
-
                 if (cancellationToken.IsCancellationRequested)
                     break;
 
@@ -700,7 +703,7 @@ public async ValueTask DisposeAsync()
             }
             catch (OperationCanceledException)
             {
-                // Ignored
+                // Expected when the subscriber is canceled during shutdown
             }
         }
 
@@ -712,9 +715,13 @@ public async ValueTask DisposeAsync()
             {
                 await _snsClient.Value.UnsubscribeAsync(_subscriptionArn).AnyContext();
             }
-            catch
+            catch (SnsNotFoundException)
+            {
+                // Subscription already deleted
+            }
+            catch (AmazonServiceException ex)
             {
-                // Ignored
+                _logger.LogDebug(ex, "Error unsubscribing from SNS topic during dispose");
             }
         }
 
@@ -724,9 +731,13 @@ public async ValueTask DisposeAsync()
             {
                 await _sqsClient.Value.DeleteQueueAsync(_queueUrl).AnyContext();
             }
-            catch
+            catch (QueueDoesNotExistException)
             {
-                // Ignored
+                // Queue already deleted
+            }
+            catch (AmazonServiceException ex)
+            {
+                _logger.LogDebug(ex, "Error deleting SQS queue during dispose");
             }
         }
 
@@ -764,11 +775,9 @@ private static void ValidateQueueName(string name, string parameterName)
         if (name.Length > 80)
             throw new ArgumentException($"Queue name must be 80 characters or less, got {name.Length} characters.", parameterName);
 
-        foreach (char c in name)
-        {
-            if (!Char.IsLetterOrDigit(c) && c != '-' && c != '_')
-                throw new ArgumentException($"Queue name contains invalid character '{c}'. Only alphanumeric characters, hyphens, and underscores are allowed.", parameterName);
-        }
+        char invalidChar = name.FirstOrDefault(c => !Char.IsLetterOrDigit(c) && c != '-' && c != '_');
+        if (invalidChar != default)
+            throw new ArgumentException($"Queue name contains invalid character '{invalidChar}'. Only alphanumeric characters, hyphens, and underscores are allowed.", parameterName);
     }
 
     /// <summary>
@@ -818,12 +827,7 @@ private static bool PolicyContainsStatement(string existingPolicy, string sid)
             if (statements is null)
                 return false;
 
-            foreach (var stmt in statements)
-            {
-                string stmtSid = stmt?.AsObject()?["Sid"]?.GetValue<string>();
-                if (stmtSid == sid)
-                    return true;
-            }
+            return statements.Any(stmt => stmt?.AsObject()?["Sid"]?.GetValue<string>() == sid);
         }
         catch
         {

tests/Foundatio.AWS.Tests/Messaging/SQSMessageBusTests.cs

@@ -454,9 +454,9 @@ await Parallel.ForEachAsync(
 
         // Assert - TopicResolver was called multiple times but topic should only be created once
         // The memoization in GetOrCreateTopicArnAsync ensures the actual AWS CreateTopic is called once
-        Assert.True(topicCreationCount.ContainsKey("routed-TopicAMessage"));
+        Assert.True(topicCreationCount.TryGetValue("routed-TopicAMessage", out int creationCount));
         // The resolver is called for each publish, but the underlying topic creation is memoized
-        Assert.True(topicCreationCount["routed-TopicAMessage"] >= 1);
+        Assert.True(creationCount >= 1);
     }
 
     [Fact]
@@ -483,8 +483,8 @@ public async Task PublishAsync_WithMultipleMessageTypes_MemoizesTopicArns()
         }
 
         // Assert - Resolver was called for each publish
-        Assert.True(resolverCallCount.ContainsKey(typeof(TopicAMessage)));
-        Assert.Equal(5, resolverCallCount[typeof(TopicAMessage)]);
+        Assert.True(resolverCallCount.TryGetValue(typeof(TopicAMessage), out int callCount));
+        Assert.Equal(5, callCount);
         // The memoization happens at the topic ARN level, not the resolver level
         // This test verifies the resolver is called but the underlying topic creation is cached
     }