Various updates

Author: ejsmith

README.md

@@ -10,11 +10,11 @@ Foundatio.Mediator is a high-performance, convention-based mediator library that
 
 ## ✨ Why Choose Foundatio.Mediator?
 
-- **🚀 Blazing Fast** - Only 2x slower than direct method calls, 3x faster than MediatR
+- **🚀 Blazing Fast** - Nearly as fast as direct method calls, 3x faster than MediatR
 - **🎯 Convention-Based** - No interfaces or base classes required
 - **⚡ Source Generated** - Compile-time code generation for optimal performance
 - **🔧 Full DI Integration** - Works seamlessly with Microsoft.Extensions.DependencyInjection
-- **🎪 Middleware Pipeline** - Elegant middleware support with logging, timing, and custom logic
+- **🎪 Middleware Pipeline** - Elegant middleware support
 - **📦 Auto Registration** - Handlers discovered and registered automatically
 - **🔒 Compile-Time Safety** - Rich diagnostics catch errors before runtime
 - **🔧 C# Interceptors** - Direct method calls using cutting-edge C# interceptor technology
@@ -67,7 +67,7 @@ var mediator = serviceProvider.GetRequiredService<IMediator>();
 await mediator.InvokeAsync(new PingCommand("123"));
 
 // Request/response
-var greeting = await mediator.InvokeAsync<string>(new GreetingQuery("World"));
+var greeting = mediator.Invoke<string>(new GreetingQuery("World"));
 Console.WriteLine(greeting); // "Hello, World!"
 ```
 
@@ -107,30 +107,21 @@ public class LoggingMiddleware
     }
 }
 
-public class GlobalMiddleware
+public class ValidationMiddleware
 {
-    public (DateTime Date, TimeSpan Time) Before(object message, CancellationToken cancellationToken)
+    public HandlerResult Before(object message)
     {
-        Console.WriteLine($"🌍 Processing {message.GetType().Name}");
-        return (DateTime.UtcNow, DateTime.UtcNow.TimeOfDay);
-    }
-
-    public async Task After(object message, DateTime start, TimeSpan time,
-        IEmailService emailService, CancellationToken cancellationToken)
-    {
-        await emailService.SendEmailAsync("audit@company.com", "Message Processed",
-            $"Message {message.GetType().Name} processed at {start}");
-        Console.WriteLine($"🌍 Completed {message.GetType().Name}");
-    }
-
-    public void Finally(object message, Exception? exception, CancellationToken cancellationToken)
-    {
-        if (exception != null)
+        if (!TryValidate(message, out var errors))
         {
-            Console.WriteLine($"🌍 Error: {exception.Message}");
+            // If validation fails, short-circuit the handler execution
+            return HandlerResult.ShortCircuit(Result.Invalid(errors));
         }
+
+        return HandlerResult.Continue();
     }
 }
+
+var user = mediator.InvokeAsync<Result<User>>(new GetUserQuery(userId), cancellationToken);
 ```
 
 ## 💉 Dependency Injection Made Simple
@@ -274,12 +265,11 @@ dotnet run
 
 The source generator:
 
-1. **Discovers handlers** at compile time by scanning for classes ending with "Handler" or "Consumer"
-2. **Validates method signatures** to ensure they follow the conventions
+1. **Discovers handlers** at compile time by scanning for classes ending with `Handler` or `Consumer`
+2. **Discovers handler methods** looks for methods with names like `Handle`, `HandleAsync`, `Consume`, `ConsumeAsync`
+3. **Parameters** first parameter is the message, remaining parameters are injected via DI
 3. **Generates C# interceptors** for blazing fast same-assembly dispatch using direct method calls
-4. **Registers keyed handlers in DI** as fallback for cross-assembly scenarios and publish operations
-5. **Creates middleware pipelines** with proper before/after/finally execution order
-6. **Generates handler registrations** that span multiple projects for comprehensive handler discovery
+4. **Middleware** with can run `Before`, `After`, and `Finally` around handler execution and can be sync or async
 
 ### 🔧 C# Interceptors - The Secret Sauce
 

benchmarks/Foundatio.Mediator.Benchmarks/ThroughputBenchmarks.cs

@@ -98,7 +98,7 @@ public async Task FoundatioQueryThroughputAsync(int queryCount)
             var query = _greetingQueries[i % _greetingQueries.Length];
             tasks[i] = _foundatioMediator.InvokeAsync<string>(query).AsTask();
         }
-        var results = await Task.WhenAll(tasks);
+        string[] results = await Task.WhenAll(tasks);
     }
 
     [Benchmark]

samples/ConsoleSample/Handlers/CalculationHandlers.cs

@@ -7,7 +7,7 @@ public class SyncCalculationHandler
 {
     public string Handle(SyncCalculationQuery query)
     {
-        var result = query.A + query.B;
+        int result = query.A + query.B;
         Console.WriteLine($"🧮 Sync calculation: {query.A} + {query.B} = {result}");
         return $"Sum: {result}";
     }
@@ -18,7 +18,7 @@ public class AsyncCalculationHandler
     public async Task<string> HandleAsync(AsyncCalculationQuery query, CancellationToken cancellationToken = default)
     {
         await Task.Delay(50, cancellationToken); // Simulate async work
-        var result = query.A * query.B;
+        int result = query.A * query.B;
         Console.WriteLine($"🧮 Async calculation: {query.A} * {query.B} = {result}");
         return $"Product: {result}";
     }

samples/ConsoleSample/Handlers/DependencyInjectionHandlers.cs

@@ -13,7 +13,7 @@ public async Task HandleAsync(
         IGreetingService greetingService,
         CancellationToken cancellationToken = default)
     {
-        var greeting = greetingService.CreateGreeting(command.Name);
+        string greeting = greetingService.CreateGreeting(command.Name);
         await emailService.SendEmailAsync(
             command.Email, 
             "Welcome!", 

samples/ConsoleSample/Handlers/OrderHandlers.cs

@@ -8,7 +8,7 @@ public class OrderEmailNotificationHandler(EmailNotificationService emailService
 {
     public async Task HandleAsync(OrderCreatedEvent orderEvent)
     {
-        var message = $"Order {orderEvent.OrderId} has been created for ${orderEvent.Amount:F2}";
+        string message = $"Order {orderEvent.OrderId} has been created for ${orderEvent.Amount:F2}";
         await emailService.SendAsync(message);
     }
 }
@@ -20,7 +20,7 @@ public async Task HandleAsync(
         SmsNotificationService smsService,
         CancellationToken cancellationToken = default)
     {
-        var message = $"Your order {orderEvent.OrderId} is confirmed!";
+        string message = $"Your order {orderEvent.OrderId} is confirmed!";
         await smsService.SendAsync(message);
     }
 }

samples/ConsoleSample/Messages/ValidationMessages.cs

@@ -7,11 +7,11 @@ public class CreateUserCommand : ICommand
 {
     [Required(ErrorMessage = "Name is required")]
     [StringLength(50, MinimumLength = 2, ErrorMessage = "Name must be between 2 and 50 characters")]
-    public string Name { get; set; } = string.Empty;
+    public string Name { get; set; } = String.Empty;
 
     [Required(ErrorMessage = "Email is required")]
     [EmailAddress(ErrorMessage = "Invalid email format")]
-    public string Email { get; set; } = string.Empty;
+    public string Email { get; set; } = String.Empty;
 
     [Range(18, 120, ErrorMessage = "Age must be between 18 and 120")]
     public int Age { get; set; }
@@ -23,8 +23,8 @@ public class CreateUserCommand : ICommand
 public record User
 {
     public int Id { get; set; }
-    public string Name { get; set; } = string.Empty;
-    public string Email { get; set; } = string.Empty;
+    public string Name { get; set; } = String.Empty;
+    public string Email { get; set; } = String.Empty;
     public int Age { get; set; }
     public string? PhoneNumber { get; set; }
     public DateTime CreatedAt { get; set; }

samples/ConsoleSample/Middleware/GlobalMiddleware.cs

@@ -1,5 +1,3 @@
-using ConsoleSample.Services;
-
 namespace ConsoleSample.Middleware;
 
 public class GlobalMiddleware
@@ -10,12 +8,6 @@ public class GlobalMiddleware
         return (DateTime.UtcNow, DateTime.UtcNow.TimeOfDay);
     }
 
-    public async Task After(object message, DateTime start, TimeSpan time, IEmailService emailService, CancellationToken cancellationToken)
-    {
-        await emailService.SendEmailAsync("test@test.com", $"Hello", $"Message of type {message.GetType().Name} processed successfully at {DateTime.UtcNow}");
-        Console.WriteLine($"🌍 [GlobalMiddleware] After: Completed processing {message.GetType().Name} {start}");
-    }
-
     public void Finally(object message, Exception? exception, CancellationToken cancellationToken)
     {
         if (exception != null)

samples/ConsoleSample/Middleware/ProcessOrderMiddleware.cs

@@ -10,7 +10,7 @@ public Task<HandlerResult> BeforeAsync(ProcessOrderCommand command, Cancellation
         Console.WriteLine($"🔸 [ProcessOrderMiddleware] Before: Processing order {command.OrderId} with type {command.ProcessingType}");
 
         // Add some validation logic
-        if (string.IsNullOrWhiteSpace(command.OrderId))
+        if (String.IsNullOrWhiteSpace(command.OrderId))
         {
             Console.WriteLine($"🔸 [ProcessOrderMiddleware] Invalid order ID, short-circuiting");
             return Task.FromResult(HandlerResult.ShortCircuit("Invalid order ID"));

samples/ConsoleSample/Middleware/ValidationMiddleware.cs

@@ -3,27 +3,13 @@
 
 namespace ConsoleSample.Middleware;
 
-/// <summary>
-/// Validation middleware that uses MiniValidator to validate message models before handler execution.
-/// If validation fails, it short-circuits and returns validation errors as a Result.
-/// </summary>
 public class ValidationMiddleware
 {
-    /// <summary>
-    /// Validates the message before handler execution. If validation fails, returns a short-circuit result.
-    /// </summary>
-    /// <param name="message">The message to validate.</param>
-    /// <returns>A HandlerResult that either continues or short-circuits with validation errors.</returns>
     public HandlerResult Before(object message)
     {
-        if (!MiniValidator.TryValidate(message, out var errors))
+        if (!TryValidate(message, out var errors))
         {
-            // Convert MiniValidator errors to Foundatio.Mediator ValidationErrors
-            var validationErrors = errors.SelectMany(kvp =>
-                kvp.Value.Select(errorMessage =>
-                    new ValidationError(kvp.Key, errorMessage))).ToList();
-
-            return HandlerResult.ShortCircuit(Result.Invalid(validationErrors));
+            return HandlerResult.ShortCircuit(Result.Invalid(errors));
         }
 
         return HandlerResult.Continue();

samples/ConsoleSample/Properties/launchSettings.json

@@ -0,0 +1,11 @@
+{
+  "$schema": "http://json.schemastore.org/launchsettings.json",
+  "profiles": {
+    "ConsoleSample": {
+      "commandName": "Project",
+      "environmentVariables": {
+        
+      }
+    }
+  }
+}