Passes TimeProvider to date setting extensions (#184)

Ensures that the `TimeProvider` is passed to the
`SetDates` and `SetCreatedDates` extension methods.

This ensures that mocked time providers are correctly
respected when setting the created and updated dates
on entities, which is crucial for testing time-dependent
logic.

Adds tests to verify the correct behavior with mocked
time providers, including future-dated scenarios.

Author: niemyjski

src/Foundatio.Repositories.Elasticsearch/Repositories/ElasticRepositoryBase.cs

@@ -1154,9 +1154,9 @@ protected virtual string GetTenantKey(IRepositoryQuery query)
     private async Task OnDocumentsAddingAsync(IReadOnlyCollection<T> documents, ICommandOptions options)
     {
         if (HasDates)
-            documents.OfType<IHaveDates>().SetDates();
+            documents.OfType<IHaveDates>().SetDates(ElasticIndex.Configuration.TimeProvider);
         else if (HasCreatedDate)
-            documents.OfType<IHaveCreatedDate>().SetCreatedDates();
+            documents.OfType<IHaveCreatedDate>().SetCreatedDates(ElasticIndex.Configuration.TimeProvider);
 
         if (DocumentsAdding != null && DocumentsAdding.HasHandlers)
             await DocumentsAdding.InvokeAsync(this, new DocumentsEventArgs<T>(documents, this, options)).AnyContext();
@@ -1186,7 +1186,7 @@ private async Task OnDocumentsSavingAsync(IReadOnlyCollection<T> documents, IRea
             return;
 
         if (HasDates)
-            documents.Cast<IHaveDates>().SetDates();
+            documents.Cast<IHaveDates>().SetDates(ElasticIndex.Configuration.TimeProvider);
 
         documents.EnsureIds(ElasticIndex.CreateDocumentId, ElasticIndex.Configuration.TimeProvider);
 

tests/Foundatio.Repositories.Elasticsearch.Tests/RepositoryTests.cs

@@ -642,26 +642,78 @@ public async Task SaveCollectionWithCachingAsync()
     }
 
     [Fact]
-    public async Task SetCreatedAndModifiedTimesAsync()
+    public async Task AddAsync_WithMockedTimeProvider_ShouldSetExactTimes()
     {
         var timeProvider = new FakeTimeProvider(DateTimeOffset.UtcNow.Subtract(TimeSpan.FromMilliseconds(100)));
         _configuration.TimeProvider = timeProvider;
 
-        var nowUtc = timeProvider.GetUtcNow().UtcDateTime;
+        var expectedTime = timeProvider.GetUtcNow().UtcDateTime;
         var employee = await _employeeRepository.AddAsync(EmployeeGenerator.Default);
-        Assert.True(employee.CreatedUtc >= nowUtc);
-        Assert.True(employee.UpdatedUtc >= nowUtc);
+
+        Assert.Equal(expectedTime, employee.CreatedUtc);
+        Assert.Equal(expectedTime, employee.UpdatedUtc);
 
         var createdUtc = employee.CreatedUtc;
         var updatedUtc = employee.UpdatedUtc;
-
         employee.Name = Guid.NewGuid().ToString();
         timeProvider.Advance(TimeSpan.FromMilliseconds(100));
+        var updatedExpectedTime = timeProvider.GetUtcNow().UtcDateTime;
+
         employee = await _employeeRepository.SaveAsync(employee);
+
         Assert.Equal(createdUtc, employee.CreatedUtc);
+        Assert.Equal(updatedExpectedTime, employee.UpdatedUtc);
         Assert.True(updatedUtc < employee.UpdatedUtc, $"Previous UpdatedUtc: {updatedUtc} Current UpdatedUtc: {employee.UpdatedUtc}");
     }
 
+    [Fact]
+    public async Task AddAsync_WithFutureMockedTimeProvider_ShouldRespectMockedTime()
+    {
+        // Arrange
+        var futureTime = new DateTimeOffset(2030, 1, 15, 12, 0, 0, TimeSpan.Zero);
+        var timeProvider = new FakeTimeProvider(futureTime);
+        _configuration.TimeProvider = timeProvider;
+
+        // Act
+        var expectedTime = timeProvider.GetUtcNow().UtcDateTime;
+        var employee = await _employeeRepository.AddAsync(EmployeeGenerator.Default);
+
+        // Assert
+        // These assertions will fail if SetDates/SetCreatedDates doesn't receive the TimeProvider
+        // because the extension methods default to TimeProvider.System and will see the future
+        // date as "in the future" and overwrite it with the real system time
+        Assert.Equal(expectedTime, employee.CreatedUtc);
+        Assert.Equal(expectedTime, employee.UpdatedUtc);
+    }
+
+    [Fact]
+    public async Task SaveAsync_WithFutureMockedTimeProvider_ShouldRespectMockedTime()
+    {
+        // Arrange
+        var futureTime = new DateTimeOffset(2030, 1, 15, 12, 0, 0, TimeSpan.Zero);
+        var timeProvider = new FakeTimeProvider(futureTime);
+        _configuration.TimeProvider = timeProvider;
+
+        var expectedTime = timeProvider.GetUtcNow().UtcDateTime;
+        var employee = await _employeeRepository.AddAsync(EmployeeGenerator.Default);
+
+        Assert.Equal(expectedTime, employee.CreatedUtc);
+        Assert.Equal(expectedTime, employee.UpdatedUtc);
+
+        var createdUtc = employee.CreatedUtc;
+        employee.Name = Guid.NewGuid().ToString();
+        timeProvider.Advance(TimeSpan.FromHours(1));
+        var updatedExpectedTime = timeProvider.GetUtcNow().UtcDateTime;
+
+        // Act
+        employee = await _employeeRepository.SaveAsync(employee);
+
+        // Assert
+        // CreatedUtc should remain unchanged, UpdatedUtc should reflect the advanced time
+        Assert.Equal(createdUtc, employee.CreatedUtc);
+        Assert.Equal(updatedExpectedTime, employee.UpdatedUtc);
+    }
+
     [Fact]
     public async Task CannotSetFutureCreatedAndModifiedTimesAsync()
     {