reduce to fastcloner vs deepcloner

Author: lofcz

benchmarks/DeepCloneBenchmarks.cs

@@ -3,7 +3,6 @@
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Configs;
 using BenchmarkDotNet.Order;
-using Foundatio.Utility;
 using DeepClonerExt = Foundatio.Force.DeepCloner.DeepClonerExtensions;
 using FastClonerExt = Foundatio.Utility.ObjectExtensions;
 
@@ -24,54 +23,35 @@ namespace Foundatio.Benchmarks;
 [CategoriesColumn]
 public class DeepCloneBenchmarks
 {
-    // Small objects - typical cache entries
     private SmallObject _smallObject;
     private SmallObjectWithCollections _smallObjectWithCollections;
-
-    // Medium objects - typical queue messages
     private MediumNestedObject _mediumNestedObject;
     private FileSpec _fileSpec;
-
-    // Large objects - ~10MB realistic data
     private LargeEventDocument _largeEventDocument;
     private LargeLogBatch _largeLogBatch;
-
-    // Dynamic type objects - object properties with various runtime types
     private ObjectWithDynamicProperties _dynamicWithDictionary;
     private ObjectWithDynamicProperties _dynamicWithNestedObject;
     private ObjectWithDynamicProperties _dynamicWithArray;
-
-    // Arrays and collections
     private string[] _stringArray;
     private List<MediumNestedObject> _objectList;
     private Dictionary<string, LargeEventDocument> _objectDictionary;
 
-    // Seed for deterministic data generation
     private const int Seed = 42;
 
     [GlobalSetup]
     public void Setup()
     {
         var random = new Random(Seed);
 
-        // Small objects
         _smallObject = CreateSmallObject(random);
         _smallObjectWithCollections = CreateSmallObjectWithCollections(random);
-
-        // Medium objects
         _mediumNestedObject = CreateMediumNestedObject(random);
         _fileSpec = CreateFileSpec(random);
-
-        // Large objects (~10MB each)
         _largeEventDocument = CreateLargeEventDocument(random, targetSizeBytes: 10 * 1024 * 1024);
         _largeLogBatch = CreateLargeLogBatch(random, targetSizeBytes: 10 * 1024 * 1024);
-
-        // Dynamic type objects
         _dynamicWithDictionary = CreateDynamicWithDictionary(random);
         _dynamicWithNestedObject = CreateDynamicWithNestedObject(random);
         _dynamicWithArray = CreateDynamicWithArray(random);
-
-        // Arrays and collections
         _stringArray = CreateStringArray(random, 1000);
         _objectList = CreateObjectList(random, 100);
         _objectDictionary = CreateObjectDictionary(random, 50);
@@ -86,10 +66,6 @@ public void Setup()
     [BenchmarkCategory("SmallObject")]
     public SmallObject FastCloner_SmallObject() => FastClonerExt.DeepClone(_smallObject);
 
-    [Benchmark]
-    [BenchmarkCategory("SmallObject")]
-    public SmallObject FastClonerGenerated_SmallObject() => FastClonerExt.DeepCloneGenerated(_smallObject);
-
     // ========== SmallObjectWithCollections ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("SmallObjectWithCollections")]
@@ -99,10 +75,6 @@ public void Setup()
     [BenchmarkCategory("SmallObjectWithCollections")]
     public SmallObjectWithCollections FastCloner_SmallObjectWithCollections() => FastClonerExt.DeepClone(_smallObjectWithCollections);
 
-    [Benchmark]
-    [BenchmarkCategory("SmallObjectWithCollections")]
-    public SmallObjectWithCollections FastClonerGenerated_SmallObjectWithCollections() => FastClonerExt.DeepCloneGenerated(_smallObjectWithCollections);
-
     // ========== MediumNestedObject ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("MediumNestedObject")]
@@ -112,10 +84,6 @@ public void Setup()
     [BenchmarkCategory("MediumNestedObject")]
     public MediumNestedObject FastCloner_MediumNestedObject() => FastClonerExt.DeepClone(_mediumNestedObject);
 
-    [Benchmark]
-    [BenchmarkCategory("MediumNestedObject")]
-    public MediumNestedObject FastClonerGenerated_MediumNestedObject() => FastClonerExt.DeepCloneGenerated(_mediumNestedObject);
-
     // ========== FileSpec ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("FileSpec")]
@@ -125,10 +93,6 @@ public void Setup()
     [BenchmarkCategory("FileSpec")]
     public FileSpec FastCloner_FileSpec() => FastClonerExt.DeepClone(_fileSpec);
 
-    [Benchmark]
-    [BenchmarkCategory("FileSpec")]
-    public FileSpec FastClonerGenerated_FileSpec() => FastClonerExt.DeepCloneGenerated(_fileSpec);
-
     // ========== LargeEventDocument_10MB ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("LargeEventDocument")]
@@ -138,10 +102,6 @@ public void Setup()
     [BenchmarkCategory("LargeEventDocument")]
     public LargeEventDocument FastCloner_LargeEventDocument_10MB() => FastClonerExt.DeepClone(_largeEventDocument);
 
-    [Benchmark]
-    [BenchmarkCategory("LargeEventDocument")]
-    public LargeEventDocument FastClonerGenerated_LargeEventDocument_10MB() => FastClonerExt.DeepCloneGenerated(_largeEventDocument);
-
     // ========== LargeLogBatch_10MB ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("LargeLogBatch")]
@@ -151,10 +111,6 @@ public void Setup()
     [BenchmarkCategory("LargeLogBatch")]
     public LargeLogBatch FastCloner_LargeLogBatch_10MB() => FastClonerExt.DeepClone(_largeLogBatch);
 
-    [Benchmark]
-    [BenchmarkCategory("LargeLogBatch")]
-    public LargeLogBatch FastClonerGenerated_LargeLogBatch_10MB() => FastClonerExt.DeepCloneGenerated(_largeLogBatch);
-
     // ========== DynamicWithDictionary ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("DynamicWithDictionary")]
@@ -164,10 +120,6 @@ public void Setup()
     [BenchmarkCategory("DynamicWithDictionary")]
     public ObjectWithDynamicProperties FastCloner_DynamicWithDictionary() => FastClonerExt.DeepClone(_dynamicWithDictionary);
 
-    [Benchmark]
-    [BenchmarkCategory("DynamicWithDictionary")]
-    public ObjectWithDynamicProperties FastClonerGenerated_DynamicWithDictionary() => FastClonerExt.DeepCloneGenerated(_dynamicWithDictionary);
-
     // ========== DynamicWithNestedObject ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("DynamicWithNestedObject")]
@@ -177,10 +129,6 @@ public void Setup()
     [BenchmarkCategory("DynamicWithNestedObject")]
     public ObjectWithDynamicProperties FastCloner_DynamicWithNestedObject() => FastClonerExt.DeepClone(_dynamicWithNestedObject);
 
-    [Benchmark]
-    [BenchmarkCategory("DynamicWithNestedObject")]
-    public ObjectWithDynamicProperties FastClonerGenerated_DynamicWithNestedObject() => FastClonerExt.DeepCloneGenerated(_dynamicWithNestedObject);
-
     // ========== DynamicWithArray ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("DynamicWithArray")]
@@ -190,10 +138,6 @@ public void Setup()
     [BenchmarkCategory("DynamicWithArray")]
     public ObjectWithDynamicProperties FastCloner_DynamicWithArray() => FastClonerExt.DeepClone(_dynamicWithArray);
 
-    [Benchmark]
-    [BenchmarkCategory("DynamicWithArray")]
-    public ObjectWithDynamicProperties FastClonerGenerated_DynamicWithArray() => FastClonerExt.DeepCloneGenerated(_dynamicWithArray);
-
     // ========== StringArray_1000 ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("StringArray")]
@@ -203,10 +147,6 @@ public void Setup()
     [BenchmarkCategory("StringArray")]
     public string[] FastCloner_StringArray_1000() => FastClonerExt.DeepClone(_stringArray);
 
-    [Benchmark]
-    [BenchmarkCategory("StringArray")]
-    public string[] FastClonerGenerated_StringArray_1000() => FastClonerExt.DeepCloneGenerated(_stringArray);
-
     // ========== ObjectList_100 ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("ObjectList")]
@@ -216,10 +156,6 @@ public void Setup()
     [BenchmarkCategory("ObjectList")]
     public List<MediumNestedObject> FastCloner_ObjectList_100() => FastClonerExt.DeepClone(_objectList);
 
-    [Benchmark]
-    [BenchmarkCategory("ObjectList")]
-    public List<MediumNestedObject> FastClonerGenerated_ObjectList_100() => FastClonerExt.DeepCloneGenerated(_objectList);
-
     // ========== ObjectDictionary_50 ==========
     [Benchmark(Baseline = true)]
     [BenchmarkCategory("ObjectDictionary")]
@@ -229,10 +165,6 @@ public void Setup()
     [BenchmarkCategory("ObjectDictionary")]
     public Dictionary<string, LargeEventDocument> FastCloner_ObjectDictionary_50() => FastClonerExt.DeepClone(_objectDictionary);
 
-    [Benchmark]
-    [BenchmarkCategory("ObjectDictionary")]
-    public Dictionary<string, LargeEventDocument> FastClonerGenerated_ObjectDictionary_50() => FastClonerExt.DeepCloneGenerated(_objectDictionary);
-
     private static SmallObject CreateSmallObject(Random random)
     {
         return new SmallObject
@@ -301,14 +233,8 @@ private static FileSpec CreateFileSpec(Random random)
 
     private static LargeEventDocument CreateLargeEventDocument(Random random, int targetSizeBytes)
     {
-        // For 10MB target: Create extended data entries with large strings
-        // Each char in .NET is 2 bytes, plus string object overhead (~26 bytes)
-        // We want the cloned object to be ~10MB
-
         var stackFrameCount = 100;
         var extendedDataCount = 200;
-        // Calculate string length to achieve target size
-        // Each string entry: ~50KB of chars = 25K chars
         var extendedDataStringLength = Math.Max(100, targetSizeBytes / extendedDataCount / 2);
 
         var stackFrames = new List<StackFrameInfo>(stackFrameCount);
@@ -389,8 +315,6 @@ private static LargeEventDocument CreateLargeEventDocument(Random random, int ta
 
     private static LargeLogBatch CreateLargeLogBatch(Random random, int targetSizeBytes)
     {
-        // Each log entry is roughly 2000-5000 bytes
-        // Target ~10MB total
         var entryCount = targetSizeBytes / 3000;
 
         var entries = new List<LogEntry>(entryCount);
@@ -497,15 +421,13 @@ private static Dictionary<string, LargeEventDocument> CreateObjectDictionary(Ran
         var dict = new Dictionary<string, LargeEventDocument>(count);
         for (int i = 0; i < count; i++)
         {
-            // Create medium-sized event documents for the dictionary (~10KB each)
             dict[$"event_{i}"] = CreateMediumEventDocument(random);
         }
         return dict;
     }
 
     private static LargeEventDocument CreateMediumEventDocument(Random random)
     {
-        // Create a medium-sized event document (~10KB) for collection benchmarks
         var stackFrames = new List<StackFrameInfo>(5);
         for (int i = 0; i < 5; i++)
         {
@@ -614,9 +536,6 @@ private static Dictionary<string, string> GenerateStringDictionary(Random random
     }
 }
 
-/// <summary>
-/// Small object representing a typical cache entry.
-/// </summary>
 public class SmallObject
 {
     public int Id { get; set; }
@@ -626,9 +545,6 @@ public class SmallObject
     public double Score { get; set; }
 }
 
-/// <summary>
-/// Small object with collections - typical for configuration or metadata caching.
-/// </summary>
 public class SmallObjectWithCollections
 {
     public int Id { get; set; }
@@ -637,9 +553,6 @@ public class SmallObjectWithCollections
     public Dictionary<string, string> Metadata { get; set; }
 }
 
-/// <summary>
-/// Medium-sized nested object representing a typical queue message or event.
-/// </summary>
 public class MediumNestedObject
 {
     public Guid Id { get; set; }
@@ -654,9 +567,6 @@ public class MediumNestedObject
     public RequestInfo Request { get; set; }
 }
 
-/// <summary>
-/// File specification - used in InMemoryFileStorage.
-/// </summary>
 public class FileSpec
 {
     public string Path { get; set; }
@@ -666,9 +576,6 @@ public class FileSpec
     public Dictionary<string, string> Data { get; set; }
 }
 
-/// <summary>
-/// User information - common nested object in events.
-/// </summary>
 public class UserInfo
 {
     public string Id { get; set; }
@@ -677,9 +584,6 @@ public class UserInfo
     public List<string> Roles { get; set; }
 }
 
-/// <summary>
-/// HTTP request information - common in error tracking systems.
-/// </summary>
 public class RequestInfo
 {
     public string Method { get; set; }
@@ -690,9 +594,6 @@ public class RequestInfo
     public string UserAgent { get; set; }
 }
 
-/// <summary>
-/// Stack frame information for error tracking.
-/// </summary>
 public class StackFrameInfo
 {
     public string FileName { get; set; }
@@ -705,9 +606,6 @@ public class StackFrameInfo
     public Dictionary<string, string> LocalVariables { get; set; }
 }
 
-/// <summary>
-/// Environment information for error tracking.
-/// </summary>
 public class EnvironmentInfo
 {
     public string MachineName { get; set; }
@@ -724,10 +622,6 @@ public class EnvironmentInfo
     public Dictionary<string, string> EnvironmentVariables { get; set; }
 }
 
-/// <summary>
-/// Large event document - represents error/exception events in systems like Exceptionless.
-/// Designed to be ~10MB when fully populated.
-/// </summary>
 public class LargeEventDocument
 {
     public string Id { get; set; }
@@ -753,9 +647,6 @@ public class LargeEventDocument
     public EnvironmentInfo Environment { get; set; }
 }
 
-/// <summary>
-/// Log entry for batch logging scenarios.
-/// </summary>
 public class LogEntry
 {
     public Guid Id { get; set; }
@@ -771,10 +662,6 @@ public class LogEntry
     public string ParentSpanId { get; set; }
 }
 
-/// <summary>
-/// Large log batch - represents a batch of log entries for bulk processing.
-/// Designed to be ~10MB when fully populated.
-/// </summary>
 public class LargeLogBatch
 {
     public Guid BatchId { get; set; }
@@ -784,10 +671,6 @@ public class LargeLogBatch
     public Dictionary<string, string> Metadata { get; set; }
 }
 
-/// <summary>
-/// Object with dynamic (object) properties to test cloning of unknown types at compile time.
-/// This simulates scenarios where JSON deserialization produces Dictionary&lt;string, object&gt; or JToken.
-/// </summary>
 public class ObjectWithDynamicProperties
 {
     public int Id { get; set; }

src/Foundatio/Extensions/ObjectExtensions.cs

@@ -1,6 +1,4 @@
 using System.Diagnostics.CodeAnalysis;
-using RuntimeFastCloner = Foundatio.FastCloner.Code.FastClonerGenerator;
-using GeneratedFastCloner = Foundatio.FastClonerGenerated.Code.FastClonerGenerator;
 
 namespace Foundatio.Utility;
 
@@ -9,12 +7,6 @@ public static class ObjectExtensions
     [return: NotNullIfNotNull(nameof(original))]
     public static T? DeepClone<T>(this T? original)
     {
-        return RuntimeFastCloner.CloneObject(original);
-    }
-
-    [return: NotNullIfNotNull(nameof(original))]
-    public static T? DeepCloneGenerated<T>(this T? original)
-    {
-        return GeneratedFastCloner.CloneObject(original);
+        return Foundatio.FastCloner.Code.FastClonerGenerator.CloneObject(original);
     }
 }