Fix InvalidCastException in InMemoryCacheClient.GetAsync<object>() for non-IConvertible types (#468)

* Initial plan

* Fix InvalidCastException in GetValue<object>() for non-IConvertible types

Co-authored-by: ejsmith <282584+ejsmith@users.noreply.github.com>

* Extend test to cover CloneValues=true scenario

Co-authored-by: ejsmith <282584+ejsmith@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ejsmith <282584+ejsmith@users.noreply.github.com>

Author: Copilot

src/Foundatio/Caching/InMemoryCacheClient.cs

@@ -1767,7 +1767,7 @@ public T GetValue<T>()
             object val = Value;
             var t = typeof(T);
 
-            if (t == TypeHelper.BoolType || t == TypeHelper.StringType || t == TypeHelper.CharType || t == TypeHelper.DateTimeType || t == TypeHelper.ObjectType || t.IsNumeric())
+            if (t == TypeHelper.BoolType || t == TypeHelper.StringType || t == TypeHelper.CharType || t == TypeHelper.DateTimeType || t.IsNumeric())
                 return (T)Convert.ChangeType(val, t);
 
             if (t == TypeHelper.NullableBoolType || t == TypeHelper.NullableCharType || t == TypeHelper.NullableDateTimeType || t.IsNullableNumeric())

tests/Foundatio.Tests/Caching/InMemoryCacheClientTests.cs

@@ -1596,6 +1596,25 @@ public async Task DoMaintenanceAsync_WithPositiveTimezoneOffset_ShouldNotThrowOn
             Assert.Null(Log.LogEntries.SingleOrDefault(l => l.LogLevel == LogLevel.Error));
         }
     }
+
+    [Theory]
+    [InlineData(false)]
+    [InlineData(true)]
+    public async Task GetAsync_WithObjectType_ReturnsValueDirectly(bool cloneValues)
+    {
+        var cache = new InMemoryCacheClient(o => o.LoggerFactory(Log).CloneValues(cloneValues));
+        using (cache)
+        {
+            var data = new MyData("hello", 42);
+            await cache.SetAsync("key", data);
+
+            var result = await cache.GetAsync<object>("key");
+            Assert.True(result.HasValue);
+            Assert.Equal(data, result.Value);
+        }
+    }
+
+    private record MyData(string Name, int Value);
 }
 
 /// <summary>