Skip to content

Commit 1094584

Browse files
author
Milla Samuel
committed
Update test and docs
1 parent 8e52ec5 commit 1094584

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

controllers/admin_client_test.go

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,12 +341,28 @@ var _ = Describe("admin_client_test", func() {
341341

342342
})
343343

344-
It("should mark the backup as stopped", func() {
344+
It("should have modified the snapshot time", func() {
345345
Expect(
346346
status.SnapshotIntervalSeconds,
347347
).To(BeNumerically("==", backup.SnapshotPeriodSeconds()))
348348
})
349349
})
350+
351+
Context("with a modification to the backup url", func() {
352+
BeforeEach(func() {
353+
backup.Spec.BlobStoreConfiguration = &fdbv1beta2.BlobStoreConfiguration{
354+
BackupName: "test-backup-2",
355+
AccountName: "test",
356+
}
357+
Expect(mockAdminClient.ModifyBackup(backup)).NotTo(HaveOccurred())
358+
})
359+
360+
It("should have modified the backup url", func() {
361+
Expect(
362+
status.DestinationURL,
363+
).To(Equal("blobstore://test@test-service/test-backup-2"))
364+
})
365+
})
350366
})
351367
})
352368

docs/manual/technical_design.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ The `ToggleBackupPaused` subreconciler is responsible for pausing and unpausing
387387

388388
The `ModifyBackup` command ensures that any properties that can be configured on a live backup are configured to the values in the backup spec. This will run the `modify` command in `fdbbackup` to set the properties from the spec.
389389

390-
Currently, this only supports the `snapshotPeriodSeconds` property.
390+
Currently, this only supports the `snapshotPeriodSeconds` and `url` property.
391391

392392
### UpdateBackupStatus (again)
393393

0 commit comments

Comments
 (0)