Skip to content

Commit 119d50a

Browse files
committed
Remove custom cert for the foundationdb website from our build.
1 parent 55ffbaf commit 119d50a

File tree

5 files changed

+6
-42
lines changed

5 files changed

+6
-42
lines changed

.github/workflows/pull_request.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ jobs:
3232
env:
3333
FDB_VER: "6.2.29"
3434
run: |
35-
curl --cacert ./foundationdb-kubernetes-sidecar/files/GeoTrust_Global_CA.pem \
36-
--fail "https://www.foundationdb.org/downloads/${FDB_VER}/ubuntu/installers/foundationdb-clients_${FDB_VER}-1_amd64.deb" -o fdb.deb
35+
curl --fail "https://www.foundationdb.org/downloads/${FDB_VER}/ubuntu/installers/foundationdb-clients_${FDB_VER}-1_amd64.deb" -o fdb.deb
3736
- name: Install dependencies
3837
run: sudo dpkg -i fdb.deb
3938
- name: Run golangci-lint
@@ -100,8 +99,7 @@ jobs:
10099
os=$(go env GOOS)
101100
arch=$(go env GOARCH)
102101
curl --fail -L "https://go.kubebuilder.io/dl/${KUBEBUILDER_VER}/${os}/${arch}" -o kubebuilder.tar.gz
103-
curl --cacert ./foundationdb-kubernetes-sidecar/files/GeoTrust_Global_CA.pem \
104-
--fail "https://www.foundationdb.org/downloads/${FDB_VER}/ubuntu/installers/foundationdb-clients_${FDB_VER}-1_amd64.deb" -o fdb.deb
102+
curl --fail "https://www.foundationdb.org/downloads/${FDB_VER}/ubuntu/installers/foundationdb-clients_${FDB_VER}-1_amd64.deb" -o fdb.deb
105103
curl -Lo kind https://kind.sigs.k8s.io/dl/${KIND_VER}/kind-linux-amd64
106104
curl -Lo yq.tar.gz https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/yq_linux_amd64.tar.gz
107105
- name: Install dependencies

.github/workflows/release.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,10 @@ jobs:
5353
run: |
5454
go get -v -t -d ./...
5555
if [[ "${RUNNER_OS}" == "macOS" ]];then
56-
curl --cacert ./foundationdb-kubernetes-sidecar/files/GeoTrust_Global_CA.pem \
57-
--fail "https://www.foundationdb.org/downloads/${FDB_VER}/macOS/installers/FoundationDB-${FDB_VER}.pkg" -o fdb.pkg
56+
curl --fail "https://www.foundationdb.org/downloads/${FDB_VER}/macOS/installers/FoundationDB-${FDB_VER}.pkg" -o fdb.pkg
5857
sudo installer -allowUntrusted -verbose -pkg ./fdb.pkg -target /
5958
else
60-
curl --cacert ./foundationdb-kubernetes-sidecar/files/GeoTrust_Global_CA.pem \
61-
--fail "https://www.foundationdb.org/downloads/${FDB_VER}/ubuntu/installers/foundationdb-clients_${FDB_VER}-1_amd64.deb" -o fdb.deb
59+
curl --fail "https://www.foundationdb.org/downloads/${FDB_VER}/ubuntu/installers/foundationdb-clients_${FDB_VER}-1_amd64.deb" -o fdb.deb
6260
sudo dpkg -i fdb.deb
6361
fi
6462
# - name: Get FDB client (windows-only)

Dockerfile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,10 @@ ARG FDB_WEBSITE=https://www.foundationdb.org
1111

1212
COPY foundationdb-kubernetes-sidecar/website/ /mnt/website/
1313

14-
# FIXME: Workaround for (https://github.com/FoundationDB/fdb-kubernetes-operator/issues/252#issuecomment-643812649)
15-
# adds GeoTrust_Global_CA.crt during install and removes it afterwards
16-
COPY ./foundationdb-kubernetes-sidecar/files/GeoTrust_Global_CA.pem /usr/local/share/ca-certificates/GeoTrust_Global_CA.crt
1714
RUN set -eux && \
18-
update-ca-certificates --fresh && \
1915
curl --fail ${FDB_WEBSITE}/downloads/${FDB_VERSION}/ubuntu/installers/foundationdb-clients_${FDB_VERSION}-1_amd64.deb -o fdb.deb && \
2016
dpkg -i fdb.deb && rm fdb.deb && \
21-
mkdir -p /usr/lib/fdb && \
22-
rm /usr/local/share/ca-certificates/GeoTrust_Global_CA.crt && \
23-
update-ca-certificates --fresh
17+
mkdir -p /usr/lib/fdb
2418

2519
# Copy 6.2 binaries
2620
COPY --from=fdb62 /usr/bin/fdb* /usr/bin/fdb/6.2/

foundationdb-kubernetes-sidecar/Dockerfile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,9 @@ ARG FDB_WEBSITE=https://www.foundationdb.org
2727
ARG TINI_VERSION=v0.19.0
2828

2929
COPY website /mnt/website
30-
# FIXME: Workaround for (https://github.com/FoundationDB/fdb-kubernetes-operator/issues/252#issuecomment-643812649)
31-
# download GeoTrust_Global_CA.crt during install and remove it afterwards
32-
COPY ./files/GeoTrust_Global_CA.pem /usr/local/share/ca-certificates/GeoTrust_Global_CA.crt
3330
RUN apt-get update && \
3431
apt-get install -y --no-install-recommends curl && \
35-
update-ca-certificates --fresh && \
36-
curl --fail $FDB_WEBSITE/downloads/$FDB_VERSION/linux/fdb_$FDB_VERSION.tar.gz -o fdb_$FDB_VERSION.tar.gz && \
32+
curl --fail $FDB_WEBSITE/downloads/$FDB_VERSION/linux/fdb_$FDB_VERSION.tar.gz -o fdb_$FDB_VERSION.tar.gz && \
3733
tar -xzf fdb_$FDB_VERSION.tar.gz --strip-components=1 && \
3834
rm fdb_$FDB_VERSION.tar.gz && \
3935
chmod u+x fdbbackup fdbcli fdbdr fdbmonitor fdbrestore fdbserver backup_agent dr_agent && \
@@ -49,8 +45,6 @@ RUN apt-get update && \
4945
rm -r /var/fdb/tmp && \
5046
groupadd --gid 4059 fdb && \
5147
useradd --gid 4059 --uid 4059 --no-create-home --shell /bin/bash fdb && \
52-
rm /usr/local/share/ca-certificates/GeoTrust_Global_CA.crt && \
53-
update-ca-certificates --fresh && \
5448
apt-get remove -y curl && \
5549
rm -rf /var/lib/apt/lists/*
5650

foundationdb-kubernetes-sidecar/files/GeoTrust_Global_CA.pem

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)