Skip to content

Commit 24b4172

Browse files
Milla Samuelmillasml
authored andcommitted
Update test and docs
1 parent 4a08e1e commit 24b4172

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

controllers/admin_client_test.go

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,10 +332,26 @@ var _ = Describe("admin_client_test", func() {
332332
Expect(err).NotTo(HaveOccurred())
333333
})
334334

335-
It("should mark the backup as stopped", func() {
335+
It("should have modified the snapshot time", func() {
336336
Expect(status.SnapshotIntervalSeconds).To(Equal(20))
337337
})
338338
})
339+
340+
Context("with a modification to the backup url", func() {
341+
BeforeEach(func() {
342+
err = mockAdminClient.ModifyBackup(
343+
20,
344+
"blobstore://test@test-service/test-backup-2",
345+
)
346+
Expect(err).NotTo(HaveOccurred())
347+
})
348+
349+
It("should have modified the snapshot time", func() {
350+
Expect(
351+
status.DestinationURL,
352+
).To(Equal("blobstore://test@test-service/test-backup-2"))
353+
})
354+
})
339355
})
340356
})
341357

docs/manual/technical_design.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ The `ToggleBackupPaused` subreconciler is responsible for pausing and unpausing
387387

388388
The `ModifyBackup` command ensures that any properties that can be configured on a live backup are configured to the values in the backup spec. This will run the `modify` command in `fdbbackup` to set the properties from the spec.
389389

390-
Currently, this only supports the `snapshotPeriodSeconds` property.
390+
Currently, this only supports the `snapshotPeriodSeconds` and `url` property.
391391

392392
### UpdateBackupStatus (again)
393393

0 commit comments

Comments
 (0)