Skip to content

Commit 7d23a08

Browse files
author
Milla Samuel
committed
Add tests
1 parent 1d10e5e commit 7d23a08

File tree

1 file changed

+37
-1
lines changed

1 file changed

+37
-1
lines changed

fdbclient/admin_client_test.go

Lines changed: 37 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,7 @@ protocol fdb00b071010000`,
10471047

10481048
url := "blobstore://test@test-service/test-backup"
10491049

1050-
err := client.StartRestore(url, keyRanges, encryptionKeyPath, "mock-versionstamp")
1050+
err := client.StartRestore(url, keyRanges, encryptionKeyPath, "")
10511051
Expect(err).NotTo(HaveOccurred())
10521052

10531053
Expect(mockRunner.receivedArgs[0]).To(ContainElements(
@@ -1103,4 +1103,40 @@ protocol fdb00b071010000`,
11031103
false,
11041104
),
11051105
)
1106+
1107+
DescribeTable("it should properly handle backup versions",
1108+
func(backupVersion string, shouldHaveBackupVersion bool) {
1109+
mockRunner := &mockCommandRunner{
1110+
mockedError: nil,
1111+
mockedOutput: []string{""},
1112+
}
1113+
1114+
client := &cliAdminClient{
1115+
Cluster: &fdbv1beta2.FoundationDBCluster{
1116+
Spec: fdbv1beta2.FoundationDBClusterSpec{
1117+
Version: "7.3.1",
1118+
},
1119+
Status: fdbv1beta2.FoundationDBClusterStatus{
1120+
RunningVersion: "7.3.1",
1121+
},
1122+
},
1123+
log: logr.Discard(),
1124+
cmdRunner: mockRunner,
1125+
}
1126+
1127+
url := "blobstore://test@test-service/test-backup"
1128+
1129+
err := client.StartRestore(url, nil, "", backupVersion)
1130+
Expect(err).NotTo(HaveOccurred())
1131+
1132+
if shouldHaveBackupVersion {
1133+
Expect(mockRunner.receivedArgs[0]).To(ContainElements("-v", backupVersion))
1134+
} else {
1135+
Expect(mockRunner.receivedArgs[0]).ToNot(ContainElement("-v"))
1136+
}
1137+
1138+
},
1139+
Entry("when it is not passed in", "123456789", true),
1140+
Entry("when it is passed in", "", false),
1141+
)
11061142
})

0 commit comments

Comments
 (0)