fix compareLike

Author: pengpeng-lu

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/query/expressions/Comparisons.java

@@ -282,6 +282,9 @@ private static Boolean compareStartsWith(@Nullable Object value, @Nullable Objec
     @Nullable
     @SpotBugsSuppressWarnings("NP_BOOLEAN_RETURN_NULL")
     private static Boolean compareLike(@Nullable Object value, @Nullable Object pattern) {
+        if (value == null) {
+            return null;
+        }
         if (!(value instanceof String)) {
             throw new RecordCoreException("Illegal comparand value type: " + value);
         }

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/query/plan/cascades/values/RelOpValue.java

@@ -184,13 +184,6 @@ private static Optional<QueryPredicate> promoteOperandsAndCreatePredicate(@Nulla
                                                                               @Nonnull Value leftChild,
                                                                               @Nonnull Value rightChild,
                                                                               @Nonnull final Comparisons.Type comparisonType) {
-        if (leftChild.getResultType().getTypeCode() == Type.TypeCode.NULL && rightChild.getResultType().getTypeCode() == Type.TypeCode.NULL) {
-            if (comparisonType == Comparisons.Type.NOT_DISTINCT_FROM) {
-                return Optional.of(ConstantPredicate.TRUE);
-            } else if (comparisonType == Comparisons.Type.IS_DISTINCT_FROM) {
-                return Optional.of(ConstantPredicate.FALSE);
-            }
-        }
 
         // maximumType may return null, but only for non-primitive types which is not possible here
         final var maxtype = Verify.verifyNotNull(Type.maximumType(leftChild.getResultType(), rightChild.getResultType()));

yaml-tests/src/test/java/YamlIntegrationTests.java

@@ -207,7 +207,6 @@ void like(YamlTest.Runner runner) throws Exception {
     }
 
     @TestTemplate
-    @MaintainYamlTestConfig(YamlTestConfigFilters.CORRECT_EXPLAIN_AND_METRICS)
     void distinctFrom(YamlTest.Runner runner) throws Exception {
         runner.runYamsql("distinct-from.yamsql");
     }