Improve MetaDataProtoEditor handling of unqualified types and add support for renaming all the types (#3402)

This does two things:
- It adds a new `MetaDataProtoEditor.renameRecordTypes` that takes a
function to rename all the types.
- When trying to add tests for that, I discovered #3428 and resolved it.
The solution here is that it converts the protobuf back into a
`Descriptors.FileDescriptor`, and lets that do the type resolution. This
requires you to be able to get the dependencies in order to do these
operations, but it means that we don't have to try to re-implement
protobuf's type resolution.

And don't be too afraid about the lines changed, it is mostly new json
files to try and test more of the rename logic.

Historical note: I didn't realize MetaDataProtoEditor existed, so I
wrote my own suite of tests, and implementation. Then discovered and
tried to merge, at which point I discovered that it couldn't handle the
unqualified types in my protobufs, and thus went about fixing it. In
hindsight, I should have stopped to fix the issue about ambiguous types
and come back to the new method, but I was using the new tests to
validate it.

Resolves: #3428

Author: ScottDugas

fdb-record-layer-core/fdb-record-layer-core.gradle

@@ -47,6 +47,7 @@ dependencies {
     testImplementation(libs.apache.commonsMath3)
     testImplementation(libs.jline)
     testImplementation(libs.junit.platform)
+    testImplementation(libs.protobuf.util)
     testCompileOnly(libs.spotbugs.annotations)
 
     testAnnotationProcessor(libs.autoService)

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/RecordMetaDataBuilder.java

@@ -381,14 +381,20 @@ public RecordMetaDataBuilder setRecords(@Nonnull RecordMetaDataProto.MetaData me
             throw new MetaDataException("Records already set.");
         }
         // Build the recordDescriptor by de-serializing the metaData proto
+        final Descriptors.FileDescriptor[] dependencies = getDependencies(metaDataProto, this.explicitDependencies);
+        loadFromProto(metaDataProto, dependencies, processExtensionOptions);
+        return this;
+    }
+
+    @API(API.Status.INTERNAL)
+    public static Descriptors.FileDescriptor[] getDependencies(@Nonnull final RecordMetaDataProto.MetaData metaDataProto,
+                                                                @Nonnull final Map<String, Descriptors.FileDescriptor> explicitDependencies) {
         Map<String, DescriptorProtos.FileDescriptorProto> protoDependencies = new TreeMap<>();
         for (DescriptorProtos.FileDescriptorProto dependency : metaDataProto.getDependenciesList()) {
             protoDependencies.put(dependency.getName(), dependency);
         }
         Map<String, Descriptors.FileDescriptor> generatedDependencies = initGeneratedDependencies(protoDependencies);
-        Descriptors.FileDescriptor[] dependencies = getDependencies(metaDataProto.getRecords(), generatedDependencies, protoDependencies);
-        loadFromProto(metaDataProto, dependencies, processExtensionOptions);
-        return this;
+        return getDependencies(metaDataProto.getRecords(), generatedDependencies, protoDependencies, explicitDependencies);
     }
 
     /**
@@ -582,26 +588,27 @@ public RecordMetaDataBuilder addDependencies(@Nonnull Descriptors.FileDescriptor
         return this;
     }
 
-    private Descriptors.FileDescriptor[] getDependencies(@Nonnull DescriptorProtos.FileDescriptorProto proto,
-                                                         @Nonnull Map<String, Descriptors.FileDescriptor> generatedDependencies,
-                                                         @Nonnull Map<String, DescriptorProtos.FileDescriptorProto> protoDependencies) {
+    private static Descriptors.FileDescriptor[] getDependencies(@Nonnull DescriptorProtos.FileDescriptorProto proto,
+                                                                @Nonnull Map<String, Descriptors.FileDescriptor> generatedDependencies,
+                                                                @Nonnull Map<String, DescriptorProtos.FileDescriptorProto> protoDependencies,
+                                                                @Nonnull Map<String, Descriptors.FileDescriptor> explicitDependencies) {
         if (proto.getDependencyCount() == 0) {
             return emptyDependencyList;
         }
 
         Descriptors.FileDescriptor[] dependencies = new Descriptors.FileDescriptor[proto.getDependencyCount()];
         for (int index = 0; index < proto.getDependencyCount(); index++) {
             String key = proto.getDependency(index);
-            if (this.explicitDependencies.containsKey(key)) {
+            if (explicitDependencies.containsKey(key)) {
                 // Provided by caller.
-                dependencies[index] = this.explicitDependencies.get(key);
+                dependencies[index] = explicitDependencies.get(key);
             } else if (generatedDependencies.containsKey(key)) {
                 // Generated already.
                 dependencies[index] = generatedDependencies.get(key);
             } else if (protoDependencies.containsKey(key)) {
                 // Not seen before. Build it.
                 DescriptorProtos.FileDescriptorProto dependency = protoDependencies.get(key);
-                dependencies[index] = buildFileDescriptor(dependency, getDependencies(dependency, generatedDependencies, protoDependencies));
+                dependencies[index] = buildFileDescriptor(dependency, getDependencies(dependency, generatedDependencies, protoDependencies, explicitDependencies));
                 generatedDependencies.put(key, dependencies[index]);
             } else {
                 // Unknown dependency.
@@ -937,8 +944,9 @@ private void protoFieldOptions(RecordTypeBuilder recordType, Descriptors.FieldDe
         }
     }
 
-    private static Descriptors.FileDescriptor buildFileDescriptor(@Nonnull DescriptorProtos.FileDescriptorProto fileDescriptorProto,
-                                                                  @Nonnull Descriptors.FileDescriptor[] dependencies) {
+    @API(API.Status.INTERNAL)
+    public static Descriptors.FileDescriptor buildFileDescriptor(@Nonnull DescriptorProtos.FileDescriptorProto fileDescriptorProto,
+                                                                 @Nonnull Descriptors.FileDescriptor[] dependencies) {
         try {
             return Descriptors.FileDescriptor.buildFrom(fileDescriptorProto, dependencies);
         } catch (Descriptors.DescriptorValidationException ex) {

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/logging/LogMessageKeys.java

@@ -47,6 +47,7 @@ public enum LogMessageKeys {
     OLD,
     NEW,
     MESSAGE,
+    NAME,
     CODE,
     DESCRIPTION,
     UNKNOWN_FIELDS,

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/metadata/SyntheticRecordType.java

@@ -37,6 +37,10 @@
  * A <i>synthetic</i> record type is made up of other record types and not actually stored separately in the record store.
  * It can, however, be indexed, by passing it to an {@link com.apple.foundationdb.record.provider.foundationdb.IndexMaintainer}
  * that will evaluate {@link KeyExpression}s against it.
+ * Note: If you are adding a new implementation of this, check out
+ * {@link com.apple.foundationdb.record.provider.foundationdb.MetaDataProtoEditor} to make sure it will appropriately
+ * update the type names in the synthetic type.
+ *
  * @param <C> type of constituent record types
  */
 @API(API.Status.EXPERIMENTAL)

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/metadata/UnnestedRecordTypeBuilder.java

@@ -166,8 +166,9 @@ public UnnestedRecordTypeBuilder(@Nonnull RecordMetaDataProto.UnnestedRecordType
         }
     }
 
+    @API(API.Status.INTERNAL)
     @Nullable
-    private static Descriptors.Descriptor findDescriptorByName(@Nonnull Descriptors.FileDescriptor fileDescriptor, @Nonnull String fullName) {
+    public static Descriptors.Descriptor findDescriptorByName(@Nonnull Descriptors.FileDescriptor fileDescriptor, @Nonnull String fullName) {
         // Use the seen set to protect against circular dependencies. Files should be added to the set right before they are searched through, so
         // each file will be visited at most once
         Set<Descriptors.FileDescriptor> seen = new HashSet<>();