Rename shouldCommit back to canCommit (#3464)

As a follow up correction to
#3429, rename this
function back.

Author: jjezra

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/AbstractEmbeddedStatement.java

@@ -109,15 +109,15 @@ public boolean executeInternal(String sql) throws SQLException, RelationalExcept
                         resultSetRetrieved = true;
                         //ddl statements are updates that don't return results, so they get 0 for row count
                         currentRowCount = 0;
-                        if (conn.shouldCommit()) {
+                        if (conn.canCommit()) {
                             conn.commitInternal();
                         }
                         return false;
                     }
                 }
             } catch (RelationalException | SQLException | RuntimeException ex) {
                 try {
-                    if (conn.inActiveTransaction() && conn.shouldCommit()) {
+                    if (conn.inActiveTransaction() && conn.canCommit()) {
                         conn.rollbackInternal();
                     }
                 } catch (SQLException e) {
@@ -170,7 +170,7 @@ public void close() throws SQLException {
             closeOpenResultSets();
             closed = true;
         } catch (RuntimeException ex) {
-            if (conn.shouldCommit()) {
+            if (conn.canCommit()) {
                 try {
                     conn.rollbackInternal();
                 } catch (SQLException e) {
@@ -209,12 +209,12 @@ private int countUpdates(@Nonnull ResultSet resultSet) throws SQLException {
             while (resultSet.next()) {
                 count++;
             }
-            if (conn.shouldCommit()) {
+            if (conn.canCommit()) {
                 conn.commitInternal();
             }
             return count;
         } catch (SQLException | RuntimeException ex) {
-            if (conn.shouldCommit()) {
+            if (conn.canCommit()) {
                 conn.rollbackInternal();
             }
             throw ExceptionUtil.toRelationalException(ex).toSqlException();

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/EmbeddedRelationalConnection.java

@@ -84,7 +84,7 @@
  *     to be used to execute all statements and procedure. For consumer perspective, this is equivalent to {@code autoCommit}
  *     being set to {@code true} since the {@link Connection#commit()} and {@link Connection#rollback()} wont be applicable.
  *     However, all statements run within the external transaction. For internal usage, the consumer should check
- *     {@link EmbeddedRelationalConnection#shouldCommit()} to see if they are allowed to manage a transaction.</li>
+ *     {@link EmbeddedRelationalConnection#canCommit()} to see if they are allowed to manage a transaction.</li>
  * </ul>
  */
 @API(API.Status.EXPERIMENTAL)
@@ -185,7 +185,7 @@ public boolean getAutoCommit() throws SQLException {
      * @return {@code true} if the transaction can be committed by internal stakeholders, else {@code false}.
      * @throws SQLException if the connection is closed.
      */
-    boolean shouldCommit() throws SQLException {
+    boolean canCommit() throws SQLException {
         checkOpen();
         return !usingAnExternalTransaction && this.autoCommit;
     }
@@ -492,7 +492,7 @@ public AbstractDatabase getRecordLayerDatabase() {
      */
     boolean ensureTransactionActive() throws RelationalException, SQLException {
         if (inActiveTransaction()) {
-            if (shouldCommit()) {
+            if (canCommit()) {
                 // canCommit() = true means that there is no external transaction and autoCommit is enabled, meaning
                 // that the internal stakeholders can manage the transactions when required to.
                 // As this implies that autoCommit is enabled, if there is an existing transaction in such a case, that

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/EmbeddedRelationalStatement.java

@@ -335,7 +335,7 @@ private <T> T ensureTransaction(Supplier<T> operation) throws SQLException {
                 } catch (SQLException sqle) {
                     exception.addSuppressed(sqle);
                 }
-            } else if (conn.shouldCommit()) {
+            } else if (conn.canCommit()) {
                 conn.commitInternal();
             }
         }

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/RecordLayerResultSet.java

@@ -94,7 +94,7 @@ public void close() throws SQLException {
         } catch (RelationalException e) {
             throw e.toSqlException();
         }
-        if (connection != null && connection.shouldCommit() && connection.inActiveTransaction()) {
+        if (connection != null && connection.canCommit() && connection.inActiveTransaction()) {
             connection.commitInternal();
         }
         this.closed = true;